From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 911933858D3C; Wed, 29 Nov 2023 08:21:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 911933858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 911933858D3C Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701246072; cv=pass; b=oIkqExDJp0gDZCm7ubKMpbZHnNld+AQPGb+I7yu3XZ8JbCVWjcJj7SpZRL+k65FPjGHZaNqG9QXV5cCgoymVJ1r8E+OOVhAGpvuLWQSwXYFF4rkAh6fQMX9sbOd2awfCiRtp+AsQ4hPDQC2aKyk6yuEbwtaSCjQcde0xMMngOTo= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1701246072; c=relaxed/simple; bh=usyv/1WgL6kSibK85brTtN4b7Y/LlrvHWZSwruGCzWo=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=Jw3DYZwBqPSQe/Rxsv3SwYm4SVUe0+jhBixxdYIdqKGFTTMCv05G8j7p6DGOEwebyYDEy4wI1Ukkn6UIqX78OK+QilrWZQ7A8LJ0UdlfVMwdY6tV2jVJOXpLUZemqQ1Z0n/Wfaanes/s0brwR0loosGo/ZJKvq48XcN7piNMCLc= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AT83x9T020501; Wed, 29 Nov 2023 08:21:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : mime-version; s=corp-2023-11-20; bh=x+a1VvtrqqpPnYtO5ocZtoLHaBYzlmEqHIt6X3RVnH8=; b=EfsappO84gGvS7uP6DJ/Bjlm62uDuxISqUwXQ2IE8V6VYP5qP0WcnEDqlwaCFP8p4V6E oVUfaop0TbuC5pyr6rKloLiVynpygNyavZB5AKKP2TXX3ZcQ8jMdf5fahkC5WpGIdbEb ld/dmc1ASAA8L6fEngJIkFp5E/mIYfHYNjoLFUAdn1Pb9qXowe4uq7S7XPJrECvWQoWa T5TRxQ7RcfVLk5eiKUkZjTaD1j51JBIvuKy8TS410pUlNIlrhJjB4d93eTbIWnxs6xdg EyixJMafP8waAMPwuSHdrxO3JGdACTdXMYIOkLsswRYXTpl6OaZKXwWQ6Kon6tNwNPMD /A== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3uk8yd859y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Nov 2023 08:21:03 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3AT7HYaK026514; Wed, 29 Nov 2023 08:21:02 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2168.outbound.protection.outlook.com [104.47.56.168]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3uk7c7xn20-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Nov 2023 08:21:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KKpEL86U+aRZyWErin3MH5kznL1UDPkTQVBMZ4J9dR8LBmnX8yyihtMebzCg2WHFyjh+Cm2WaYMC4jdFFb1poaPSg0YcNoOb/I7llKnMchFskb08YzQRn2bTeozMdf+gcUsLZiWxS8/x+GenIm32LWZPfkLD6+G4giAmSNlkvguvEVlXp4ycKYQ85EcgfVjT3MnlaLtQdZ8LKzqGjxD3w40KICmF3FMbN1VYGVgiv4pVVp/1wc+QFH4p6mTpJi2rvm1EDwtPy1O2xEtxVRtGKYwRQnQ7u7vDZbRefk0sX93FaSYq8lRMYJ3RF/WgIACdisflMIQB4TYePsbfTqESHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x+a1VvtrqqpPnYtO5ocZtoLHaBYzlmEqHIt6X3RVnH8=; b=CJDfY/nbVWZTawFYLf564cKKwDNjvnkLOSSIG5f9jSGpKw1mhsxcF6AxigYmdPYB8Vv+Nr3OanS877hIrT5Cscad+IjGJk/jMS9dsBaXWi9hXQGHrqOU85v1NFUZuqzuieR+4potJ68gVC1zI72LEw2XeOgxauSVzGZGBVHwHXpQ8vu2+Zc2KD0R2szZTFM/iSukBiqVTtkc6sdPD/7QH+yH0Lc3Lyl3Dkxr5NZg1/BYPWLhW8VGzOHEgIVolsz7i+R9P4lGy9jYCzEZjVBW6UQYAHME5Ifm30rkIg2vJXAiEJkITBYhuoiFHrAGATYXgjQOCfmfMwc0B6U+tHf6ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x+a1VvtrqqpPnYtO5ocZtoLHaBYzlmEqHIt6X3RVnH8=; b=La6Lfu9EhHPVE0wpCq6TvqTFprvPya6TzOEcRzPSU7GrQ4s9yj7zShFFFBy3JbVqKhGsVIT5LU0d/0l16flOnqqsoRVDG6GrkxHARuRrfeBT/zs5iU/X3k8JgdeldIFew2n/GlPb3eJ/j4O+8fbU7nH4Vb5WxG7rWBL3F8msAms= Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by DS0PR10MB6127.namprd10.prod.outlook.com (2603:10b6:8:c5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27; Wed, 29 Nov 2023 08:21:00 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::ba16:f585:1052:a61c]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::ba16:f585:1052:a61c%5]) with mapi id 15.20.7046.015; Wed, 29 Nov 2023 08:21:00 +0000 From: "Jose E. Marchesi" To: Jakub Jelinek Cc: "haochen.jiang" , gcc-regression@gcc.gnu.org, gcc-patches@gcc.gnu.org, haochen.jiang@intel.com Subject: Re: [r14-5930 Regression] FAIL: gcc.c-torture/compile/libcall-2.c -Os (test for excess errors) on Linux/x86_64 In-Reply-To: (Jakub Jelinek's message of "Wed, 29 Nov 2023 08:51:41 +0100") References: <202311282319.3ASNJpIe3198873@shliclel4214.sh.intel.com> <87v89lt5lo.fsf@oracle.com> Date: Wed, 29 Nov 2023 09:20:55 +0100 Message-ID: <87ttp5c6mw.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: text/plain X-ClientProxiedBy: AS4P191CA0004.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:5d5::10) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB2888:EE_|DS0PR10MB6127:EE_ X-MS-Office365-Filtering-Correlation-Id: c615236b-0b9f-4acf-7c25-08dbf0b41e83 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Mz84MkdAWBn2i+ID4s/rWxq13V5d7MTXv8DSo+fzachkHnelTd1zF0vMtu5lf0UsjwvS1k03fUO+L8OpEVyMQJ5/uhJufpbNNbR9hKIvjsMqS+C0Tz7yx+ps7tggqNBgPz2yeujWovV+B3gNL6r3yOYgucDBJyy1vb6aeNZVrwRLS4eki3RvDZgDl5eLAncHwO1ckVEt6lfwnEgirwNE4CO7AsoAk51BaM7NpNaOJWnX7QZnrHhhcw9D7QkjX+MwE9bCDm2CPHrzFYPzzMdcpf9vN2GQzRWUpWFbJinjn4iep9v+dKlNj2u/2wiFdbrdTvfZfeQI64/b2S2HA5XDdXRJgGEGo5z2BNZ6g9RwyU6wew6RkhLX2ssJmN+To9IttXFfxN8P6xyR19UkTnxTotqEaezgwJOnYK//9Y6Mz17bRN1BFMbRSBvBBIwvyun7U4KuqtX0S3BTSUEycmW/MP3ph+wF1mrJRECMOUAR2CXs7iHaGmvDjzTF1goybrZUuZarAJXsHreXiTBqN+6jQuticQxmh5fXibu/ohKobCuRIEi9+a6hxmhz+smlgYQoathgd3eIk8Xdq7gxF+1VaTzndvJyw0GKyIaYfddlo0ypbD+G7dKgkKDglJoPgx5U X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2888.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(346002)(366004)(136003)(376002)(396003)(230173577357003)(230273577357003)(230922051799003)(64100799003)(451199024)(186009)(1800799012)(6666004)(4326008)(8936002)(8676002)(6512007)(6506007)(53546011)(6916009)(66946007)(66556008)(66476007)(316002)(6486002)(478600001)(86362001)(36756003)(38100700002)(41300700001)(26005)(2906002)(2616005)(84970400001)(5660300002)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?e2ML14F+7AnVfqosTHrJWsAWFFVCllZjBySIh3gbgm/SlAP35/ZkpiBSydjv?= =?us-ascii?Q?x5BhPvQ/MDHgx/aqrlybwc4JDk1nCk/QNB1VDM9UNds4c8khEabVMTMsWOp8?= =?us-ascii?Q?D8YDeDJ3txBfKw8J/19c3Orn6qbtdSJNzLPRN5bsZbTUJmcnkrXKlLwXxufG?= =?us-ascii?Q?ie/lWOz0J4vE1kV5H2+b3VJMIiGUwLcDs8dAnl2aW9t3SYRZvstKlFPOAtN2?= =?us-ascii?Q?qL5q7qzDsa21blAGfjM9tT0dJL3Dv19axE26o1gC0/TaOBLqpZMYiaPQnUru?= =?us-ascii?Q?cOpMhEB8XLlPnI47LE0yWyoTcQV3VC8MK26lcSXpfeObyeosh7mdiVWnUJH+?= =?us-ascii?Q?qh1wOuezBAMflKI4rGiUFS+uYXIlTs0Iboo+fUxlJirF/KsRL4nDicouned7?= =?us-ascii?Q?EHJfWw8wiC/6LTIcUSKdc3MMMov6g8Ju8trF3cLtiqOdUHVtAWiTN+M80ZGk?= =?us-ascii?Q?e56Q9GWmQBxzs0G6P5UBaB/UMFnlNLAlyGAZRn9ZKp4ccqiA8OvV+9vHiHJq?= =?us-ascii?Q?ABmZyUwrAz9OuQjcj5zRmFopnlP4afg/MpkhuWh42rzUIJxLuV34BFS8zGPw?= =?us-ascii?Q?eS6Q009stNimfgwBOPT4FOyDO76gaKzQLlc1pfq55PU09diTxKizKecEjDKB?= =?us-ascii?Q?0/TEUH8Hyq8sx/A7MjcsHX6Qp3m+KF/G9kWv42LOSZjuPNjF7xfApd4GmApd?= =?us-ascii?Q?o19BhI50W0m5UtK6dUyFoIeXZ3C12YZPfN28NiOIIx4880W7a2Hf9L8qeTBo?= =?us-ascii?Q?C+61cxveZ7s2JJApBTvIJX6mA68PqiZqDwllMUs4qyy9RTDKWPgQpWVSlHSw?= =?us-ascii?Q?FQaGgux0JaRYSuPRUUEZmjZHraY2LGx5aovHPv+e3kZp+rqGKubMDN990Ypm?= =?us-ascii?Q?CRnlLBfVC05S97QGTKJmT4cwjcCAxZKW/qc2rQ/OiULLnt30HHTWjyTlESgH?= =?us-ascii?Q?6vFu2cAaum5rMt/yQxVXVDFGmvw8E/NKgKybfXdaABjIQFnp5R+TCliE34G+?= =?us-ascii?Q?wS67Qq7XmRnQqmpgmmBxW9Wt4+iIWPo2zfLIoEPhsTDDOhisXIgIgmAPiLPu?= =?us-ascii?Q?AgbxvLbP1gKgNlE7xcAwQkovxapCvrUg0KOImiwA1QKSIRTnA0O5QP2sK3w9?= =?us-ascii?Q?1576tyelSFvWktuyeNJ+qG4MlxDUi/NDxp6uuPKypudmcbXHQnhIpKIRs1/u?= =?us-ascii?Q?zd7FRNE9qifJQB9DGEN6uICfLJs9Ft7bVMeFiBLxseVWKoJov6CxJiJpjtDl?= =?us-ascii?Q?2KbvaZgIFz2NG6TDYcEcfZgEhcmHe0OjlUksoOffodOWieoyVuWFs3qMMQmC?= =?us-ascii?Q?UTrwY7jsKsYWq9h0/RNgO08L6qYI2uPvIBB4ReCzlb3Qp2yfHFl1aVYiyxa8?= =?us-ascii?Q?UEQacroicAbbFy42VNzSPh2rO9QY/7VUYukHyv7EDXiX+8P4+O2UAUduz0pM?= =?us-ascii?Q?E4EdCCERwi4E/oG0ErgPLfaTrU527YXErajRkRLpJV4hctOxQqDro/GGI1nd?= =?us-ascii?Q?dWTSGa+TAava4bCfc8C/QkweTsoTYWWeRyk9rTgXaAQXiQPhE2w92GnGSjem?= =?us-ascii?Q?BgydgRJWwlZyt9cuS2o9amyOiMh4Yo8FCg9KBPShwcZNf9M9M8NmI/15Vrv3?= =?us-ascii?Q?Eg=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: H1WL0ZmDkTbrPNg3ZHRk7+Yiyq/VbkM4puqOYgfbpFgmWFilq55BZUEexwVIrKs2zsr5lJwN/rfJBtSKHDMLFvoxSB0U/0ekn+a4XqY7OxFMHd0CF4OAhMdC4jfoXiyh082TLDFAowQTT8tylQTfMfs7I+niplD//lSa2UQLZjO126ZdV0qoIwaI0AflNhbp0DHYHWz3btgrmRfw0IjomWT+fPHL0/8RCKfDE3Tcasdf7c3SmjciuP3rxsS3IPsPSIEIQjS6pDK7jsW6gpjQvnM7Ba9E4hY5X6sIDxCEiKqsFWRgLCvgIp2BZmy+2jGqbrBxxobwwsil8E7nlX1zG7aqcM0jnyfEV6QJqFbmRZL21qpOtkV2yqAXIpgzubOzn5fbx8YiDunj6Ig1etJdpWd43osifvpLoyOeX/GWf/ThvR2tyt1P6QQ6yYJq3wiu4nJrxKen73OBNbMjNGg944WptE8qSZv0MJ56a883687I3f1QoRUmFlnonFEsrv5MfXy4VEsU4wPywd1YSL4ml2LX4coL16kJOrjlXpWqaSw7kkYzteYItbIPJ6ava4FaLJkwfeFoY0tW2asniGg5ZMizHMPx2isoqYOYSivTtewAqXMT+cY7bilOwBs83k9T2hfYUnwD8uHt2JgY6H6KsFSDrWtddcP8mQWQo3YIt7BSr36zOrELSW8AUvNa8onQcFlGnqxS319bfFGS5mtcDSo9+wNCQsW77b//r/B+33+bt0ytFyJsiF0YC26NYJXjJOGbdPEW1KA4eTK6fgIqf6VcFOw7dTkUU6BOcne1WBnWe2GTScyQLUZew625GhlcRUT40vN7q7lksM1qMQYO6TozpqWEVkRFuV/jYpMx0QI= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c615236b-0b9f-4acf-7c25-08dbf0b41e83 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2023 08:21:00.2208 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SoQdSq+Ned0OrfKtn4xoQV5Pb8A9H/N82hSl8bQb8w8mVAazN/ZfMLtNXT/DE6xkX3wXFAOZ0qHPuqAl5kOqP0ofCAJayHwmuf2Q1kyVus8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6127 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-29_05,2023-11-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 adultscore=0 phishscore=0 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311290061 X-Proofpoint-ORIG-GUID: J9A4IxbNKkXXJKUdfT1PMeXOiZKWzaEd X-Proofpoint-GUID: J9A4IxbNKkXXJKUdfT1PMeXOiZKWzaEd X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On Wed, Nov 29, 2023 at 07:51:15AM +0100, Jose E. Marchesi wrote: >> > FAIL: gcc.c-torture/compile/libcall-2.c -O1 (test for excess errors) >> > FAIL: gcc.c-torture/compile/libcall-2.c -O2 -flto >> > -fno-use-linker-plugin -flto-partition=none (test for excess errors) >> > FAIL: gcc.c-torture/compile/libcall-2.c -O2 -flto -fuse-linker-plugin >> > -fno-fat-lto-objects (test for excess errors) >> > FAIL: gcc.c-torture/compile/libcall-2.c -O2 (test for excess errors) >> > FAIL: gcc.c-torture/compile/libcall-2.c -O3 -g (test for excess errors) >> > FAIL: gcc.c-torture/compile/libcall-2.c -Os (test for excess errors) >> >> Sorry about the regression. >> >> I installed the patch below to skip the test if the target is not x86_64 >> in lp64, as obvious. This should fix the issue. >> >> >From 4ed0740c6e807460ce79a351094329fdeb551545 Mon Sep 17 00:00:00 2001 >> From: "Jose E. Marchesi" >> Date: Wed, 29 Nov 2023 07:44:59 +0100 >> Subject: [PATCH] testsuite: fix gcc.c-torture/compile/libcall-2.c in -m32 >> >> This test relies on having __int128 in x86_64 targets, which is only >> available in -m64. >> >> gcc/testsuite/ChangeLog >> >> * gcc.c-torture/compile/libcall-2.c: Skip test in -m32. >> --- >> gcc/testsuite/gcc.c-torture/compile/libcall-2.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/gcc/testsuite/gcc.c-torture/compile/libcall-2.c b/gcc/testsuite/gcc.c-torture/compile/libcall-2.c >> index b33944c83ff..9b889172025 100644 >> --- a/gcc/testsuite/gcc.c-torture/compile/libcall-2.c >> +++ b/gcc/testsuite/gcc.c-torture/compile/libcall-2.c >> @@ -2,6 +2,8 @@ >> indirect calls. */ >> >> /* { dg-do compile } */ >> +/* __int128 is not supported in x86 -m32. */ >> +/* { dg-skip-if "" { ! { x86_64-*-* && { ! ilp32 } } } } */ >> /* { dg-options "-O2 -mcmodel=large" { target x86_64-*-* } } */ >> /* { dg-final { scan-assembler "globl\t__divti3" } } */ > > This is not correct. > When a test uses __int128, it should be guarded with int128 effective > target. > But, as the test doesn't really test anything on non-x86 nor ia32, > it doesn't belong to gcc.c-torture/compile/ at all, it is x86 specific > test which should be moved to gcc.target/i386/libcall-1.c > And, should have > /* { dg-do compile { target int128 } } */ > /* { dg-options "-O2 -mcmodel=large" } */ > /* { dg-final { scan-assembler "globl\t__divti3" } } */ > I guess no need to bother with the extra guard for -mcmodel=large, > because -m32/-mx32 don't have __int128 support, and x86_64-*-* > is incorrect anyway (because with that target one can have all > of -m32/-m64/-mx32). OK to the patch below? >From a697f9e9442d96d3eda228b825dd8e8e06206c03 Mon Sep 17 00:00:00 2001 From: "Jose E. Marchesi" Date: Wed, 29 Nov 2023 09:16:48 +0100 Subject: [PATCH] testsuite: move gcc.c-torture/compile/libcall-2.c to gcc.target/i386/libcall-1.c This patch relocates a test that is really x86 specific, and changes it to use check_effective_target_int128. gcc/testsuite/ChangeLog * gcc.c-torture/compile/libcall-2.c: Remove. * gcc.target/i386/libcall-1.c: Moved from gcc.c-torture/compile/libcall-2.c and adapted to use effective-target for int128_t. --- .../compile/libcall-2.c => gcc.target/i386/libcall-1.c} | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) rename gcc/testsuite/{gcc.c-torture/compile/libcall-2.c => gcc.target/i386/libcall-1.c} (50%) diff --git a/gcc/testsuite/gcc.c-torture/compile/libcall-2.c b/gcc/testsuite/gcc.target/i386/libcall-1.c similarity index 50% rename from gcc/testsuite/gcc.c-torture/compile/libcall-2.c rename to gcc/testsuite/gcc.target/i386/libcall-1.c index 9b889172025..8bd6684a925 100644 --- a/gcc/testsuite/gcc.c-torture/compile/libcall-2.c +++ b/gcc/testsuite/gcc.target/i386/libcall-1.c @@ -1,10 +1,8 @@ /* Make sure that external refences for libcalls are generated even for indirect calls. */ -/* { dg-do compile } */ -/* __int128 is not supported in x86 -m32. */ -/* { dg-skip-if "" { ! { x86_64-*-* && { ! ilp32 } } } } */ -/* { dg-options "-O2 -mcmodel=large" { target x86_64-*-* } } */ +/* { dg-do compile { target int128 } } */ +/* { dg-options "-O2 -mcmodel=large" } */ /* { dg-final { scan-assembler "globl\t__divti3" } } */ __int128 a, b; void foo () { a = a / b; } -- 2.30.2