From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 8CF4D3858D1E for ; Fri, 13 Jan 2023 15:13:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8CF4D3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30DDGkM6009535; Fri, 13 Jan 2023 15:13:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=references : from : to : cc : subject : in-reply-to : date : message-id : content-type : mime-version; s=corp-2022-7-12; bh=oEk0ChvyPn7e6kQ5RJYg1N1D5Gu7qv3FgFYr9tBWqu8=; b=t4JO4Bex6K//OBRREDup1bvrckHYgppvRgxsme5Mhl9Y9scNQjHpbpOQDUdtjfCC2Ei8 sv5YZyA77kY9xet1s1AMXR9m4ahZi5zgB0Z4ccFCXoELNCWanp6yf4b+zVUwCpLO16Ej Zc3FsVADeqISviL99UAWttUCvG+d+d7evhKQ/zeCdMipCuLOES6Fd5j2ZLhHZ+FnBsso u2wJ6kIukwkp2hQsaSx0vCgXYCDIvuUgfaPTKxLZrA6l9M9OEAzOc5QjxC2tT5c0E0TW YeBXg1x5PQis491MZc+wRRvOgZroH23D5eVmTUtnlLmc38sr9kc1x6Bhz+jKKxE/r4vC Xg== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3n27nrbt97-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 13 Jan 2023 15:13:09 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 30DDhA6t008333; Fri, 13 Jan 2023 15:13:08 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2174.outbound.protection.outlook.com [104.47.57.174]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3n1k4s9umf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 13 Jan 2023 15:13:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X2/hydtVUyYmvWyZIEQ3JW4zoVDHMtWPBTBmxab7MQaIMvMNZnOFLcaOaqBSCUvYigEtILq90syUHT69+giAvebnbtVWEaAoqoAoooRpGyoh33VC7hxBnGrRMJe/sbUk9XvkOsByKMvWnpG3OsriFi1MCbE93WSbZC3ZVn2cZ02TMwDqqGLFvRWUIJY3bItpKfdpvqpfNC/83ih+v72fg7Tep+fR7pLOIFAUrP+F2VS1i5+leu5kSVMmiq15XGWtmpOT7AP48ZYc/97JT9XIJD8kEgv4mxMgNBN66NWw86hGYeUyTFD014LgHEZSiG4ROvI8q4Z4QFV+f0jDJMCrqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oEk0ChvyPn7e6kQ5RJYg1N1D5Gu7qv3FgFYr9tBWqu8=; b=jebqBlNZ4ddPwmEiENxgMYQ5/B0Kknm/2TacEx6pJCHHH+EOJuBTZnG6TWGl3gQZA5/5O+QnovhRXPsYIU+LgoxoesZ8Q6Uk9zouLGUkGUehoWJMtZInSFVHGFJ3MoloFeKQO5UslcxHflAKbA4xKeHSIcndU+BcOKYytLx2yNj37HwIourb3/3zrVLs0jg6Jy91NkrZ04y6sk4DJhzc9+h+Tt/GmDgPbXIKtS4mkjeS5rsAuDGn7dcNiiNYZOLj4FmWuzYpvJpHE77TlhBLoIMiSKGQLa+Rw0sL3fEpECemJAmCEaTYEGjCfgTMxjfUXSc33MsBhaWhSW5WCF6sdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oEk0ChvyPn7e6kQ5RJYg1N1D5Gu7qv3FgFYr9tBWqu8=; b=E6/55L07ntD2Va5W/AOzumLI/+oYOSg297IcO7R+2vpoeX2lL/v5Ame3P/EOxAypR7oLXN9Xqw9jNyzxiTNTcMBsmVW+uy2+5uzvyYi0+tPe/WJSinKtj9YgxwtMVD23VpMau80PvQEBNKYaH0E+U0yzxRoNSbW+hivF2vN5YK8= Received: from BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) by SN4PR10MB5624.namprd10.prod.outlook.com (2603:10b6:806:20b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Fri, 13 Jan 2023 15:13:06 +0000 Received: from BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::2b7a:b98b:e12:b750]) by BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::2b7a:b98b:e12:b750%7]) with mapi id 15.20.6002.012; Fri, 13 Jan 2023 15:13:06 +0000 References: <20221202175225.2780-1-cupertino.miranda@oracle.com> <20221202175225.2780-3-cupertino.miranda@oracle.com> <795fde7f-5bde-d1a5-e790-b15774effd1c@gmail.com> <875yen5ib4.fsf@oracle.com> User-agent: mu4e 1.4.15; emacs 28.1 From: Cupertino Miranda To: Jeff Law Cc: gcc-patches@gcc.gnu.org, jose.marchesi@oracle.com Subject: Re: [PATCH 2/2] Corrected pr25521.c target matching. In-reply-to: <875yen5ib4.fsf@oracle.com> Date: Fri, 13 Jan 2023 15:13:01 +0000 Message-ID: <87tu0uzcw2.fsf@oracle.com> Content-Type: text/plain X-ClientProxiedBy: AM3PR04CA0134.eurprd04.prod.outlook.com (2603:10a6:207::18) To BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR1001MB2340:EE_|SN4PR10MB5624:EE_ X-MS-Office365-Filtering-Correlation-Id: 001c1d64-c743-4958-171d-08daf578ac42 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CjsSBsoj6wNiZZnlrsTC+xVC0002tjowLh7/LgoCJI7hdex19ilI9QQpfV5AUU3eAL2BoY/BQh+7CX94p2KmriTsRbSITuRw3MLb7bSji9u4RP/OZY6URO5gXAOyKogDyLjvr1wl2MoWI4s97dMcmnqxW9uRuDp4jN52LkYyOhythZ5la3YeCNrS96N3KUCHtdjM0ah3qA6va5SzJfewg3kmqaS3KZxd28zX8xW5pO2a1+zk1b4vDq+o8AD99kcgM17NCGExu+3e1xwuVMJYBlIAAkhKHU/mR11ALG2ZYQv5nct3FJ3SSidtUHDkJ5Di9Kn4k91Pcs6ZGMQ6BtblnM82paHXSrW+ITIkf7LFY4lkw3q3l4tOJwCoK9p433rnAODoSjrQq1+sSfQeX8h8iWl0VjR/vBd7jRzdT3StcQrG2JCQCeKyP35ujHCb5xx5VEoU/JDT9wLmNo8gB/F5MVsqNiS6BWCFajSGIZObZVR6kDghmU4Kms4zZItBxyJ8w0iXDNeg87xNavv9afE22w6504wZCQ72be7fD2EYVKObWf3oTRFCKr9XVct/uZ1RWkmtQ+I6ErP/mpwfbIy+RsSPDlSSD1pbcgtXnqPEr1UVw8YwcWmi+cAxRnegiXNTvk3xkhQmEL43tWSE6ck58w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1001MB2340.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(376002)(346002)(136003)(396003)(451199015)(478600001)(6486002)(41300700001)(6512007)(38100700002)(66556008)(316002)(2616005)(86362001)(66946007)(186003)(66476007)(5660300002)(53546011)(107886003)(36756003)(6506007)(2906002)(6666004)(44832011)(83380400001)(8676002)(4326008)(6916009)(8936002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?78NHPtcXjdDASQvaJv+k9uyyWVpqYIBqGhVMcMGwrAjNyUA7DHNOZQwoIgUt?= =?us-ascii?Q?ynhr2Y8QXtjRsUIA6v/MGSLjjz84EggB3QPkbiQ2klnaq0jS0E+McGOPNTaA?= =?us-ascii?Q?m8bVHXWPhxqo37UfStvD/cEaZ75T6QaIvbL21QkLGImVZphu4HSSUbinBD07?= =?us-ascii?Q?oaGY38da6V7CB/4U+SQ3VWYmxkyIpF6oNNJNAlWvioinYl4J7srzLVk/29ia?= =?us-ascii?Q?R6VVYkuZrH2Sq5CL+HVylyICyVCpf1gffAWxSpj3eEZ42OipNkNvY3t9EE0S?= =?us-ascii?Q?gfr9VC5HzgjqgD2g/9PEWxeGXQQb5ssm1RRcxKDZ2gVrCxsZvHssY4oMi+zF?= =?us-ascii?Q?vBZESp1oQtN1w/LdoRKVKiQ4csC/WLa82gTmYaNsJfj8p7titQWYFHnTu/Si?= =?us-ascii?Q?XWhLVy64wRg2uvLIdttGEwRMIgdV9v+3ituLeELzavzzOCY12BtY5reTh7xR?= =?us-ascii?Q?QyW5fVSb8+7UrXab9WPIuZWtOkNDCUbWxcJGAhBvXzXQHVYnwRSpS+Z0DnjU?= =?us-ascii?Q?ucweD4iRvcCWBKQxbczTB7/5SMTgyWNmKONEBjKP6q+1EYHNVmHeoeMlH9fq?= =?us-ascii?Q?UFm6rqwMb0sgwsqYlNqfY5jGico5WVE49bRrMjOd23qjNmo+mdOlqF9NBGfK?= =?us-ascii?Q?VBU0gys9HPeTgfujv+Le2FLxpIaIoyJEG7TgY4A7bMGa9NFcS29K075svrWo?= =?us-ascii?Q?HZhZOb0KUzhfsSRg8FiIo8cz/K496zZWEVUTMshLCWQwfEt8nXtwTn8DOkkp?= =?us-ascii?Q?GiZfGm/N/LeeY5uoxWLHcU8pqBuEUZto8R9xlIWbj/6oz674v30zcILxqcCz?= =?us-ascii?Q?bTAI3GmnkS4vltpj/ZWObVboCNmYJDP478XuKkrKFTKqCRPvU5Lcdw9D3Rfd?= =?us-ascii?Q?XNoQujseJr03biTz/RDZmbvfrBuoAzJnWL0OhcEXQg6gUo29xj12GkEzrGmy?= =?us-ascii?Q?KvuNO129ypJ0vfbQXkYGyamMXCUA8aPng/CSoiklQi6haDxr22wCfquv+8SF?= =?us-ascii?Q?3TkViL63HUpfFzke+Q69hf60gGsCJliu0QJ4pkAPxy0jrzCI/KyzY9EeGjKX?= =?us-ascii?Q?X9V9Y5+8lr7pnMNjsJQJN9tSDwCtZ0B9OtZtkBlbbbm/9sg7s0afSJcW8QXZ?= =?us-ascii?Q?8H3+ntR97S3Qaiv2c34dJGP4ZD3UCj90kQyW0zv1+7lyuK+qMCczGrKu36PG?= =?us-ascii?Q?/ZZnJwyYVbIkURJC8FPjmkuuS9lHdUre07hGw3IU/jRJLxO5MsNnKe3RuGNZ?= =?us-ascii?Q?R2MMQUsTlWAgecgdJaIPXD7wMQSQmpeOjdyX9SymZcbR1sgOywZXAaPfcykv?= =?us-ascii?Q?RJBFWt4efcbKnpxSVWG8Y3vKp5Clx7Ze/Zs1NbTzT0s/1M6s1drqqIW3uBd3?= =?us-ascii?Q?V99vlrePwD1HhG1IZM0gMFFapG+Q5ux23n7kUIhG+HdlInXyTCLgr95yuaU0?= =?us-ascii?Q?XeqpSL0zKiQJbOkDyI1ctPgDEE9Rn3l8h3eAP/Wc0iOWS0eSofKzaYkeDthL?= =?us-ascii?Q?HPcBn+i5AQ0P9qZcZuK+ZqBhY2tDjWLuuFX5hJza9EdPqWMxYPPKALVdFQpk?= =?us-ascii?Q?qEW9PFImhtst1zT8XYfijLQzazbVudTvfKUVO5dW9Mx9aXwB24ouJkaeaOu0?= =?us-ascii?Q?KgF8rJiaXfWNpfBDUFMwFQs=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: d6rs6s6Vin177LEacJSyVnseMqla4iaxqdnMBzXVGgcI2aa0eZIho72YdrBqtc3I8TurzgQ4Ev2SMFGvWtcIAdyIAgZqDOe4eHsR0w3NDJRbG6rm0oFVcAX7XxHiBdvK4OiBi5bCTIJWp47lnJO3EiM8EhwiN6fgBEMes3SaVnh2YKPL4yExd63p8CipqPw9GanwLzScYYnfJd4wIPNPyQY41C25i2ZrgU72vDbw/NXi/hdFQ6jhherS2xyOj5dbJ9TtD7fpmCEr2fx6Z9+sUG7QMn5tOuK7R1cDWREmM183vrdvqznWQM0/jbnhcaUWh4R2WH0rocBmRv6urgQ7QqOKLRCf2LsTYmXqZ8LpZqrM/dAy858U6MStdZvMLhRkotJdf1bLMCe+HJYEWHht3jjlnMUWXWCU/ex9vGbIKNvDxy6y8TbkC//+RUdfqzgAIHb+bZp2k0pdeEFnMiqEW6vRZt75fKDRCgalYjsM87FCDDq98GuqksgdByLuFlXFQOcpSemb7e+xo9tQOqRZprUGBkXo9VkfaQtu5Wqz22zwua2Wb6vVfmqdyGXT0yIGoDDTrDej2WLIYJQkqStTrIAhg1GGAFlszQwb6eTca5irfuWpjViPwWCoIwwiJQo4r06bRVuHz4nAusfWo8/hxjaIUyoJ/K7As0oqsqpqFRd1vmo4vqoyUycsAXlOyTNAUlLHQk3IBvrKwJ/NwJIZ0hzfw1LnDaADO5gSaLg6cVcJWIQjttowni/lOqIPbYtLEpgTaKV54y2ft8FwoX+2dQ== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 001c1d64-c743-4958-171d-08daf578ac42 X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2340.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 15:13:06.3739 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7FB6Wsj67l7j/uAJxcxPuALMyfCAQcnpFqmwfT6B0co6Os/Bb9K+yNJdD/3H6fnTxlFha9xhY/BKvvXw4Qlz3t1BtY1n+X0F+G6qOqYyMrY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR10MB5624 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-13_07,2023-01-13_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 adultscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301130100 X-Proofpoint-GUID: 6KIOBaUZLHF1QJwLPZhN4zxBhnLVE5s_ X-Proofpoint-ORIG-GUID: 6KIOBaUZLHF1QJwLPZhN4zxBhnLVE5s_ X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Cupertino Miranda writes: >> On 12/2/22 10:52, Cupertino Miranda via Gcc-patches wrote: >>> This commit is a follow up of bugzilla #107181. >>> The commit /a0aafbc/ changed the default implementation of the >>> SELECT_SECTION hook in order to match clang/llvm behaviour w.r.t the >>> placement of `const volatile' objects. >>> However, the following targets use target-specific selection functions >>> and they choke on the testcase pr25521.c: >>> *rx - target sets its const variables as '.section C,"a",@progbits'. >> That's presumably a constant section. We should instead twiddle the test to >> recognize that section. > > Although @progbits is indeed a constant section, I believe it is > more interesting to detect if the `rx' starts selecting more > standard sections instead of the current @progbits. > That was the reason why I opted to XFAIL instead of PASSing it. > Can I keep it as such ? > Jeff: Can you please give me an answer on this ? Cupertino >> >>> *powerpc - its 32bit version is eager to allocate globals in .sdata >>> sections. >>> Normally, one can expect for the variable to be allocated in .srodata, >>> however, in case of powerpc-*-* or powerpc64-*-* (with -m32) >>> 'targetm.have_srodata_section == false' and the code in >>> categorize_decl_for_section(varasm.cc), forces it to allocate in .sdata. >>> /* If the target uses small data sections, select it. */ >>> else if (targetm.in_small_data_p (decl)) >>> { >>> if (ret == SECCAT_BSS) >>> ret = SECCAT_SBSS; >>> else if targetm.have_srodata_section && ret == SECCAT_RODATA) >>> ret = SECCAT_SRODATA; >>> else >>> ret = SECCAT_SDATA; >>> } >> I'd just skip the test for 32bit ppc. There should be suitable effective-target >> tests you can use. >> >> jeff