From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 16BBA386F809; Fri, 3 Jul 2020 15:41:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 16BBA386F809 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Thomas_Schwinge@mentor.com IronPort-SDR: mpK8eK2Xiog1yECmd+qEDNhMPgHcN38nm/BGDUnb+n1fgzUGWDGLIjaaB54WdHMhoFARo7k92k L5SsDSt60fZwdiOQcv6b8Hxk4IFuRoO0p3gZTNWLoikYlyeTWQb+gHFreAbnf0gg9QoNGImlBb 7tzz3m+AvFTJ9IVWAl6PZmbElL5/Fa266Bj+d2i7RrXLUibNtpFzon+Js6HQWEE5qEc4LXlerr MSlUB3PINzsI4DZINxJcc9qDYMmYjuz00Vep6A+ttMYhjim8agaQYdQwnGmfd8ZZzp3e60CMHW rno= X-IronPort-AV: E=Sophos;i="5.75,308,1589270400"; d="scan'208,223";a="52718245" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 03 Jul 2020 07:41:21 -0800 IronPort-SDR: axlohhFrWOihMzHnb9hr19+KOSx4t4yporNOvD84aK+Wat6N0KmFKKa8CA61otHscglPkN4374 V/uX5XUlV1kA2nte9tfHAG3QVppV7WJbkTljbx3/tLkd1+20s0eNqnTz6raFq5AfwiqADo0XGJ uYdtbHqBGIxUD36wLNUCK4r5LsxIqJHhs8XpNFLMfAsjRG7h5cDFlSz0buj8Ts/ZoETwJC3uv4 mWOF7lM1YAF84SHZt5sKLtcQu+AGLo5WoxGdpi/+E8F+0Pa4+PZMzmm/wnXx9YhXJOY9edwsji sx8= From: Thomas Schwinge To: Julian Brown CC: , Jakub Jelinek , Tobias Burnus , , Subject: Re: [PATCH 3/9] [OpenACC] Adjust dynamic reference count semantics In-Reply-To: <87k0zozmp9.fsf@euler.schwinge.homeip.net> References: <5e9472b80dc475214a4a082ef54ee919d7f9dcff.1592343756.git.julian@codesourcery.com> <87k0zozmp9.fsf@euler.schwinge.homeip.net> User-Agent: Notmuch/0.29.1+93~g67ed7df (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Fri, 3 Jul 2020 17:41:12 +0200 Message-ID: <87tuyoy5bb.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_SHORT, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jul 2020 15:41:38 -0000 --=-=-= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Julian! On 2020-06-30T15:51:14+0200, I wrote: > On 2020-06-16T15:38:33-0700, Julian Brown wrote= : >> This is a new version of the patch last sent here: >> >> https://gcc.gnu.org/pipermail/gcc-patches/2020-May/546332.html >> >> Minus the bits that Thomas has committed already (thanks!), and with >> adjustments to allow for GOMP_MAP_ATTACH being grouped together with a >> preceding clause. >> >> OK? > > Please also update the "virtual refcount" comment in > 'libgomp.oacc-c-c++-common/structured-dynamic-lifetimes-4.c'. > > Your patch now makes the 'libgomp.oacc-fortran/mdc-refcount-1-1-1.f90', > 'libgomp.oacc-fortran/mdc-refcount-1-2-1.f90', > 'libgomp.oacc-fortran/mdc-refcount-1-2-2.f90', > 'libgomp.oacc-fortran/mdc-refcount-1-3-1.f90' test cases PASS (did you > not see that?) Ah, you said "Tested (as a series)", so that's probably why I saw this intermediate step but you didn't. > so we have to remove all XFAILing, 'print'/'dg-output' > etc. from these, and it changes the error reporting in > 'libgomp.oacc-fortran/mdc-refcount-1-4-1.f90', so we have to adjust that. > See attached patch "into Adjust dynamic reference count semantics". Given my recent "[OpenACC] Revert always-copyfrom behavior for 'GOMP_MAP_FORCE_FROM' in 'libgomp/oacc-mem.c:goacc_exit_data_internal'", , please also include the attached "into 'Adjust dynamic reference count semantics': un-XFAIL 'libgomp.oacc-c-c++-common/pr92843-1.c'". > Your patch regresses the attached > 'libgomp.oacc-c-c++-common/struct-3-1-1.c' That was confusing: that's a new test case, not yet in tree. > which used to act like > detailed in the file, but now does: > > CheCKpOInT1 > CheCKpOInT2 > a.out: source-gcc/libgomp/testsuite/libgomp.oacc-c-c++-common/struct-= 3-1-1.c:28: main: Assertion `acc_is_present (&s.b, sizeof s.b)' failed. > Aborted (core dumped) > > That means, after '#pragma acc enter data create(s.a)' we're no longer > refusing '#pragma acc enter data create(s.b)', but then the > 'acc_is_present' for 's.b' fails. Is that a true regression introduced > by your patch, or a separate issue (which before just worked by chance)? > In the latter case, please file a PR. Gr=C3=BC=C3=9Fe Thomas ----------------- Mentor Graphics (Deutschland) GmbH, Arnulfstra=C3=9Fe 201, 80634 M=C3=BCnch= en / Germany Registergericht M=C3=BCnchen HRB 106955, Gesch=C3=A4ftsf=C3=BChrer: Thomas = Heurung, Alexander Walter --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename="0001-into-Adjust-dynamic-reference-count-semantics-un-XFA.patch" >From 705898afc94c94545a2dd7ed9f451615c067385f Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Fri, 3 Jul 2020 16:58:34 +0200 Subject: [PATCH] into 'Adjust dynamic reference count semantics': un-XFAIL 'libgomp.oacc-c-c++-common/pr92843-1.c' --- libgomp/testsuite/libgomp.oacc-c-c++-common/pr92843-1.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/libgomp/testsuite/libgomp.oacc-c-c++-common/pr92843-1.c b/libgomp/testsuite/libgomp.oacc-c-c++-common/pr92843-1.c index 78fe1402ad46..db5b35b08d9f 100644 --- a/libgomp/testsuite/libgomp.oacc-c-c++-common/pr92843-1.c +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/pr92843-1.c @@ -4,7 +4,6 @@ /* { dg-skip-if "" { *-*-* } { "*" } { "-DACC_MEM_SHARED=0" } } */ #include -#include #include #include @@ -135,15 +134,7 @@ test_acc_data () assert (acc_is_present (h, sizeof h)); assign_array (h, N, c1); - fprintf (stderr, "CheCKpOInT1\n"); - // { dg-output ".*CheCKpOInT1(\n|\r\n|\r)" } acc_copyout_finalize (h, sizeof h); - //TODO goacc_exit_datum: Assertion `is_tgt_unmapped || num_mappings > 1' failed. - //TODO { dg-output ".*\[Aa\]ssert.*is_tgt_unmapped" { target { ! openacc_host_selected } } } ! Scan for what we expect in the "XFAILed" case (without actually XFAILing). - //TODO { dg-shouldfail "XFAILed" { ! openacc_host_selected } } ! ... instead of 'dg-xfail-run-if' so that 'dg-output' is evaluated at all. - //TODO { dg-final { if { [dg-process-target { xfail { ! openacc_host_selected } }] == "F" } { xfail "[testname-for-summary] really is XFAILed" } } } ! ... so that we still get an XFAIL visible in the log. - fprintf (stderr, "CheCKpOInT2\n"); - // { dg-output ".CheCKpOInT2(\n|\r\n|\r)" { target { openacc_host_selected } } } assert (acc_is_present (h, sizeof h)); verify_array (h, N, c1); -- 2.27.0 --=-=-=--