public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andrea Corallo <andrea.corallo@arm.com>
To: Roman Zhuykov <zhroma@ispras.ru>
Cc: gcc-patches@gcc.gnu.org,
	 "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>,
	 nd@arm.com
Subject: Re: [PATCH] [arm] Implement Armv8.1-M low overhead loops
Date: Mon, 24 Feb 2020 15:48:00 -0000	[thread overview]
Message-ID: <87tv3g6l6f.fsf@arm.com> (raw)
In-Reply-To: <845952fe-bfcc-7918-df95-918b983bd0e4@ispras.ru> (Roman Zhuykov's	message of "Fri, 21 Feb 2020 18:40:58 +0300")

Hi Roman,

Roman Zhuykov <zhroma@ispras.ru> writes:

>> SMS is disabled in tests not to break them when SMS does loop versioning.
>
> And I'm not really sure about this.  First of all, there are a lot of
> scan-assembler-times tests which fail when modulo-scheduler is enabled,
> probably the same happens when some unrolling parameters are not
> default.  It seems that any non-default optimization which creates more
> instruction copies can break scan-assembler-times check.  IMHO, it is
> not necessary to workaround this in few particular tests.  Second, I'm
> not sure how dg-skip-if directive works.  When one enables SMS setting
> "Init(1)" directly into common.opt this won't be catched, would it?

Agree on everything.  Also enabling SMS from common.opt apparently makes
dg-skip-if not effective.

Thanks for commenting I'm updating the patch.

  Andrea

  reply	other threads:[~2020-02-24 15:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11 10:15 Andrea Corallo
2020-02-11 11:01 ` Richard Earnshaw (lists)
2020-02-11 13:40   ` Andrea Corallo
2020-02-12  9:23     ` Roman Zhuykov
2020-02-13 17:54       ` Andrea Corallo
2020-02-19 13:01       ` Andrea Corallo
2020-02-21 15:31         ` Kyrill Tkachov
2020-02-21 15:49           ` Roman Zhuykov
2020-02-21 15:53             ` Kyrill Tkachov
2020-02-21 15:41         ` Roman Zhuykov
2020-02-24 15:48           ` Andrea Corallo [this message]
2020-02-25 14:57             ` Andrea Corallo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tv3g6l6f.fsf@arm.com \
    --to=andrea.corallo@arm.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=nd@arm.com \
    --cc=zhroma@ispras.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).