Hi Jakub! On Mon, 29 Apr 2019 12:59:03 +0200, Jakub Jelinek wrote: > On Mon, Apr 29, 2019 at 12:18:15PM +0200, Thomas Schwinge wrote: > > I know it's very late in the GCC 9 release process, but I'm still > > catching up with OpenACC patch review, and just at the end of last week > > I'd noticed that this commit (trunk r261813): > > I'd like to see full patch before considering. The bar at this point for > anything to gcc-9-branch is very high. Sure, understood. I've spent some time thinking about this ABI change, back and forth, and even produced the obvious patch (to use 'GOACC_FLAG_IF_PRESENT', 'GOACC_FLAG_FINALIZE'; attached for posterity), but in the end I'd like to withdraw, and keep the current ABI. (..., and I'll instead follow up, at a later point in time, with some documentation updates and code restructuring, to make this better understandable/maintainable.) Grüße Thomas