From: Richard Sandiford <rdsandiford@googlemail.com>
To: gcc-patches@gcc.gnu.org
Cc: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>,
Andreas Krebbel <krebbel@linux.vnet.ibm.com>
Subject: Re: [RFC][PATCH] Fix broken handling of LABEL_REF in genrecog + genpreds.
Date: Fri, 18 Dec 2015 09:56:00 -0000 [thread overview]
Message-ID: <87twngt711.fsf@googlemail.com> (raw)
In-Reply-To: <20151216124305.GA12471@linux.vnet.ibm.com> (Dominik Vogt's message of "Wed, 16 Dec 2015 13:43:05 +0100")
Dominik Vogt <vogt@linux.vnet.ibm.com> writes:
> The attached patch fixes the handling of LABEL_REF in genrecog and
> genpreds.
>
> The current code assumes that X can have only a mode than PRED (X,
> MODE) if X is CONST_INT, CONST_DOUBLE or CONST_WIDE_INT, but
> actually that can be also the case for a LABEL_REF with VOIDmode.
> Due to this it is necessary to add "const_int" (or similar) to
> match_code of some predicates handling label_ref but not
> const_int.
OK, thanks.
As mentioned in the other thread, I think LABEL_REFs shouldn't have
VOIDmode, so long-term we should be fixing the targets. I agree this
is the correct workaround until that happens though.
Richard
next prev parent reply other threads:[~2015-12-18 9:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 12:43 Dominik Vogt
2015-12-18 9:56 ` Richard Sandiford [this message]
2015-12-22 11:13 ` Dominik Vogt
2015-12-22 22:24 ` Richard Sandiford
2015-12-23 11:07 ` Andreas Krebbel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twngt711.fsf@googlemail.com \
--to=rdsandiford@googlemail.com \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=krebbel@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).