From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63256 invoked by alias); 18 Dec 2015 09:56:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 63238 invoked by uid 89); 18 Dec 2015 09:56:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=long-term, longterm, const_wide_int, pred X-HELO: mail-wm0-f52.google.com Received: from mail-wm0-f52.google.com (HELO mail-wm0-f52.google.com) (74.125.82.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 18 Dec 2015 09:55:59 +0000 Received: by mail-wm0-f52.google.com with SMTP id l126so56796445wml.0 for ; Fri, 18 Dec 2015 01:55:58 -0800 (PST) X-Received: by 10.28.12.69 with SMTP id 66mr2070198wmm.73.1450432556416; Fri, 18 Dec 2015 01:55:56 -0800 (PST) Received: from localhost ([95.145.138.245]) by smtp.googlemail.com with ESMTPSA id e136sm5950357wma.23.2015.12.18.01.55.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Dec 2015 01:55:55 -0800 (PST) From: Richard Sandiford To: gcc-patches@gcc.gnu.org Mail-Followup-To: gcc-patches@gcc.gnu.org,Ulrich Weigand , Andreas Krebbel , rdsandiford@googlemail.com Cc: Ulrich Weigand , Andreas Krebbel Subject: Re: [RFC][PATCH] Fix broken handling of LABEL_REF in genrecog + genpreds. References: <20151216124305.GA12471@linux.vnet.ibm.com> Date: Fri, 18 Dec 2015 09:56:00 -0000 In-Reply-To: <20151216124305.GA12471@linux.vnet.ibm.com> (Dominik Vogt's message of "Wed, 16 Dec 2015 13:43:05 +0100") Message-ID: <87twngt711.fsf@googlemail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2015-12/txt/msg01863.txt.bz2 Dominik Vogt writes: > The attached patch fixes the handling of LABEL_REF in genrecog and > genpreds. > > The current code assumes that X can have only a mode than PRED (X, > MODE) if X is CONST_INT, CONST_DOUBLE or CONST_WIDE_INT, but > actually that can be also the case for a LABEL_REF with VOIDmode. > Due to this it is necessary to add "const_int" (or similar) to > match_code of some predicates handling label_ref but not > const_int. OK, thanks. As mentioned in the other thread, I think LABEL_REFs shouldn't have VOIDmode, so long-term we should be fixing the targets. I agree this is the correct workaround until that happens though. Richard