public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [Committed] Fix lto.c compiling
@ 2014-06-29  4:46 Andrew Pinski
  2014-06-29 16:25 ` Andi Kleen
  0 siblings, 1 reply; 2+ messages in thread
From: Andrew Pinski @ 2014-06-29  4:46 UTC (permalink / raw)
  To: GCC Patches; +Cc: Jan Hubicka

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

I committed this as obvious.  The changelog says it all.

Thanks,
Andrew

2014-06-28  Andrew Pinski  <apinski@cavium.com>

* lto.c (lto_read_decls): Fix comment in comment.

[-- Attachment #2: fixmainline.diff.txt --]
[-- Type: text/plain, Size: 816 bytes --]

Index: lto.c
===================================================================
--- lto.c	(revision 212118)
+++ lto.c	(working copy)
@@ -1970,7 +1970,7 @@ lto_read_decls (struct lto_file_decl_dat
 			    len, scc_entry_len, scc_hash))
 	    continue;
 
-	  /* /* Do remaining fixup tasks for prevailing nodes.  */
+	  /* Do remaining fixup tasks for prevailing nodes.  */
 	  bool seen_type = false;
 	  for (unsigned i = 0; i < len; ++i)
 	    {
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 212118)
+++ ChangeLog	(working copy)
@@ -1,3 +1,7 @@
+2014-06-28  Andrew Pinski  <apinski@cavium.com>
+
+	* lto.c (lto_read_decls): Fix comment in comment.
+
 2014-06-28  Jan Hubicka  <hubicka@ucw.cz>
 
 	* lto.c (lto_copy_fields_not_streamed): New function.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Committed] Fix lto.c compiling
  2014-06-29  4:46 [Committed] Fix lto.c compiling Andrew Pinski
@ 2014-06-29 16:25 ` Andi Kleen
  0 siblings, 0 replies; 2+ messages in thread
From: Andi Kleen @ 2014-06-29 16:25 UTC (permalink / raw)
  To: Andrew Pinski, 5A5A5A5A; +Cc: GCC Patches, Jan Hubicka

Andrew Pinski <pinskia@gmail.com> writes:

> I committed this as obvious.  The changelog says it all.

I think the problem is that LTO bootstraps frequently error out with
-Werror. That incentives LTO users to bootstrap with --disable-werror.

[e.g. currently the graphite libraries don't build this way]

The main problem seems to be -Wmaybe-undefined + -Werror + LTO. 
Perhaps there should be a way to make this one warning not error.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-06-29 16:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-29  4:46 [Committed] Fix lto.c compiling Andrew Pinski
2014-06-29 16:25 ` Andi Kleen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).