[patch] Remove shadow variable

[patch] Remove shadow variable

[James Norris]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

Hi!

Removed three occurrences of a shadow variable.

Bootstrapped and tested on x86-64-unknown-linux-gnu.

2014-05-09  James Norris  <jnorris@codesourcery.com>

    * omp-low.c (expand_parallel_call): Remove shadow variable.
    (expand_omp_taskreg): Likewise.



[-- Attachment #2: omp-low.diff --]
[-- Type: text/x-patch, Size: 948 bytes --]

diff --git a/gcc/omp-low.c b/gcc/omp-low.c
index 453f580..594967d 100644
--- a/gcc/omp-low.c
+++ b/gcc/omp-low.c
@@ -4227,8 +4227,6 @@ expand_parallel_call (struct omp_region *region, basic_block bb,
      (cond != 0) or (cond ? val : 1u).  */
   if (cond)
     {
-      gimple_stmt_iterator gsi;
-
       cond = gimple_boolify (cond);
 
       if (integer_zerop (val))
@@ -4672,7 +4670,6 @@ expand_omp_taskreg (struct omp_region *region)
 	 the region, in which case all we need to do is make the
 	 sub-graph unreachable and emit the parallel call.  */
       edge entry_succ_e, exit_succ_e;
-      gimple_stmt_iterator gsi;
 
       entry_succ_e = single_succ_edge (entry_bb);
 
@@ -4709,7 +4706,6 @@ expand_omp_taskreg (struct omp_region *region)
       if (gimple_omp_taskreg_data_arg (entry_stmt))
 	{
 	  basic_block entry_succ_bb = single_succ (entry_bb);
-	  gimple_stmt_iterator gsi;
 	  tree arg, narg;
 	  gimple parcopy_stmt = NULL;
 

Re: [patch] Remove shadow variable

[Jakub Jelinek]

On Fri, May 09, 2014 at 11:03:35AM -0500, James Norris wrote:
> Removed three occurrences of a shadow variable.
> 
> Bootstrapped and tested on x86-64-unknown-linux-gnu.
> 
> 2014-05-09  James Norris  <jnorris@codesourcery.com>
> 
>    * omp-low.c (expand_parallel_call): Remove shadow variable.
>    (expand_omp_taskreg): Likewise.

Ok.

	Jakub

Re: [patch] Remove shadow variable

[Thomas Schwinge]

[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]

Hi!

On Fri, 9 May 2014 18:07:52 +0200, Jakub Jelinek <jakub@redhat.com> wrote:
> On Fri, May 09, 2014 at 11:03:35AM -0500, James Norris wrote:
> > Removed three occurrences of a shadow variable.
> > 
> > Bootstrapped and tested on x86-64-unknown-linux-gnu.
> > 
> > 2014-05-09  James Norris  <jnorris@codesourcery.com>

Jim, note that once you get to commit this, the date will need to be
updated to that day's current date.

> >    * omp-low.c (expand_parallel_call): Remove shadow variable.
> >    (expand_omp_taskreg): Likewise.

Indent by a tab instead of four spaces.  GNU ChangeLog policy;
<http://www.gnu.org/prep/standards/html_node/Change-Logs.html>.

> Ok.

Jim does not yet have commit access/a sourceware account.  He's covered
by the general Mentor Graphics/CodeSourcery copyright assignment.  Jim,
please request an account per <http://gcc.gnu.org/svnwrite.html>, and on
<https://sourceware.org/cgi-bin/pdw/ps_form.cgi> put in one of us as
approver.


Grüße,
 Thomas

[-- Attachment #2: Type: application/pgp-signature, Size: 472 bytes --]

Re: [patch] Remove shadow variable

[Thomas Schwinge]

[-- Attachment #1: Type: text/plain, Size: 587 bytes --]

Hi Jim!

On Fri, 9 May 2014 11:03:35 -0500, James Norris <jnorris@codesourcery.com> wrote:
> Removed three occurrences of a shadow variable.
> 
> Bootstrapped and tested on x86-64-unknown-linux-gnu.
> 
> 2014-05-09  James Norris  <jnorris@codesourcery.com>
> 
>     * omp-low.c (expand_parallel_call): Remove shadow variable.
>     (expand_omp_taskreg): Likewise.

(Jakub committed this in r210423.)

The shadow gsi in expand_omp_target can also go, I think?  Please commit
that if you agree (but first commit your update to the MAINTAINERS file).


Grüße,
 Thomas

[-- Attachment #2: Type: application/pgp-signature, Size: 472 bytes --]