From: Dodji Seketeli <dodji@redhat.com>
To: Jason Merrill <jason@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: PING Re: [PATCH] PR c++/53540 - using fails to be equivalent to typedef
Date: Mon, 08 Oct 2012 14:24:00 -0000 [thread overview]
Message-ID: <87txu5hwj0.fsf@redhat.com> (raw)
In-Reply-To: <m38vdeiivg.fsf@redhat.com> (Dodji Seketeli's message of "Fri, 17 Aug 2012 00:15:15 +0200")
Friendly pinging this patch.
Dodji Seketeli <dodji@redhat.com> writes:
> Hello,
>
> In the example of this problem report, during the substituting of int
> into 'function', tsubst_aggr_type fails for the alias ctxt1. This is
> because TYPE_TEMPLATE_INFO looks for the TEMPLATE_INFO of the ctxt1
> alias at the wrong place and was wrongly finding it to be NULL.
> Namely, it was looking for it in the DECL_TEMPLATE_INFO of the
> declaration of the type -- as if ctxt1 was an alias template
> specialization -- rather than looking of it in its
> CLASSTYPE_TEMPLATE_INFO.
>
> Fixed thus. The second hunk of the patch is just to prevent the
> compiler from crashing when primary_template_instantiation_p is passed
> an alias of a class template instantiation.
>
> Bootstrapped and tested on x86_64-unknown-linux-gnu against trunk.
>
> gcc/cp
>
> * cp-tree.h (TYPE_TEMPLATE_INFO): For an alias that is not an
> instance of alias template, don't look for its TEMPLATE_INFO in
> its declaration.
> * pt.c (primary_template_instantiation_p): Don't crash on an alias
> that is not an instance of a template.
>
> gcc/testsuite/
>
> * g++.dg/cpp0x/alias-decl-21.C: New test.
> ---
> gcc/cp/cp-tree.h | 4 ++--
> gcc/cp/pt.c | 1 +
> gcc/testsuite/g++.dg/cpp0x/alias-decl-21.C | 24 ++++++++++++++++++++++++
> 3 files changed, 27 insertions(+), 2 deletions(-)
> create mode 100644 gcc/testsuite/g++.dg/cpp0x/alias-decl-21.C
>
> diff --git a/gcc/cp/cp-tree.h b/gcc/cp/cp-tree.h
> index 44f3ac1..64a8830 100644
> --- a/gcc/cp/cp-tree.h
> +++ b/gcc/cp/cp-tree.h
> @@ -2634,8 +2634,8 @@ extern void decl_shadowed_for_var_insert (tree, tree);
> template info for the alias template, not the one (if any) for the
> template of the underlying type. */
> #define TYPE_TEMPLATE_INFO(NODE) \
> - (TYPE_ALIAS_P (NODE) \
> - ? ((TYPE_NAME (NODE) && DECL_LANG_SPECIFIC (TYPE_NAME (NODE))) \
> + ((TYPE_ALIAS_P (NODE) && DECL_LANG_SPECIFIC (TYPE_NAME (NODE))) \
> + ? (DECL_LANG_SPECIFIC (TYPE_NAME (NODE)) \
> ? DECL_TEMPLATE_INFO (TYPE_NAME (NODE)) \
> : NULL_TREE) \
> : ((TREE_CODE (NODE) == ENUMERAL_TYPE) \
> diff --git a/gcc/cp/pt.c b/gcc/cp/pt.c
> index ad81bab..3163bd4 100644
> --- a/gcc/cp/pt.c
> +++ b/gcc/cp/pt.c
> @@ -2854,6 +2854,7 @@ primary_template_instantiation_p (const_tree t)
> else if (TYPE_P (t)
> && TYPE_TEMPLATE_INFO (t)
> && PRIMARY_TEMPLATE_P (TYPE_TI_TEMPLATE (t))
> + && DECL_LANG_SPECIFIC (TYPE_NAME (t))
> && DECL_TEMPLATE_INSTANTIATION (TYPE_NAME (t)))
> return true;
> return false;
> diff --git a/gcc/testsuite/g++.dg/cpp0x/alias-decl-21.C b/gcc/testsuite/g++.dg/cpp0x/alias-decl-21.C
> new file mode 100644
> index 0000000..b68fa93
> --- /dev/null
> +++ b/gcc/testsuite/g++.dg/cpp0x/alias-decl-21.C
> @@ -0,0 +1,24 @@
> +// Origin: PR c++/53540
> +// { dg-do compile { target c++11 } }
> +
> +template <typename T>
> +struct context
> +{
> + typedef int type;
> +};
> +
> +template <typename T>
> +void function()
> +{
> + using ctx1 = context<T>;
> + typename ctx1::type f1;
> +
> + typedef context<T> ctx2;
> + typename ctx2::type f2;
> +}
> +
> +int main()
> +{
> + function<int>();
> +}
> +
--
Dodji
next prev parent reply other threads:[~2012-10-08 14:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-16 22:15 Dodji Seketeli
2012-10-08 14:24 ` Dodji Seketeli [this message]
2012-10-08 18:42 ` Jason Merrill
2012-10-09 15:26 ` Dodji Seketeli
2012-10-09 15:47 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txu5hwj0.fsf@redhat.com \
--to=dodji@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).