public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [MIPS, committed] Fix handling of small-data asm operands
@ 2012-01-25 19:04 Richard Sandiford
  2012-01-25 20:14 ` Richard Sandiford
  0 siblings, 1 reply; 2+ messages in thread
From: Richard Sandiford @ 2012-01-25 19:04 UTC (permalink / raw)
  To: gcc-patches

The testcase for PR 51933 was failing on mipsisa64-elf because md_reorg
changed a symbolic small-data asm operand into a LO_SUM.

Tested on mipsisa64-elf and applied.

Richard


gcc/
	* config/mips/mips.c: Don't process ASM_OPERANDS.

Index: gcc/config/mips/mips.c
===================================================================
--- gcc/config/mips/mips.c	2012-01-25 18:53:22.000000000 +0000
+++ gcc/config/mips/mips.c	2012-01-25 18:53:59.000000000 +0000
@@ -3101,7 +3101,10 @@ mips_small_data_pattern_1 (rtx *loc, voi
 {
   enum mips_symbol_context context;
 
-  if (GET_CODE (*loc) == LO_SUM)
+  /* Ignore things like "g" constraints in asms.  We make no particular
+     guarantee about which symbolic constants are acceptable as asm operands
+     versus which must be forced into a GPR.  */
+  if (GET_CODE (*loc) == LO_SUM || GET_CODE (*loc) == ASM_OPERANDS)
     return -1;
 
   if (MEM_P (*loc))

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [MIPS, committed] Fix handling of small-data asm operands
  2012-01-25 19:04 [MIPS, committed] Fix handling of small-data asm operands Richard Sandiford
@ 2012-01-25 20:14 ` Richard Sandiford
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Sandiford @ 2012-01-25 20:14 UTC (permalink / raw)
  To: gcc-patches

Richard Sandiford <rdsandiford@googlemail.com> writes:
> The testcase for PR 51933 was failing on mipsisa64-elf because md_reorg
> changed a symbolic small-data asm operand into a LO_SUM.
>
> Tested on mipsisa64-elf and applied.
>
> Richard
>
>
> gcc/
> 	* config/mips/mips.c: Don't process ASM_OPERANDS.

...now with added function name.

Richard

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-01-25 20:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-25 19:04 [MIPS, committed] Fix handling of small-data asm operands Richard Sandiford
2012-01-25 20:14 ` Richard Sandiford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).