From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23858 invoked by alias); 25 Aug 2011 17:57:33 -0000 Received: (qmail 23849 invoked by uid 22791); 25 Aug 2011 17:57:33 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-ww0-f51.google.com (HELO mail-ww0-f51.google.com) (74.125.82.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 25 Aug 2011 17:57:17 +0000 Received: by wwi18 with SMTP id 18so2508692wwi.8 for ; Thu, 25 Aug 2011 10:57:16 -0700 (PDT) Received: by 10.227.200.66 with SMTP id ev2mr69966wbb.0.1314295036218; Thu, 25 Aug 2011 10:57:16 -0700 (PDT) Received: from localhost (rsandifo.gotadsl.co.uk [82.133.89.107]) by mx.google.com with ESMTPS id fg5sm644869wbb.23.2011.08.25.10.57.14 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 25 Aug 2011 10:57:15 -0700 (PDT) From: Richard Sandiford To: Julian Brown Mail-Followup-To: Julian Brown ,gcc-patches@gcc.gnu.org, rdsandiford@googlemail.com Cc: gcc-patches@gcc.gnu.org Subject: RFA: PR 50061/50113: BLOCK_REG_PADDING for libcalls References: <20110526175634.4bcab9b5@rex.config> <87sjpdjepe.fsf@firetop.home> <20110824170455.195b5ead@rex.config> <20110824225150.648713fc@rex.config> Date: Thu, 25 Aug 2011 18:46:00 -0000 In-Reply-To: <20110824225150.648713fc@rex.config> (Julian Brown's message of "Wed, 24 Aug 2011 22:51:50 +0100") Message-ID: <87ty954bnx.fsf_-_@firetop.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-08/txt/msg02094.txt.bz2 Julian Brown writes: > On Wed, 24 Aug 2011 17:04:55 +0100 > Julian Brown wrote: > >> On Sun, 07 Aug 2011 18:47:57 +0100 >> Richard Sandiford wrote: >> >> > This patch caused several regressions on big-endian 64-bit MIPS >> > targets, which now try to shift single-precision floating-point >> > arguments to the top of an FPR. [...] >> >> Sorry for the breakage! >> >> > The patch below borrows the padding code from the main call >> > routines. It fixes the MIPS problems for me (tested on >> > mips64-linux-gnu), but I'm not set up for big-endian ARM testing. >> > From what I can tell, other targets' BLOCK_REG_PADDING definitions >> > already handle null types. >> >> I tested your patch very lightly on ARM, by running arm.exp & >> fixed-point.exp in both big & little-endian mode, and it looks fine. >> I'll set off a more-complete test run also, in case that's helpful... > > The patch looks fine for big/little endian, gcc/g++/libstdc++, cross to > ARM EABI, btw. Great! Thanks for testing. Maintainers: is the patch: http://gcc.gnu.org/ml/gcc-patches/2011-08/msg00735.html OK to install? Tested by Julian on ARM BE and LE, and by me on mips64-linux-gnu. Thanks, Richard