From: Zack Weinberg <zack@codesourcery.com>
To: Andrew Pinski <pinskia@physics.uc.edu>
Cc: gcc-patches@gcc.gnu.org, "Joseph S. Myers" <jsm@polyomino.org.uk>
Subject: Re: New C parser [patch]
Date: Tue, 26 Oct 2004 01:03:00 -0000 [thread overview]
Message-ID: <87u0sico98.fsf@codesourcery.com> (raw)
In-Reply-To: <E94BCB9A-26E5-11D9-B7C0-000A95D692F4@physics.uc.edu> (Andrew Pinski's message of "Mon, 25 Oct 2004 20:28:08 -0400")
Andrew Pinski <pinskia@physics.uc.edu> writes:
> On Oct 25, 2004, at 8:03 PM, Zack Weinberg wrote:
>
>>> + c_parser_error (parser,
>>> + "expected ':', ',', ';' or '__attribute__'");
>>> + break;
>>
>> These want %<%>ifying. There are several other cases - I'm not going
>> to call them all out explicitly.
>
> But I will say that we have C++ diagnostic regressions because of
> "%<%>ifying". The reason why we have this problem is because
> c_parser_error takes a string but only does %s on it rather than passing
> it on to the diagnostic mechanism.
c_parse(r)_error have serious i18n issues already: I don't think this
one more makes much difference. The way forward is to remove
c_parse_error entirely...
zw
next prev parent reply other threads:[~2004-10-26 0:32 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-23 1:25 Joseph S. Myers
2004-10-23 2:39 ` Steven Bosscher
2004-10-23 4:15 ` Joseph S. Myers
2004-10-23 5:44 ` Scott Robert Ladd
2004-10-24 22:49 ` Joseph S. Myers
2004-10-26 0:32 ` Zack Weinberg
2004-10-26 1:03 ` Andrew Pinski
2004-10-26 1:03 ` Zack Weinberg [this message]
2004-10-26 1:11 ` Joseph S. Myers
2004-10-26 8:23 ` Zack Weinberg
2004-10-26 1:30 ` Gabriel Dos Reis
2004-10-26 1:06 ` Joseph S. Myers
2004-10-26 2:47 ` Joseph S. Myers
2004-10-26 3:48 ` Mark Mitchell
2004-10-26 12:21 ` Kyuupi
2004-10-26 12:32 ` Joseph S. Myers
2004-10-26 11:42 ` Joseph S. Myers
2004-10-27 19:04 ` Richard Henderson
2004-10-27 19:11 ` Richard Guenther
2004-10-27 19:41 ` Zack Weinberg
2004-10-27 19:31 ` Zack Weinberg
2004-10-27 21:31 ` Richard Henderson
2004-10-28 7:38 ` Alan Modra
2004-10-27 20:25 ` Joseph S. Myers
2004-10-25 22:33 ` Ziemowit Laski
2004-10-25 22:51 ` Joseph S. Myers
2004-10-25 23:45 ` Ziemowit Laski
2004-10-25 23:53 ` Scott Robert Ladd
2004-10-26 0:03 ` Unified front end for C and C++ (was Re: New C parser [patch]) Matt Austern
2004-10-26 1:26 ` Scott Robert Ladd
2004-10-26 1:43 ` Gabriel Dos Reis
2004-10-26 2:01 ` Scott Robert Ladd
2004-10-26 15:38 ` Gabriel Dos Reis
2004-10-26 0:28 ` New C parser [patch] Ziemowit Laski
2004-10-26 1:20 ` Scott Robert Ladd
2004-10-26 6:08 ` Unified C and C++ front end (was Re: New C parser [patch]) Matt Austern
2004-10-26 11:14 ` Joseph S. Myers
2004-10-26 16:04 ` Gabriel Dos Reis
2004-10-26 16:51 ` Joseph S. Myers
2004-10-26 0:37 ` New C parser [patch] Joseph S. Myers
2004-10-26 0:03 ` Stan Shebs
2004-10-26 1:46 ` Gabriel Dos Reis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87u0sico98.fsf@codesourcery.com \
--to=zack@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jsm@polyomino.org.uk \
--cc=pinskia@physics.uc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).