From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=uvpB=KX=gentoo.org=sam@sourceware.org>
Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183])
	by sourceware.org (Postfix) with ESMTP id 465ED3858D20;
	Sun, 17 Mar 2024 06:04:43 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 465ED3858D20
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 465ED3858D20
Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710655488; cv=none;
	b=AN+XiPUTGrKU0wih4Mt8zUOHHpawUncUQxbcOqG5eGlEsPt6B3I18u9eDuvwwz5hXcFzZvdtPU/y8z9T28P6oAm0lDjqhz/gS6Oy3SCwODaNQYPSP9JmsAbLqoLFH+VZImKSmew3ryf6MLN2n9u2qjYImXK/1jqvoCsV/w+MIIA=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1710655488; c=relaxed/simple;
	bh=AhsGtXrkJO0t8WJoKaI+/VHBIYGEDFTh8TRLRSHJOPY=;
	h=From:To:Subject:Date:Message-ID:MIME-Version; b=ZPvlzjwlOostvm08r6aR9ovkotpYzSsG8K657MlnXbpPg9hfxtQ4GM/Xdwo/HsJzEepeJm5udeenAREj0l3Q19A+AgT1r5vqd+FJl2zl4YXcatDZaJqRri5lFb+NRkOW1+di6SRFj52RjHfLayq8vAy4bEeAXg6fAeQAX518yTE=
ARC-Authentication-Results: i=1; server2.sourceware.org
From: Sam James <sam@gentoo.org>
To: YunQiang Su <syq@gcc.gnu.org>
Cc: gcc-patches@gcc.gnu.org,  pinskia@gcc.gnu.org,  i@maskray.me,
  rguenther@suse.de
Subject: Re: [PATCH] Predefine __STRICT_ALIGN__ if STRICT_ALIGNMENT
In-Reply-To: <20240317054631.848645-1-syq@gcc.gnu.org> (YunQiang Su's message
	of "Sun, 17 Mar 2024 13:46:31 +0800")
Organization: Gentoo
References: <20240317054631.848645-1-syq@gcc.gnu.org>
User-Agent: mu4e 1.12.0; emacs 30.0.50
Date: Sun, 17 Mar 2024 06:04:36 +0000
Message-ID: <87v85lxukr.fsf@gentoo.org>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

YunQiang Su <syq@gcc.gnu.org> writes:

> Arm32 predefines __ARM_FEATURE_UNALIGNED if -mno-unaligned-access,
> and RISC-V predefines __riscv_misaligned_avoid, while other ports
> that support -mstrict-align/-mno-unaligned-access don't have such
> macro, and these backend macros are only avaiable for c-family.
> Note: Arm64 always predefine __ARM_FEATURE_UNALIGNED: See #111555.

I would say tag the bug even if you're not fixing it, as it was related
enough for you to cite it.

>
> Let's add a generic one.
>
> __STRICT_ALIGN__ is used instead of __STRICT_ALIGNMENT__, due to that
> the later is used by some softwares, such as lzo2, syslinux etc.
>
> gcc
> 	* cppbuiltin.cc: Predefine __STRICT_ALIGNMENT__ if
> 	STRICT_ALIGNMENT.
> ---
>  gcc/cppbuiltin.cc | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/gcc/cppbuiltin.cc b/gcc/cppbuiltin.cc
> index c4bfc2917dc..d32efdf9a07 100644
> --- a/gcc/cppbuiltin.cc
> +++ b/gcc/cppbuiltin.cc
> @@ -123,6 +123,9 @@ define_builtin_macros_for_compilation_flags (cpp_reader *pfile)
>  
>    cpp_define_formatted (pfile, "__FINITE_MATH_ONLY__=%d",
>  			flag_finite_math_only);
> +
> +  if (STRICT_ALIGNMENT)
> +    cpp_define (pfile, "__STRICT_ALIGNMENT__");
>  }