From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 8859A3858C00 for ; Tue, 31 Jan 2023 09:10:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8859A3858C00 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30V7wqjo020590; Tue, 31 Jan 2023 09:10:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=references : from : to : cc : subject : in-reply-to : date : message-id : content-type : mime-version; s=corp-2022-7-12; bh=EgTmr9//yG1gvSFuCbQrIFIBrxWm371DjUOF5Yarsgk=; b=XgDPIlup0N2vfVa8PC24ndtYErCnDKHKVnUP2cf2ShylY0JBWsheaq3M7XkiUw3SHYcx sijM6BprbPl8pp6K3fMZitlgAdfHOZaHgU9wNzX6bmLu7HiA8Ka4D4/K9mf2vjiyMuEx TmRLf7XxOyFbCFMJTErAc/cv5p9b1OFBq++7/8R+KurZHfsiD4WpiGxqxr+IP575wZP0 JmUKBZodAHKM18T6omJUPTNgKd4Njcjp9ei9m6eQj0lKmAdHD0BOhRowPyF2A6CBJHC7 8kyXPmopftZJMa9oEth7GItNei00Lz+5jEixar5sESUzwyDJcsfafb+iEFW2WqnBM3vw wg== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ncvn9vxua-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 31 Jan 2023 09:10:47 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 30V7jsrH020368; Tue, 31 Jan 2023 09:10:46 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2100.outbound.protection.outlook.com [104.47.58.100]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3nct5c5hrt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 31 Jan 2023 09:10:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F0d+adsdyODVTeV3WZStx1OAr0/+6F7x60sP3bQebBwdUZbJ9LJ0yoGISryl9XTr5eGAdkcnL5+PjfVhoN7XbQ586TbtOJ5g22WU3cf+Hye0agJAGNzzLOtXUBZRA5vwM+Rl7rDDKBaYD3aDNuzVuu9UoLoODAi3xldDh6cz0tCvJUptq/r2U1N+lurmE8m6bB8OvuYs2ecgnLX8p/SWPjxMKZJOs0rmoC92XAkk6DF291BJB5PO7uAe0hPlwFhVPWL5NxAATPOC8/L16MCAvvhPuSrRUARj09UbKo/uryKneL0a/rd2D8+L1L1EnOIKaiUqGk1lcXRXGzjqMuNZpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EgTmr9//yG1gvSFuCbQrIFIBrxWm371DjUOF5Yarsgk=; b=WxM3kHy4Mh30GNVp8VoON3DP/NyIuWRRq/R4dldtJrR7jF5T3kWaQaHKe7KIrfomlWKoNVBkvSGSOGH6LsGPd7XQ/us7fNaQjGraFhsHxbKd9x80OSpybbGENXNnRAYAqc+dlZVcfdB1J40Wi17yNnpXAbL0VVWKozc5ybYv9jmQHgcG1yNwcS67S4MqSR+s6fB8LHW1tNTP8qsbrZhoLMTxCQgp9GoENpB1EUFDFb+whNboIMh51qdlE8YlZjRfljClWC/L592luCeL/EbstjENdM2XDQr5lH+2b73yDzP2to6NSTUy1ayt49meB69vflKbmCkd6Bn20mmCA7rjzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EgTmr9//yG1gvSFuCbQrIFIBrxWm371DjUOF5Yarsgk=; b=cEI5Oe9HZ3EJlPjdXH4efpq5UpMnZ96ryMshBgV7i3aatM5g2EKscO9ebsC/XZZVDm9MgCHIQ6nvPJu+hZzmZ4zNGvPTQP2KuBIXbh+oRE615K2xtLuY5yjxLfVPMXCDDFwcJ6F9CzEYz5kpEVc7+nxK2DbJR41pztZKHS6bE0c= Received: from BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) by MN6PR10MB7468.namprd10.prod.outlook.com (2603:10b6:208:47b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.17; Tue, 31 Jan 2023 09:10:44 +0000 Received: from BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::2b7a:b98b:e12:b750]) by BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::2b7a:b98b:e12:b750%7]) with mapi id 15.20.6064.022; Tue, 31 Jan 2023 09:10:44 +0000 References: <20221202175225.2780-1-cupertino.miranda@oracle.com> <20221202175225.2780-3-cupertino.miranda@oracle.com> <795fde7f-5bde-d1a5-e790-b15774effd1c@gmail.com> <875yen5ib4.fsf@oracle.com> <87h6wg15np.fsf@oracle.com> User-agent: mu4e 1.4.15; emacs 28.1 From: Cupertino Miranda To: Cupertino Miranda Cc: Jeff Law , jose.marchesi@oracle.com, gcc-patches@gcc.gnu.org Subject: [PING] Re: [PATCH 2/2] Corrected pr25521.c target matching. In-reply-to: <87h6wg15np.fsf@oracle.com> Date: Tue, 31 Jan 2023 09:10:38 +0000 Message-ID: <87v8knax2p.fsf@oracle.com> Content-Type: text/plain X-ClientProxiedBy: LO4P123CA0679.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:351::12) To BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR1001MB2340:EE_|MN6PR10MB7468:EE_ X-MS-Office365-Filtering-Correlation-Id: e3598fa1-52b1-4630-bfb5-08db036b0835 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AFMrE/XahaZiHmd7i2E32kW1Zyw0F1C7QMA9vt4rSJrm6pyQ3B3m2v5J6YFhIj9Ywwdmhrvo9tnyeaJpmWkyhsN/27Y/ADYY6Jf8Gh41Y5k4c5ttzrTXUV/xVgpT5TeC5u3AaudQsC0M8NzV3Q8xtzldU0GdI9qHX9QWwwB9MVyvcUQH1lOsRBGHo5RLAlgQc7S4sI4bax+lbNAu21i+fUitq1KG5w6fyrwOcKbQDuTfUctNnArV15VGsTSXVVGtJo3Y56N9PtZX6+wa4H1eDJVwvEvUkrCeQUHUOrzvbDUmSD9uFANKPDK9WqkMnUb0cXjZv7IbW3hSp36qdo5GqnI25fb0Xi39auds9a3sQYuJ0tGlyM1TnHnGIrd6AezcqhzWm1kxFscQ9uwiSIs/uvBZm7R0lgMnjOFPkM7aMH/G0sJY87/5d3B2LEEFFwiUOdM/k0TZwpZjKLnB1RyZhmJMRMj8aoTlkiX+zxerx+IfwmZtmBEHfhry+04GRvv2girrFjYI8NXoclmWceVVQhHlN9wK55MwRtYB4IU6k5/Sn+RNbhLbVb2Y3cderK8dR03XvwtxidS0pz4ul8gZ5Ym2X2V4J0Ea6fObVnolsVWaLqZ1heEu291ynFUplzwYCP1P4yIaWIEleSRTkvfZ5w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1001MB2340.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(396003)(39860400002)(346002)(376002)(136003)(366004)(451199018)(8936002)(6862004)(6200100001)(41300700001)(5660300002)(4326008)(66946007)(66556008)(66476007)(8676002)(83380400001)(6666004)(53546011)(6506007)(37006003)(316002)(38100700002)(86362001)(36756003)(6486002)(44832011)(478600001)(6512007)(186003)(2906002)(2616005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WWJc9K7SX8H1phGj6jvUcFawtYDDU+gHYaoZ9LkmRDf9m6mBYjurnYpKCkw8?= =?us-ascii?Q?nw5RrzOmrv8RTKifzH/BKbv7b/YWBRndOdm8sHRxVdCAHswfxI42+LTv1hyS?= =?us-ascii?Q?7wU0Q1LLUQ2SGha/tFnEFAqiBQk6ornZFKceAL8+LIhrkDA9tIns7SfFAu9Y?= =?us-ascii?Q?wuFRlg55IpFZju4AQMIsptDeSXHIBp6NeZkB7B98udBCGujSZGNP9VaeSYM0?= =?us-ascii?Q?yCIBsxrUT35NFqIHvH86cUHa/+q1q2lL1IeW5ZK5I6UnI7MuvCfeXbr8D/tG?= =?us-ascii?Q?GuU6nB2c/yHcOxn5n5MnD2GfD0XJNdSlsF0u7vJXvYdOlRQ+WB5P683UjSbZ?= =?us-ascii?Q?PD768ITW+pKBdnDSwt2LpOJnGn7HzWlBHQkWpE4j2KRNCZ746WsADFN0c+io?= =?us-ascii?Q?+9hUnMAfdYPAWar15xiNNxu9adtUIc4xy4qqaCfN1YK9ovs4sBaPmj/qkZLL?= =?us-ascii?Q?/MqpG8eaqj4O0pNPaPxAFe1i6x0xAZYrvQbUl+UqYhq47v6xdkNW2B8dG3oU?= =?us-ascii?Q?Qjh/5rrYCPhVess/8kz46BOtt6K+m3Rl3yYDMH0amyPVsU7zbSFL8gSrWVfL?= =?us-ascii?Q?X1gBMB6ad0okSn2mz+Xto1AD7VC45VK9GaMgl3xUY1nk70fzj0zMKTtoNa2s?= =?us-ascii?Q?TVbOTJHIy5qDpUDzH9R7i6I+yAfxyrHrbpABiUCOmL2jJkRohrEH01Ml2xY8?= =?us-ascii?Q?Y3miD2SS2N/y61oo9m9/4YQOkWHRUfSVDmT32fVGBBaqlgjL2TiKYGS8wGJP?= =?us-ascii?Q?aQ3HVlWUlBWOwbxOzpm7DIt0s8KqkWHrYr3OS8U5RgWJ0S+joMMrIMlVeLUd?= =?us-ascii?Q?etOJU8JCu1mQLqWAyuji1jQzevmj3AislG+5eqdTnydqEWbwtaLvpOApFmZu?= =?us-ascii?Q?wI6GhO6fG69cJkPt5ALOMB8LaTRZ5HiFEK7CjcZqXNRlcWNQhADZdPrb1yX5?= =?us-ascii?Q?mNFxatWNu8j01WSLYgpIPY94zujojzQaB/rcpOwAfqibZo5CxIty4p+5tVd/?= =?us-ascii?Q?YRKwbnVUj/StLzvJrQi6AKPQhlOVEPh2UNOCmG61RGJ26mooyTY+lAjPXWpF?= =?us-ascii?Q?XWWk1jRUKdJKDwVLKJdaFN6QU8LGbii36YYtrqZqC9Zg4npNCr58SdbUMlk0?= =?us-ascii?Q?EPHYK1X1sPL5dpabanwwodcNWQhRYXbcmhFnAvlL/obaqdzynLNPZE9GeQDs?= =?us-ascii?Q?jiBL3/ztQyAWxVEeWxHIjUXXNxgUsQZVACxJgdmVm0q8bax4brKk3CM66cvu?= =?us-ascii?Q?H632Y40+K59C/0vDFAI4NimfXL+KC6dAaw0Bf5FwtASOyS/ea08TYG3GbPDm?= =?us-ascii?Q?uoKLZaFPYTcfIKngDkdM5+do1HLxIGtC5VXN7M8kHofsk4oyoN+/ogW21HH+?= =?us-ascii?Q?EKXLAtR2SHlfHn2/wFXx3pPdcZSU0edqTvOPauoS3U2XU/pqhevJsmEvhWp6?= =?us-ascii?Q?LykfYvvqjgM5B0KNL3RmWXT7kr4a5iwRl2He39HHAvfT6j9C3ea5w+wEjIR8?= =?us-ascii?Q?6I0Jj16QfYBFzS9BER2k7pW78xmdb0g+aV5CJuLPxbtsXgON5Uqsy94BzOoE?= =?us-ascii?Q?odogWvWrgVMvuEdsgYyvsYrMuXXUWr1iD3It+y/mn7dyfTFEfqzievNfgF7j?= =?us-ascii?Q?ZW47PZk+vHHp0gnfuRlTACBpxb8je8dvHBN0deZbb9oC?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: TbmaFqOAFm3SCWiqeGYD4SDn0FTW5WzKKHqA8VvB/t45gIuxmHsPCdmO5o2kAJk73DbOaJ6C0OUocnZHBPD0weroWI0NVM+p+t2wA4GD+axcS3Zapk81uq+poIWas5q/rSvmXOsffMvS9HE9fkzMRpReuUjaThO3lWbYPtRs4APYwgIRYB2iIc4bEyqEj31e6NewioM4Z/ndgrYadq+wSGcyLPJ73lFViBr73VmcpLddVCtKIHQjEGd6A6OIxxzEjslHMZV+zJxfqhgavwVbCxPG1D1o4+T80CPLai7K7cUTJ5/wa8WkawsDvSgojrzpQ/qr9KBzKG91E5U/1zhqkeFtE1ymJ3xWsXyDTroc6oK3YLJJ/GY9cPbtDzF0YobcqN0INo3uUoB8LqRLdDh/oDvtGS4RrlrsH9ptC6/OJu1FjGxBOAfjztjxyC99+rYjGtA1gYNuJfmPtJ7HLkeGM252VKbOoAdYd/rY8lL+cjCeyQRAu/5/Xf3NdC0HW6zhxM4TFQjwSxXv3MRVj4RKSaPpxAtoCkX1e0Tq5Y3lESiAqnn2dgmobpd/lDHHSS2kPQXVxslVUk1zzHU//DiGx+6Rqqw3GC2p85PHPpQuNAjjbB1+F6iH2hcRVynY00eYLvVH5V8Gi9aiQbaT6paO4kGpSAQ8D/m2pbwMfR3S4Jifqtaaob6S8ogjj+4K6NAuGNpbAgkG2KYbPW6kGV5AMgJ4RnfM2TVUBDPnbrOxH/yi+bP8NC0/4faxAkQ6KSt/yPSnpCdVktS2SI1rUFpExw== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3598fa1-52b1-4630-bfb5-08db036b0835 X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2340.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 09:10:43.9681 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RpvEilf95otXwn1oVGvZ393O+lO9P9PxAzpyf2jBNtzYrK4hv2xBr8MUGXj2kVZVFqBuZx8Vb96xhyK1IXDl2kNbyZUvnF9k3a314lYWdvE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR10MB7468 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-31_04,2023-01-30_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 suspectscore=0 adultscore=0 mlxscore=0 phishscore=0 mlxlogscore=999 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301310081 X-Proofpoint-GUID: 6dV7NY_qjV84gMfpoJDlvAAFhM4DYE3C X-Proofpoint-ORIG-GUID: 6dV7NY_qjV84gMfpoJDlvAAFhM4DYE3C X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Cupertino Miranda via Gcc-patches writes: > Thank you for the comments and suggestions. > I have changed the patch. > > Unfortunately in case of rx target I could not make > scan-assembler-symbol-section to match. I believe it is because the > .section and .global entries order is reversed in this target. > > Patch in inlined below. looking forward to your comments. > > Cupertino > > diff --git a/gcc/testsuite/gcc.dg/pr25521.c b/gcc/testsuite/gcc.dg/pr25521.c > index 63363a03b9f..82b4cd88ec0 100644 > --- a/gcc/testsuite/gcc.dg/pr25521.c > +++ b/gcc/testsuite/gcc.dg/pr25521.c > @@ -2,9 +2,10 @@ > sections. > > { dg-require-effective-target elf } > - { dg-do compile } */ > + { dg-do compile } > + { dg-skip-if "" { ! const_volatile_readonly_section } } */ > > const volatile int foo = 30; > > - > -/* { dg-final { scan-assembler "\\.s\?rodata" } } */ > +/* { dg-final { scan-assembler {.section C,} { target { rx-*-* } } } } */ > +/* { dg-final { scan-assembler-symbol-section {^_?foo$} {^\.(const|s?rodata)} { target { ! "rx-*-*" } } } } */ > diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp > index c0694af2338..91aafd89909 100644 > --- a/gcc/testsuite/lib/target-supports.exp > +++ b/gcc/testsuite/lib/target-supports.exp > @@ -12295,3 +12295,13 @@ proc check_is_prog_name_available { prog } { > > return 1 > } > + > +# returns 1 if target does selects a readonly section for const volatile variables. > +proc check_effective_target_const_volatile_readonly_section { } { > + > + if { [istarget powerpc-*-*] > + || [check-flags { "" { powerpc64-*-* } { -m32 } }] } { > + return 0 > + } > + return 1 > +} > > > Jeff Law writes: > >> On 12/7/22 08:45, Cupertino Miranda wrote: >>> >>>> On 12/2/22 10:52, Cupertino Miranda via Gcc-patches wrote: >>>>> This commit is a follow up of bugzilla #107181. >>>>> The commit /a0aafbc/ changed the default implementation of the >>>>> SELECT_SECTION hook in order to match clang/llvm behaviour w.r.t the >>>>> placement of `const volatile' objects. >>>>> However, the following targets use target-specific selection functions >>>>> and they choke on the testcase pr25521.c: >>>>> *rx - target sets its const variables as '.section C,"a",@progbits'. >>>> That's presumably a constant section. We should instead twiddle the test to >>>> recognize that section. >>> Although @progbits is indeed a constant section, I believe it is >>> more interesting to detect if the `rx' starts selecting more >>> standard sections instead of the current @progbits. >>> That was the reason why I opted to XFAIL instead of PASSing it. >>> Can I keep it as such ? >> I'm not aware of any ongoing development for that port, so I would not let >> concerns about the rx port changing behavior dominate how we approach this >> problem. >> >> The rx port is using a different name for the section. That's valid thing to >> do and to the extent we can, we should support that in the test rather than >> (incorrectly IMHO) xfailing the test just becuase the name isn't what we >> expected. >> >> To avoid over-eagerly matching, I would probably search for "C," I wouldn't do >> that for the const or rodata sections as they often have a suffix like 1, 2, 4, >> 8 for different sized rodata sections. >> >> PPC32 is explicitly doing something different and placing those objects into an >> RW section. So for PPC32 it makes more sense to skip the test rather than xfail >> it. >> >> Jeff