public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tulio Magno Quites Machado Filho <tuliom@ascii.art.br>
To: Jonathan Wakely <jwakely@redhat.com>,
	Michael Meissner <meissner@linux.ibm.com>,
	libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org,
	Bill Schmidt <wschmidt@linux.ibm.com>,
	David Edelsohn <dje.gcc@gmail.com>,
	Segher Boessenkool <segher@kernel.crashing.org>,
	Peter Berner <bergner@linux.ibm.com>
Subject: Re: [PATCH] libstdc++: Add C++ runtime support for new 128-bit long double format
Date: Thu, 03 Dec 2020 20:07:18 -0300	[thread overview]
Message-ID: <87v9dibiah.fsf@linux.ibm.com> (raw)
In-Reply-To: <20201201160430.GL2309743@redhat.com>

Jonathan Wakely via Libstdc++ <libstdc++@gcc.gnu.org> writes:

> diff --git a/libstdc++-v3/configure.ac b/libstdc++-v3/configure.ac
> index cbfdf4c6bad..d25842fef35 100644
> --- a/libstdc++-v3/configure.ac
> +++ b/libstdc++-v3/configure.ac
> @@ -421,12 +425,43 @@ case "$target" in
>      port_specific_symbol_files="\$(top_srcdir)/config/os/gnu-linux/ldbl-extra.ver"
>      case "$target" in
>        powerpc*-*-linux*)
> -	LONG_DOUBLE_COMPAT_FLAGS="$LONG_DOUBLE_COMPAT_FLAGS -mno-gnu-attribute" ;;
> +	LONG_DOUBLE_COMPAT_FLAGS="$LONG_DOUBLE_COMPAT_FLAGS -mno-gnu-attribute"
> +        # Check for IEEE128 support in libm:
> +        AC_CHECK_LIB(m, frexpf128,

I suggest to replace frexpf128 with __frexpieee128.

The former is available on a glibc that support _Float128 (since glibc 2.26).
The later is available on a glibc that supports binary128 long double (since
glibc 2.32)

Without this modification, the build fails on glibc between 2.26 and 2.31.

I'm also running a couple of tests here.
I believe this is showing a couple of glitches in glibc which I'm already
investigating.

Thanks!

-- 
Tulio Magno

  parent reply	other threads:[~2020-12-03 23:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-11 21:50 Jonathan Wakely
2020-11-30 21:30 ` Michael Meissner
2020-12-01 15:10   ` Jonathan Wakely
2020-12-01 16:04     ` Jonathan Wakely
2020-12-01 19:10       ` Michael Meissner
2020-12-01 21:10         ` Jonathan Wakely
2020-12-01 21:41           ` Jonathan Wakely
     [not found]           ` <20201201222501.GA18971@ibm-toto.the-meissners.org>
2020-12-01 22:36             ` Jonathan Wakely
2020-12-01 23:24               ` Michael Meissner
2020-12-02 15:14               ` Michael Meissner
2020-12-01 23:32           ` Michael Meissner
2020-12-03 23:07       ` Tulio Magno Quites Machado Filho [this message]
2020-12-04  0:35         ` Jonathan Wakely
2020-12-10 16:14           ` Jonathan Wakely
2020-12-10 17:14             ` Peter Bergner
2020-12-10 17:27               ` Jonathan Wakely
2020-12-15  0:57             ` Tulio Magno Quites Machado Filho
2020-11-30 23:29 ` Segher Boessenkool
2020-12-01 15:04   ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9dibiah.fsf@linux.ibm.com \
    --to=tuliom@ascii.art.br \
    --cc=bergner@linux.ibm.com \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jwakely@redhat.com \
    --cc=libstdc++@gcc.gnu.org \
    --cc=meissner@linux.ibm.com \
    --cc=segher@kernel.crashing.org \
    --cc=wschmidt@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).