From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65534 invoked by alias); 19 May 2017 11:09:47 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 65505 invoked by uid 89); 19 May 2017 11:09:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=reserved, ten X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 May 2017 11:09:44 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=svr-ies-mbx-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1dBfmy-0006mL-S7 from Thomas_Schwinge@mentor.com ; Fri, 19 May 2017 04:09:44 -0700 Received: from hertz.schwinge.homeip.net (137.202.0.87) by svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Fri, 19 May 2017 12:09:41 +0100 From: Thomas Schwinge To: Jakub Jelinek , Subject: Re: Remove unused "default_kind" member from gcc/omp-low.c's "struct omp_context" In-Reply-To: <87d1cxfpvq.fsf@euler.schwinge.homeip.net> References: <87d1cxfpvq.fsf@euler.schwinge.homeip.net> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 19 May 2017 11:13:00 -0000 Message-ID: <87vaoxyufg.fsf@hertz.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-SW-Source: 2017-05/txt/msg01552.txt.bz2 Hi! Ping. On Fri, 31 Mar 2017 17:05:29 +0200, I wrote: > It would appear that ever since the first version of gcc/omp-low.c got > committed to GCC trunk (more than ten years ago), it extraced OpenMP > default clause data that it doesn't actually use for anything. OK to > commit the following cleanup to trunk in next stage 1? >=20 > commit cd157ff348694009f4043b84f47de8c62774931f > Author: Thomas Schwinge > Date: Fri Mar 31 15:26:55 2017 +0200 >=20 > Remove unused "default_kind" member from gcc/omp-low.c's "struct omp_= context" >=20=20=20=20=20 > gcc/ > * omp-low.c (struct omp_context): Remove "default_kind" membe= r. > Adjust all users. > --- > gcc/omp-low.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) >=20 > diff --git gcc/omp-low.c gcc/omp-low.c > index 253dc85..d794e00 100644 > --- gcc/omp-low.c > +++ gcc/omp-low.c > @@ -112,10 +112,6 @@ struct omp_context > otherwise. */ > gimple *simt_stmt; >=20=20 > - /* What to do with variables with implicitly determined sharing > - attributes. */ > - enum omp_clause_default_kind default_kind; > - > /* Nesting depth of this context. Used to beautify error messages re > invalid gotos. The outermost ctx is depth 1, with depth 0 being > reserved for the main body of the function. */ > @@ -1162,10 +1158,6 @@ scan_sharing_clauses (tree clauses, omp_context *c= tx, > install_var_field (decl, by_ref, 3, ctx); > break; >=20=20 > - case OMP_CLAUSE_DEFAULT: > - ctx->default_kind =3D OMP_CLAUSE_DEFAULT_KIND (c); > - break; > - > case OMP_CLAUSE_FINAL: > case OMP_CLAUSE_IF: > case OMP_CLAUSE_NUM_THREADS: > @@ -1332,6 +1324,7 @@ scan_sharing_clauses (tree clauses, omp_context *ct= x, > case OMP_CLAUSE_SEQ: > case OMP_CLAUSE_TILE: > case OMP_CLAUSE__SIMT_: > + case OMP_CLAUSE_DEFAULT: > break; >=20=20 > case OMP_CLAUSE_ALIGNED: > @@ -1826,7 +1819,6 @@ scan_omp_parallel (gimple_stmt_iterator *gsi, omp_c= ontext *outer_ctx) > if (taskreg_nesting_level > 1) > ctx->is_nested =3D true; > ctx->field_map =3D splay_tree_new (splay_tree_compare_pointers, 0, 0); > - ctx->default_kind =3D OMP_CLAUSE_DEFAULT_SHARED; > ctx->record_type =3D lang_hooks.types.make_type (RECORD_TYPE); > name =3D create_tmp_var_name (".omp_data_s"); > name =3D build_decl (gimple_location (stmt), > @@ -1873,7 +1865,6 @@ scan_omp_task (gimple_stmt_iterator *gsi, omp_conte= xt *outer_ctx) > if (taskreg_nesting_level > 1) > ctx->is_nested =3D true; > ctx->field_map =3D splay_tree_new (splay_tree_compare_pointers, 0, 0); > - ctx->default_kind =3D OMP_CLAUSE_DEFAULT_SHARED; > ctx->record_type =3D lang_hooks.types.make_type (RECORD_TYPE); > name =3D create_tmp_var_name (".omp_data_s"); > name =3D build_decl (gimple_location (stmt), > @@ -2360,7 +2351,6 @@ scan_omp_target (gomp_target *stmt, omp_context *ou= ter_ctx) >=20=20 > ctx =3D new_omp_context (stmt, outer_ctx); > ctx->field_map =3D splay_tree_new (splay_tree_compare_pointers, 0, 0); > - ctx->default_kind =3D OMP_CLAUSE_DEFAULT_SHARED; > ctx->record_type =3D lang_hooks.types.make_type (RECORD_TYPE); > name =3D create_tmp_var_name (".omp_data_t"); > name =3D build_decl (gimple_location (stmt), Gr=C3=BC=C3=9Fe Thomas