From: Thomas Schwinge <thomas@codesourcery.com>
To: Nathan Sidwell <nathan@codesourcery.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Cesar Philippidis <cesar_philippidis@mentor.com>,
Jakub Jelinek <jakub@redhat.com>
Subject: Re: OpenACC Firstprivate
Date: Thu, 12 Nov 2015 09:00:00 -0000 [thread overview]
Message-ID: <87vb97twxj.fsf@kepler.schwinge.homeip.net> (raw)
In-Reply-To: <56434643.6010009@acm.org>
[-- Attachment #1: Type: text/plain, Size: 1602 bytes --]
Hi Nathan!
Merging back your trunk r230169 into gomp-4_0-branch, for the new
libgomp/testsuite/libgomp.oacc-c-c++-common/firstprivate-2.c test, I'm
seeing the compiler diagnose as follows (compile with "-Wall -O2"):
source-gcc/libgomp/testsuite/libgomp.oacc-c-c++-common/firstprivate-2.c: In function 'main._omp_fn.1':
source-gcc/libgomp/testsuite/libgomp.oacc-c-c++-common/firstprivate-2.c:20:17: warning: 'val' is used uninitialized in this function [-Wuninitialized]
ok = val == 7;
^
source-gcc/libgomp/testsuite/libgomp.oacc-c-c++-common/firstprivate-2.c:9:7: note: 'val' was declared here
int val = 2;
^
..., and execution fails ("return 1" from main), so I XFAILed the
execution in the merge commit r230214 on gomp-4_0-branch. (..., and I
still think that it's a good idea to change the libgomp testsuite to run
with -Wall enabled...)
Do you have an idea what's going on? Given your preparatory "[gomp4]
Rework gimplifyier region flags",
<http://news.gmane.org/find-root.php?message_id=%3C56434833.7010703%40acm.org%3E>
(thanks!), the merge commit r230214 on gomp-4_0-branch didn't contain any
changes to gcc/gimplify.c, so that can't be it. It also can't be the
possibly inconsistent usage of gcc/omp-low.c:is_reference vs. "TREE_CODE
(TREE_TYPE ([...])) == REFERENCE_TYPE" in gcc/omp-low.c, because that
doesn't matter for C code anyway (no artificial REFERENCE_TYPEs
generated), right? So it must be some other change installed on
gomp-4_0-branch but not on trunk.
Grüße
Thomas
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]
next prev parent reply other threads:[~2015-11-12 9:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-07 13:50 Nathan Sidwell
2015-11-09 13:46 ` Jakub Jelinek
2015-11-09 13:59 ` Nathan Sidwell
2015-11-09 14:06 ` Nathan Sidwell
2015-11-09 14:10 ` Jakub Jelinek
2015-11-09 14:46 ` Nathan Sidwell
2015-11-10 14:13 ` Nathan Sidwell
2015-11-11 8:05 ` Jakub Jelinek
2015-11-11 13:44 ` Nathan Sidwell
2015-11-12 9:00 ` Thomas Schwinge [this message]
2015-11-11 13:52 ` [gomp4] Rework gimplifyier region flags Nathan Sidwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vb97twxj.fsf@kepler.schwinge.homeip.net \
--to=thomas@codesourcery.com \
--cc=cesar_philippidis@mentor.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=nathan@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).