From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2610 invoked by alias); 31 Jan 2015 11:50:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 2585 invoked by uid 89); 31 Jan 2015 11:50:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: service87.mimecast.com Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 31 Jan 2015 11:50:21 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by service87.mimecast.com; Sat, 31 Jan 2015 11:50:18 +0000 Received: from localhost ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Sat, 31 Jan 2015 11:50:16 +0000 From: Richard Sandiford To: Robert Suchanek Mail-Followup-To: Robert Suchanek ,"gcc-patches\@gcc.gnu.org" , Matthew Fortune , "Catherine_Moore\@mentor.com" , richard.sandiford@arm.com Cc: "gcc-patches\@gcc.gnu.org" , Matthew Fortune , "Catherine_Moore\@mentor.com" Subject: Re: [PATCH MIPS RFA] Regression cleanup for nan2008 toolchain References: Date: Sat, 31 Jan 2015 19:20:00 -0000 In-Reply-To: (Robert Suchanek's message of "Mon, 26 Jan 2015 11:48:28 +0000") Message-ID: <87vbjnnp8n.fsf@e105548-lin.cambridge.arm.com> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-MC-Unique: 115013111501800201 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2015-01/txt/msg02804.txt.bz2 Robert Suchanek writes: > diff --git a/gcc/testsuite/gcc.target/mips/loongson-simd.c b/gcc/testsuit= e/gcc.target/mips/loongson-simd.c > index 160da6b..949632e 100644 > --- a/gcc/testsuite/gcc.target/mips/loongson-simd.c > +++ b/gcc/testsuite/gcc.target/mips/loongson-simd.c > @@ -22,6 +22,7 @@ along with GCC; see the file COPYING3. If not see > /* loongson.h does not handle or check for MIPS16ness or > microMIPSness. There doesn't seem any good reason for it to, given > that the Loongson processors do not support either. */ > +/* { dg-require-effective-target mips_nanlegacy } */ > /* { dg-options "isa=3Dloongson -mhard-float -mno-micromips -mno-mips16 = -flax-vector-conversions" } */ Nit, but this splits the dg-options from the comment that explains the options. Please could you add a comment explaining that the mips_nanlegacy is there because of the #include of system headers that might not compile with -mnan=3Dlegacy? I agree that that's a good reason, but it's not obvious without a comment. (And without a comment this could start a precendent of things being skipped in cases where the mips.exp options machinery could be updated instead.) Thanks, Richard