* [PATCH] Handle MIPS EVA
@ 2013-06-03 17:25 Moore, Catherine
2013-06-03 18:27 ` Richard Sandiford
0 siblings, 1 reply; 5+ messages in thread
From: Moore, Catherine @ 2013-06-03 17:25 UTC (permalink / raw)
To: rdsandiford; +Cc: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 303 bytes --]
Hi Richard,
This is the gcc patch to handle the -meva option to gcc. Okay?
Thanks,
Catherine
2013-06-03 Catherine Moore <clm@codesourcery.com>
gcc/
* config/mips/mips.opt (meva): New.
* config/mips/mips.h (TARGET_CPU_CPP_BUILTINS):
Define __mips_eva.
(ASM_SPEC): Handle -meva.
[-- Attachment #2: gcc.eva.patch --]
[-- Type: application/octet-stream, Size: 1309 bytes --]
Index: config/mips/mips.opt
===================================================================
--- config/mips/mips.opt (revision 199610)
+++ config/mips/mips.opt (working copy)
@@ -141,6 +141,10 @@ membedded-data
Target Report Var(TARGET_EMBEDDED_DATA)
Use ROM instead of RAM
+meva
+Target Report Var(TARGET_EVA)
+Use microMIPS32/MIPS32 Enhanced VA instructions
+
mexplicit-relocs
Target Report Mask(EXPLICIT_RELOCS)
Use NewABI-style %reloc() assembly operators
Index: config/mips/mips.h
===================================================================
--- config/mips/mips.h (revision 199610)
+++ config/mips/mips.h (working copy)
@@ -399,6 +399,11 @@ struct mips_cpu_info {
if (TARGET_MCU) \
builtin_define ("__mips_mcu"); \
\
+ if (TARGET_EVA) \
+ { \
+ builtin_define ("__mips_eva"); \
+ } \
+ \
if (TARGET_DSP) \
{ \
builtin_define ("__mips_dsp"); \
@@ -1125,6 +1130,7 @@ struct mips_cpu_info {
%{mdsp} %{mno-dsp} \
%{mdspr2} %{mno-dspr2} \
%{mmcu} %{mno-mcu} \
+%{meva} %{mno-eva} \
%{msmartmips} %{mno-smartmips} \
%{mmt} %{mno-mt} \
%{mfix-vr4120} %{mfix-vr4130} \
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Handle MIPS EVA
2013-06-03 17:25 [PATCH] Handle MIPS EVA Moore, Catherine
@ 2013-06-03 18:27 ` Richard Sandiford
2013-06-03 21:44 ` Maciej W. Rozycki
2013-06-03 23:26 ` Moore, Catherine
0 siblings, 2 replies; 5+ messages in thread
From: Richard Sandiford @ 2013-06-03 18:27 UTC (permalink / raw)
To: Moore, Catherine; +Cc: gcc-patches
"Moore, Catherine" <Catherine_Moore@mentor.com> writes:
> Index: config/mips/mips.opt
> ===================================================================
> --- config/mips/mips.opt (revision 199610)
> +++ config/mips/mips.opt (working copy)
> @@ -141,6 +141,10 @@ membedded-data
> Target Report Var(TARGET_EMBEDDED_DATA)
> Use ROM instead of RAM
>
> +meva
> +Target Report Var(TARGET_EVA)
> +Use microMIPS32/MIPS32 Enhanced VA instructions
This is likely to get out of date if EVA is ever extended to MIPS64.
It's probably easier just to drop the "microMIPS32/MIPS32" bit.
> Index: config/mips/mips.h
> ===================================================================
> --- config/mips/mips.h (revision 199610)
> +++ config/mips/mips.h (working copy)
> @@ -399,6 +399,11 @@ struct mips_cpu_info {
> if (TARGET_MCU) \
> builtin_define ("__mips_mcu"); \
> \
> + if (TARGET_EVA) \
> + { \
> + builtin_define ("__mips_eva"); \
> + } \
> + \
This should be:
if (TARGET_EVA) \
builtin_define ("__mips_eva"); \
You need to document the option too.
Thanks,
Richard
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Handle MIPS EVA
2013-06-03 18:27 ` Richard Sandiford
@ 2013-06-03 21:44 ` Maciej W. Rozycki
2013-06-03 23:26 ` Moore, Catherine
1 sibling, 0 replies; 5+ messages in thread
From: Maciej W. Rozycki @ 2013-06-03 21:44 UTC (permalink / raw)
To: Richard Sandiford; +Cc: Moore, Catherine, gcc-patches
On Mon, 3 Jun 2013, Richard Sandiford wrote:
> > Index: config/mips/mips.opt
> > ===================================================================
> > --- config/mips/mips.opt (revision 199610)
> > +++ config/mips/mips.opt (working copy)
> > @@ -141,6 +141,10 @@ membedded-data
> > Target Report Var(TARGET_EMBEDDED_DATA)
> > Use ROM instead of RAM
> >
> > +meva
> > +Target Report Var(TARGET_EVA)
> > +Use microMIPS32/MIPS32 Enhanced VA instructions
>
> This is likely to get out of date if EVA is ever extended to MIPS64.
> It's probably easier just to drop the "microMIPS32/MIPS32" bit.
I agree, however may I suggest spelling out EVA in full, that is:
"Use Enhanced Virtual Addressing instructions"
Maciej
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] Handle MIPS EVA
2013-06-03 18:27 ` Richard Sandiford
2013-06-03 21:44 ` Maciej W. Rozycki
@ 2013-06-03 23:26 ` Moore, Catherine
2013-06-04 6:22 ` Richard Sandiford
1 sibling, 1 reply; 5+ messages in thread
From: Moore, Catherine @ 2013-06-03 23:26 UTC (permalink / raw)
To: Richard Sandiford; +Cc: gcc-patches, Rozycki, Maciej
[-- Attachment #1: Type: text/plain, Size: 1898 bytes --]
> -----Original Message-----
> From: Richard Sandiford [mailto:rdsandiford@googlemail.com]
> Sent: Monday, June 03, 2013 2:28 PM
> To: Moore, Catherine
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: [PATCH] Handle MIPS EVA
>
> "Moore, Catherine" <Catherine_Moore@mentor.com> writes:
> > Index: config/mips/mips.opt
> >
> ==========================================================
> =========
> > --- config/mips/mips.opt (revision 199610)
> > +++ config/mips/mips.opt (working copy)
> > @@ -141,6 +141,10 @@ membedded-data
> > Target Report Var(TARGET_EMBEDDED_DATA) Use ROM instead of RAM
> >
> > +meva
> > +Target Report Var(TARGET_EVA)
> > +Use microMIPS32/MIPS32 Enhanced VA instructions
>
> This is likely to get out of date if EVA is ever extended to MIPS64.
> It's probably easier just to drop the "microMIPS32/MIPS32" bit.
Now done, plus incorporated Maciej's suggestion.
>
> > Index: config/mips/mips.h
> >
> ==========================================================
> =========
> > --- config/mips/mips.h (revision 199610)
> > +++ config/mips/mips.h (working copy)
> > @@ -399,6 +399,11 @@ struct mips_cpu_info {
> > if (TARGET_MCU) \
> > builtin_define ("__mips_mcu");
> \
> > \
> > + if (TARGET_EVA) \
> > + { \
> > + builtin_define ("__mips_eva"); \
> > + } \
> > + \
>
> This should be:
>
> if (TARGET_EVA) \
> builtin_define ("__mips_eva"); \
>
> You need to document the option too.
>
Also done.
Okay, now?
2013-06-03 Catherine Moore <clm@codesourcery.com>
gcc/
* config/mips/mips.opt (meva): New.
* config/mips/mips.h (TARGET_CPU_CPP_BUILTINS):
Define __mips_eva.
(ASM_SPEC): Handle -meva.
* doc/invoke.texi (meva): Document.
[-- Attachment #2: gcc.eva.patch --]
[-- Type: application/octet-stream, Size: 2031 bytes --]
Index: doc/invoke.texi
===================================================================
--- doc/invoke.texi (revision 199610)
+++ doc/invoke.texi (working copy)
@@ -752,6 +752,7 @@ Objective-C and Objective-C++ Dialects}.
-mno-float -msingle-float -mdouble-float @gol
-mdsp -mno-dsp -mdspr2 -mno-dspr2 @gol
-mmcu -mmno-mcu @gol
+-meva -mno-eva @gol
-mmicromips -mno-micromips @gol
-mfpu=@var{fpu-type} @gol
-msmartmips -mno-smartmips @gol
@@ -16376,6 +16377,12 @@ Use (do not use) MT Multithreading instructions.
@opindex mno-mcu
Use (do not use) the MIPS MCU ASE instructions.
+@item -meva
+@itemx -mno-eva
+@opindex meva
+@opindex mno-eva
+Use (do not use) the MIPS EVA instructions.
+
@item -mlong64
@opindex mlong64
Force @code{long} types to be 64 bits wide. See @option{-mlong32} for
Index: config/mips/mips.opt
===================================================================
--- config/mips/mips.opt (revision 199610)
+++ config/mips/mips.opt (working copy)
@@ -141,6 +141,10 @@ membedded-data
Target Report Var(TARGET_EMBEDDED_DATA)
Use ROM instead of RAM
+meva
+Target Report Var(TARGET_EVA)
+Use Enhanced Virtual Addressing instructions
+
mexplicit-relocs
Target Report Mask(EXPLICIT_RELOCS)
Use NewABI-style %reloc() assembly operators
Index: config/mips/mips.h
===================================================================
--- config/mips/mips.h (revision 199610)
+++ config/mips/mips.h (working copy)
@@ -399,6 +399,9 @@ struct mips_cpu_info {
if (TARGET_MCU) \
builtin_define ("__mips_mcu"); \
\
+ if (TARGET_EVA) \
+ builtin_define ("__mips_eva"); \
+ \
if (TARGET_DSP) \
{ \
builtin_define ("__mips_dsp"); \
@@ -1125,6 +1128,7 @@ struct mips_cpu_info {
%{mdsp} %{mno-dsp} \
%{mdspr2} %{mno-dspr2} \
%{mmcu} %{mno-mcu} \
+%{meva} %{mno-eva} \
%{msmartmips} %{mno-smartmips} \
%{mmt} %{mno-mt} \
%{mfix-vr4120} %{mfix-vr4130} \
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Handle MIPS EVA
2013-06-03 23:26 ` Moore, Catherine
@ 2013-06-04 6:22 ` Richard Sandiford
0 siblings, 0 replies; 5+ messages in thread
From: Richard Sandiford @ 2013-06-04 6:22 UTC (permalink / raw)
To: Moore, Catherine; +Cc: gcc-patches, Rozycki, Maciej
"Moore, Catherine" <Catherine_Moore@mentor.com> writes:
> @@ -16376,6 +16377,12 @@ Use (do not use) MT Multithreading instructions.
> @opindex mno-mcu
> Use (do not use) the MIPS MCU ASE instructions.
>
> +@item -meva
> +@itemx -mno-eva
> +@opindex meva
> +@opindex mno-eva
> +Use (do not use) the MIPS EVA instructions.
Please spell it out here too, for consistency:
Use (do not use) the MIPS Enhanced Virtual Addressing instructions.
OK with that change, thanks.
Richard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-06-04 6:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-03 17:25 [PATCH] Handle MIPS EVA Moore, Catherine
2013-06-03 18:27 ` Richard Sandiford
2013-06-03 21:44 ` Maciej W. Rozycki
2013-06-03 23:26 ` Moore, Catherine
2013-06-04 6:22 ` Richard Sandiford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).