From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id C879D3858C78 for ; Thu, 18 Apr 2024 16:41:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C879D3858C78 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C879D3858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::435 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713458492; cv=none; b=vmOzRnu6g9VyurUQ43+89qRGJFzMAtxGATlXxzsTtZ9eqmY62AEbZeSFTMd1lrfaUrWqqVn+LBbjIcr2zIG5F0oFvAc75avfTOazNd0B2W4edVXwzuex9IabBtDScJ4kW1sW0kh9ObKyIQ+H+3C4cTE4wgz4Zi7wUuE5PlMWd10= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713458492; c=relaxed/simple; bh=MmP631glThH+6IEqWUfp1LuQNEjHKmmMkM4lt00qK24=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=i2vbZPg7MezYLHW5b15XJ0uhkkYUI/XDDtQ+yvs5CAEpun3noldi010pkh7/AxO6wvubqc+rqVEvgtQ6XFGYMe9uRDLXu7XxDdZ+F68NgdPORqhJ+NGX/wWBUjfmgGqgwX5VV+kyTGIYgCq//A1DIkoTSm55eJEwPzet55x5R+Q= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-34665dd7744so696250f8f.1 for ; Thu, 18 Apr 2024 09:41:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1713458489; x=1714063289; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BJ882NGvXUF7rynTRiCzxcp8aYMBssw0ss7U3izO1i8=; b=JxyR9ZUPHKFbsQG+1ll7rv55j6xL3EdQYlj2hndumuQ8adwjf0tJZrJ0/ApJNlIwPS XEcN42817uWruG/1PEIBhVMpCIdYPxIvZVqInNFPQLAqmir/n837D+HG0xiDfEwVZmhL ASFKitixwepsfc3SZQt1dxR0wiuqAZCEhJiCOXubYwdOfbJDEyEp4gZOmAhNJIjY3Ysp TcyaI7ZgPBsPq8sNyp0bdMworXy3xIKXwGwHItUP08kyRE/ILIxutZ5BDFc5n1ziYShC hHg+38wf0OGpYxEP5GYmBoLjvDQGCByWAVSOjc+9nyFmFOoQECzUzLN0lNSLVzjiaGm2 xrgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713458489; x=1714063289; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BJ882NGvXUF7rynTRiCzxcp8aYMBssw0ss7U3izO1i8=; b=BCTLUc/13VP1cow3GrQKz84kwii6UurQiYqwkYLCR56KI4hZx2jCrRaCUxFh/v+cvh W7AuLpzsi1GVwp0hLXvOg1zA1aDiu9ISwVMZFjX07GzWbtjP9KLK3/mmRawXujwdRwYe FspHVXLSJdtSGnFcdqLioXW4bGUBRFTgnsfEDNZrnQNSeTCzWYu4+boUjwGCQ3LqQUJQ lfWZG+mll1bAg1mxiUjCKqvLYqSGGiXTirjezwVMDXY/M4EjQ7wnXhiX4IvlS9yim1Qi x2irH+/UD5buT91NCwx6bTR6CamQOzu2ziKr0xOTPMPMeYtOpQ+j+poXwr0Fymsis5ew 7EuA== X-Gm-Message-State: AOJu0YxkyN8pVhZe+EtZQmB3n3KS3XL4HApPYquszUbbH/iCTZ7LDSke MTd4O/8r6/iSHmQ+vlyw1gcLyRIMoAw4QW4qihfCSaWwvuUB+a8nTXwJ6w9RlvT3/mM/XVaV9/I = X-Google-Smtp-Source: AGHT+IEVagFR+PmzZt13ET+zCA0lo9CgDBpWm/aSjEqf/4t7kHNiqYuwJtdZfTRVHvMMfbgzv0S7Ug== X-Received: by 2002:a05:6000:181a:b0:347:70ce:c5e3 with SMTP id m26-20020a056000181a00b0034770cec5e3mr2100578wrh.19.1713458488870; Thu, 18 Apr 2024 09:41:28 -0700 (PDT) Received: from legouguec-Precision-7550 ([2a01:e0a:253:fe0:741d:eb62:4e4b:a25f]) by smtp.gmail.com with ESMTPSA id a7-20020adfeec7000000b00349cadc5024sm2234889wrp.61.2024.04.18.09.41.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 09:41:28 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Arsen =?utf-8?Q?Arsenovi=C4=87?= Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 0/3] Recover in-tree libiconv build support In-Reply-To: <20240414001113.1698685-1-arsen@aarsen.me> ("Arsen =?utf-8?Q?Arsenovi=C4=87=22's?= message of "Sat, 13 Apr 2024 23:58:01 +0200") References: <20240414001113.1698685-1-arsen@aarsen.me> Date: Thu, 18 Apr 2024 18:41:27 +0200 Message-ID: <87wmoud3ns.fsf@adacore.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Arsen Arsenovi=C4=87 writes: > Evening! > > This patchset recovers support for building the toolchain tree with > in-tree libiconv being used for host modules and gettext. As spotted by > K=C3=A9vin Le Gouguec , I accidentally removed this > functionality earlier. > > This patchset includes the patch sent as: > > https://inbox.sourceware.gcc-patches/20231221193243.368541-1-arsen@aarsen= .me/ > > ... and so, supersedes that patchset. > > For the in-tree case, the old patch functionality was restored and > rebased on top of current iconv.m4. Of course, this does not work for > gettext, an out-of-tree lib depending on the in-tree libiconv, so, for > that case, we needed to provide the right information to configure, and > suppress logic in iconv.m4 using cache vars. > > Build-tested on arm64-apple-darwin21.6.0, and I intend to do further > testing tomorrow. > > OK for trunk? It would be good to get these patches into GCC 14. > > I apologize for being quite late with delivering these, I have, > unfortunately, been busied by various external factors. Hopefully, it > is not too late yet. FWIW, I apologize too for not taking a stab at the fix; on our end, we pondered this briefly and figured we had no compelling reason to continue relying on in-tree libiconv builds, so we tweaked our packaging recipes to configure --with-libiconv-prefix and that was that. Thanks for finding the time to work on this!