From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 34C1F3858D38 for ; Wed, 6 Dec 2023 12:13:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 34C1F3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 34C1F3858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701864785; cv=none; b=Ap9VdPSm4vp5t5lrF6K70Wd/EK9IgU5Tr2ThxmOAMxkJ+Qd+SXs3loIOuNLizdANKqnLOUbgC/YCgDyGcPs2JtKSe2Pv7X0LdnrrPl3cEhxjKRKgb2LcX+yRu174OchqdzGJUSQh/Z61Cm8z80TLoLpGC3TWf//eo9bvw7BoVZo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701864785; c=relaxed/simple; bh=mAAFqwXPEHXedrEsy8L2shlShCrENAqBtFKAcUeRTi0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=e+jxj3wcMdwjO6r+K6gNWjoS/X7ubMkK3podKXOkZYkmepZIVJEQhWDpIn9RN76vJeARFjVqMIhyi5LewXi7z3rMxyXPg0nq0gIYRKBGJ8twFDmzU0AiX9WBx3N/CIw7Kjl7fdnYUseESBN+kGdqTScHWs3amyK9TqsiJzrgDQw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701864780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nx4X8ooNGdsP1yYT1CLjqwVewsLRfiUlANZTSl62DZ4=; b=Cc7rTofF7VOS+Xzry3xZSVzK0DtyebVlLS34MDYfpWoSr1N/YQHcnDkZ9kgwvn3QWMxDkn EMy+JQrcRx3Dbu6rGGTh8v3J5hm+Dyaz4OAUPISnFce0ru50Nebhre7lM5zoMAx/ZuKm48 oBYcnwgex89w6itZAW0W9BGRDbV5CLQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-R7Jlhq12OFmPC7u5hirotw-1; Wed, 06 Dec 2023 07:12:59 -0500 X-MC-Unique: R7Jlhq12OFmPC7u5hirotw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 24BCD863065; Wed, 6 Dec 2023 12:12:59 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.186]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 59D1936F1; Wed, 6 Dec 2023 12:12:58 +0000 (UTC) From: Florian Weimer To: Prathamesh Kulkarni Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH v3 10/11] c: Turn -Wincompatible-pointer-types into a permerror References: <9e40a64880a14cf27d788ecbaf23365b9a5ac069.1700473918.git.fweimer@redhat.com> Date: Wed, 06 Dec 2023 13:12:56 +0100 In-Reply-To: (Prathamesh Kulkarni's message of "Wed, 6 Dec 2023 17:34:29 +0530") Message-ID: <87wmtrbkc7.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Prathamesh Kulkarni: > On Mon, 20 Nov 2023 at 15:28, Florian Weimer wrote: >> >> The change to build_conditional_expr drops the downgrade >> from a pedwarn to warning for builtins for C99 and later >> language dialects. It remains a warning in C89 mode (not >> a permerror), as the -std=gnu89 -fno-permissive test shows. > Hi Florian, > It seems this patch caused a fallout for > gcc.dg/fixed-point/composite-type.c on arm, where the tests for > warnings fail. > For instance: > FAIL: gcc.dg/fixed-point/composite-type.c (test for warnings, line 71) > Excess errors: > /home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/snapshots/gcc.git~master/gcc/testsuite/gcc.dg/fixed-point/composite-type.c:71:3: > error: passing argument 1 of 'f2_sf' from incompatible pointer type > [-Wincompatible-pointer-types] > /home/tcwg-buildslave/workspace/tcwg_gnu_1/abe/snapshots/gcc.git~master/gcc/testsuite/gcc.dg/fixed-point/composite-type.c:71:3: > error: passing argument 1 of 'f2_sf' from incompatible pointer type > [-Wincompatible-pointer-types] > (snipped rest) > > Should these warnings be now upgraded to dg-error ? Right, a patch for this was posted (but I don't see it in the archives): From: Yang Yujie Subject: [PATCH] testsuite: Adjust for the new permerror -Wincompatible-pointer-types To: gcc-patches@gcc.gnu.org Cc: ro@CeBiTec.Uni-Bielefeld.DE, mikestump@comcast.net, fweimer@redhat.com, Yang Yujie Date: Wed, 6 Dec 2023 10:29:31 +0800 (9 hours, 42 minutes, 7 seconds ago) Message-ID: <20231206022931.33437-1-yangyujie@loongson.cn> Thanks, Florian