From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 905063858D33 for ; Tue, 7 Feb 2023 09:53:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 905063858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3177nbeW029626; Tue, 7 Feb 2023 09:53:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=references : from : to : cc : subject : in-reply-to : date : message-id : content-type : mime-version; s=corp-2022-7-12; bh=rtWvAyilyVLk5S0FO38Wxkp/L0H9XFKIij8+mPe3qRo=; b=V111AhOJjphrl1vTTFVhVL2+MI8hpuYP5YqwbUgnuclNqa1jFLzWz5WI+tedrqqh0rNp rNg83gxqfjJXLoeUtU7la8bIk5df+6lPHQ87wzf0/SF+QIzhF/5DC1IDfqUHYySiwWkG bwADCuqA32grAQHcAbGIdJttKfEuiXq3IB9KVeKuiaKFhhV3NnhfH+IJRIKSESZq/YyY HDMSxKd97WEN5B5LbggKHRoVzCQjd83GodI8us9Prox9fQuzWHBP8brMrcGgsvVmyYu9 0c/k9kUfYaSQTL1q6zmqsrb0hIH+7FNNrwzkIACDY3Su0+D1ahM1LFkWPzKojME9auN2 vw== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3nhdy153vn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 07 Feb 2023 09:53:57 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 31795qga003760; Tue, 7 Feb 2023 09:53:56 GMT Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2042.outbound.protection.outlook.com [104.47.57.42]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3nhdtbvsqj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 07 Feb 2023 09:53:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EtHjSgFBXVrkrUgKXd6m+Cuv6JrmDxg8c8YaaxHlLdXTmzcfdORd9syBi0IGJOVUyubx9+4oGUgPiYWS5/L8JjCzPYdKiZIuXJyohtVTt46LbR9oMe0Tiv5/d6UO4X0pYJRaJL4aW9C5b6vwEhw+oUgSqjhdu4YQuGQlD0GZOAioIaNhNQIRos4n/fDiaZ+hXG87GigZ6QVrNj8UMXTBFedGTCbHL+iM/JlRPlGX8H7H6ordeY8Mxp8rkeKTRLhARa3N4OzGxuUK9sEoavLVsmnQtD71qM9PfsYsP889U4ivBeX3C3hUGkQl+U5woqNHHr8AIrz68UcdwHNDyyVrUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rtWvAyilyVLk5S0FO38Wxkp/L0H9XFKIij8+mPe3qRo=; b=hTW76aVnpUVtptzAeBMN5zczlTJEdstEOcvRQRkOvw+uvVq8C51nY6//ajF9/OCOtg9M5XJMEuGaN2PF1IM5hLP1wBUqSyRqBkAJ4oSjjoNVC8f/gHxSnaYjQA8KyYk2E9cyd/xyDrLZ+Ntrei317Zq8es7Sd99FpnQ2/ki3guHuuKuB9FYpflXS16jPzQ2CgxO86VjcTvudOOiz83XRiYbEavVLNGWUySFi0eAb+MoVBqm6gOySI7iVqQyGwbu9l1ZYnAcphjq2RGkkhRjNqwxErebV/oEPm2UaTBOoZyKBhTS4D6Y+qzkdOOWJeBXlRgXUCxE9pHY8NVc+xFjsgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rtWvAyilyVLk5S0FO38Wxkp/L0H9XFKIij8+mPe3qRo=; b=ojksFE9GqEMp/k/IiCBjPJOIm7JFinjfjCxpYVNj9eteAercHEapTsBI2YKYF9eFf6jJTBVbB9JOSie8ehPALv3lRHY/bvO3LpykD2pdk8mgOTKPhr7v7FiFPZ0A0ctdtH/2EoNnfC25J+IHuB+Sq24vojsRCTYoYL58kkUxdTM= Received: from BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) by PH0PR10MB4744.namprd10.prod.outlook.com (2603:10b6:510:3c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.15; Tue, 7 Feb 2023 09:53:54 +0000 Received: from BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::2b7a:b98b:e12:b750]) by BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::2b7a:b98b:e12:b750%7]) with mapi id 15.20.6064.022; Tue, 7 Feb 2023 09:53:54 +0000 References: <20221202175225.2780-1-cupertino.miranda@oracle.com> <20221202175225.2780-3-cupertino.miranda@oracle.com> <795fde7f-5bde-d1a5-e790-b15774effd1c@gmail.com> <875yen5ib4.fsf@oracle.com> <87h6wg15np.fsf@oracle.com> <87v8knax2p.fsf@oracle.com> User-agent: mu4e 1.4.15; emacs 28.1 From: Cupertino Miranda To: Jeff Law Cc: Cupertino Miranda , jose.marchesi@oracle.com, gcc-patches@gcc.gnu.org Subject: Re: [PING] Re: [PATCH 2/2] Corrected pr25521.c target matching. In-reply-to: <87v8knax2p.fsf@oracle.com> Date: Tue, 07 Feb 2023 09:53:48 +0000 Message-ID: <87wn4tajir.fsf@oracle.com> Content-Type: text/plain X-ClientProxiedBy: LNXP265CA0030.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5c::18) To BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR1001MB2340:EE_|PH0PR10MB4744:EE_ X-MS-Office365-Filtering-Correlation-Id: 532afa59-fb26-4697-c276-08db08f13908 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QKrLJjmFVZA+dg3QbDZiEafBjvNFMgU6P3Nclg7ggXW0YWNCoLglYAN6S4c7xBASqmoLDeDW/GQ+fxqMbZXi2qLuQb4zkqCsWRj8v9nLhpMmrIICCk33Dto/vBA4OeuTFj3RX1inWcgccyiqYVV+tUjMlC3bVOubw18eGuMzS0BGz7Zo9Xd+prfCTlR/ILnStNPJB2WRZ0lCMv+wUKqn25S6mP0xHG9P7gjt5YBTlTtPNM1iRk4mGZPRrsKOqsppjQ7tw9rgfsJ5Q8vri8iaGgTQ/DXaWCOpxlFwF9m9NVDMFVud7kR9EQFTIkH/sygxV5nqvZ24ueWh02DEkhHlNG5h/j6i0wH3SN0hHPNSB34Ct2eq/gTbfRzMVQ6D6FbFHTpS/9i/FGXc5aXWKfnsW03PaEOaXQOq9m4d2Nf1eMmCMI4YhLQ248X/4yvRpZJvExNxt+rNbW7OQTgQjghAieaizWIPWrMbuYeLJL9D2c4MSesMVfFifR1aklgLYR1u7OQNpdjAnns94O7+pfooe7t1iFJFKTdWPymPaL9cv+gzZIJNsEkZd4HwLGJb9b0EDrF09J5KAsBpWf++5350LkOmwtOjVZwmjykXLCWyUL+TxqjIxaXd0HXS2KD+caF28/zWhhVsa2RON7aY35Nx0w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1001MB2340.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(346002)(366004)(136003)(39860400002)(396003)(451199018)(316002)(186003)(86362001)(6512007)(36756003)(44832011)(4326008)(8676002)(5660300002)(66946007)(41300700001)(6916009)(2616005)(478600001)(66476007)(66556008)(6666004)(6486002)(6506007)(53546011)(8936002)(2906002)(38100700002)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?H1PcqKGGlCys9sJu6wOCoosyHXXwhcDJ5xNAW8B+08bxwgC0C3FkSxtOTVLt?= =?us-ascii?Q?JObJU6eNFq1t92LeBDXQ/9UZxjwn2HjtpzqixdvHI0DtyNWWrfeGkw/qapvM?= =?us-ascii?Q?wObdL31x1YyR7in9ri1hCIJnYyahmfMA5I9NJLmBcD9/4mR39HsnPDHLEHH4?= =?us-ascii?Q?y43g8sd1sN6BEs6GK9YTBwko7nwVSMwiHna5DvUDKA7tYlIJ6kxEP3oQoyCD?= =?us-ascii?Q?fFZUIbKskyNU2ECCW6Iu8E5MZmvwgY2G7zeiVAD6g0hIGOdY8Farq5sB6u/4?= =?us-ascii?Q?mqW6c05ngk8rwl2ihiFtmXDOUpVjCAgBWTDfBIrhHG4q3krO6TCKkoCXGj6d?= =?us-ascii?Q?hfd8wWfoFRFmOva0s/4yywQ31yRv87sYffroErcrANoVhTp9wiU15eYt9haO?= =?us-ascii?Q?wCzd0+9B2PiYCz6w44EUGVrB7y9DucOpngXfRWjfnnDq1t/mddoPMQgvTDEG?= =?us-ascii?Q?YfIvgY08Aeg0ToSqYmVPlPHqFDmAZCsA31IhxbCJbcesiyEir2nbDDpGWZQq?= =?us-ascii?Q?iq0QHkuwGRNyBNKJuZ3sCkvquhewL+d+npdT66vW0/99vYIiYlpMWVXCce6r?= =?us-ascii?Q?Uu1Z0sKEU5Z48A+9lMOdLDDvPaH3SHIYSHSZ7qLHTlDcnhZG066mi39zUKcr?= =?us-ascii?Q?ltsgWDgzrm57Xq4uO2RytBLHvu0OpHnoji8BZx4zbWaC6K0qII07AM+tmE1Y?= =?us-ascii?Q?RE5eKojwiCpr3VMWp+lkVN3AR6yDaQf7ZieKF9HX6+LrtFffAtiMKGQEvsN5?= =?us-ascii?Q?zvEoC7igSbCbauEGZUzAOxTjMnG7ddonSYagHNegA94hWEQeRGv+jySqNzBr?= =?us-ascii?Q?PkGJ7pc42WDNE1tP8yamc0AgmOowcJWsSTKKpZ14n0U3rVZTbzkYjnIYpwr8?= =?us-ascii?Q?imQIS3TK3jYA/eFZq37rng7Q56lGjSGLJktltm5PfCKaaT9jr7vkMh8hgFIm?= =?us-ascii?Q?wBWJieXE9zBRXRk1JRu6xjQ31u3k53QyUsGZj8CWCM+OmZlsF8CqBwZl71rk?= =?us-ascii?Q?qsf9zSEvEaMcUqD+Cl9G57lEA49FM/oHZY8Obx+CY5jXY7u/6SMCzi1GuIqV?= =?us-ascii?Q?EZHup/r9fS4QRSBKbW0VrF3xx3jiflXBfAVj3qlQCbmuyVdjg9QxevLwbFzp?= =?us-ascii?Q?aUZzFmDiWOfxB1mPbcNolho12l4wodhfoPOLjZQ8QZp9w/nYtKs4M1wuUgpw?= =?us-ascii?Q?ECU25LSpS8XOtHztOscOjwsgtUmzlNreX0UibWi1sWDscj3hlWP8yd+3RpPk?= =?us-ascii?Q?+3i/vVNU0XObM/sXdlVRsalp0FfeFpdXfj6haO6GH9GYg7CWeqPBTy9AxA4c?= =?us-ascii?Q?0r5dTgZF2PIyjhyvv1mFedlNEk07tUfFyJsda65frTMJ1rQAjnaXCo7Oucc6?= =?us-ascii?Q?BiR6UPl9065qMdYDdENtfaPoBoJoFmAaibmqp9kBle/5yATDk+XDp/Ycqm4z?= =?us-ascii?Q?3ICGapKoSgnhl0+8QKzGYCeaJjyGVfF4qIm0HoULDvHFCP4RI4EopPjRW8EW?= =?us-ascii?Q?ZSDzVSKnQqrBTiLcMS6XcgdOWW0cyQCsDMUh3CmVhsIf4h02ePXCc/FgSsmI?= =?us-ascii?Q?eVSdmi/cZZa2pxFc/SIwOPX1f0/Bg6eU3nXyM1w+0pXUe7A7Yq8/PGbXvQZ9?= =?us-ascii?Q?99rFhWsAV7eXRNXfjwKLTMvlTSpX61aJ7tAsVjMJZ2Wd?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ESnylS7W69318mfoWh0VgWyETX5VPAYWXZ97ssiph/50WvG1RGuKuiR5dlvsFh2On1B/R9ug0Sx/l2f2yfqghrS6oSCjs+sS5JTJUWBeN4koTiWjHxNx7VDsGuHkQf8c7/DgbhiL0s+z/48E33jA8Chz+tZ7gdB7T6892Nwx8FCApQ9weXmPY9zL8aUwqrtdRNNcM83hbcBzwhNRNLJAYdZY+194Xl4POWy7bvwjR6YH8XJQM10RlOq79/0YnY2brk0rZaGnMu3gztWxOssLMgXrFK2/1WeGAX4GvdWwLWOsWRr/ggKDw3rS7cH+qJWyfxVOWq9ZgSViAIAwS0FSI8vbDP3xwgfRB1NkqluS6uCRdWoPLjUnjcTlgGCTDUWgy3VvcQEKLmCZCHI2scD7rj70sAguzCHG8Z3/XjygOAq7QVxzmUy+15PVmXC71TJWosnkKtcKFNH/To/S/AJyEfQ9EHB3LL00U1/FmaXtgQNu1cEXU2+p7t/Tabg1IAtIi5lU2hTtC7BMY6JPCRwpWDR9TS2KpMGiyUjNRdsE/gRJOLBdiXNUJq4S8q+o20fMyPVoPcK/zPj8ufNOHiID5rsLiMXfFy0c2VXQdlOO6C7CPfyTt8e358QJY6TBFZSZuTUByc7FbFL1/USBkY0ghdCQK00AFMgWJTeBDdGnama0Rtr33tMywIUeM+XkQJ2XCqqR9bglsJNDsSmEH/Uwu7euCeNQjyZOs+xWGmlJjHORocM//rG92gIR8K866ieb1iap8HS4W4u0Xi0jFnhgPg== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 532afa59-fb26-4697-c276-08db08f13908 X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2340.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 09:53:54.3197 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Sr1bcjxOi3sb6adC9QFuWRYsBcKmU+NVMqpRIlsGUDLzjBKg64nBiFBcfGs42ncblPYOFSignU96XrWNkFnGoPT+MzuKdShSBNCXMV/RSDU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4744 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-02-07_02,2023-02-06_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 phishscore=0 suspectscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302070088 X-Proofpoint-GUID: 3vGjU_C-qdoXwuhqDa0NpUAojgXamNPo X-Proofpoint-ORIG-GUID: 3vGjU_C-qdoXwuhqDa0NpUAojgXamNPo X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jeff, Can you please confirm if the patch is Ok? Thanks, Cupertino > Cupertino Miranda via Gcc-patches writes: > >> Thank you for the comments and suggestions. >> I have changed the patch. >> >> Unfortunately in case of rx target I could not make >> scan-assembler-symbol-section to match. I believe it is because the >> .section and .global entries order is reversed in this target. >> >> Patch in inlined below. looking forward to your comments. >> >> Cupertino >> >> diff --git a/gcc/testsuite/gcc.dg/pr25521.c b/gcc/testsuite/gcc.dg/pr25521.c >> index 63363a03b9f..82b4cd88ec0 100644 >> --- a/gcc/testsuite/gcc.dg/pr25521.c >> +++ b/gcc/testsuite/gcc.dg/pr25521.c >> @@ -2,9 +2,10 @@ >> sections. >> >> { dg-require-effective-target elf } >> - { dg-do compile } */ >> + { dg-do compile } >> + { dg-skip-if "" { ! const_volatile_readonly_section } } */ >> >> const volatile int foo = 30; >> >> - >> -/* { dg-final { scan-assembler "\\.s\?rodata" } } */ >> +/* { dg-final { scan-assembler {.section C,} { target { rx-*-* } } } } */ >> +/* { dg-final { scan-assembler-symbol-section {^_?foo$} {^\.(const|s?rodata)} { target { ! "rx-*-*" } } } } */ >> diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp >> index c0694af2338..91aafd89909 100644 >> --- a/gcc/testsuite/lib/target-supports.exp >> +++ b/gcc/testsuite/lib/target-supports.exp >> @@ -12295,3 +12295,13 @@ proc check_is_prog_name_available { prog } { >> >> return 1 >> } >> + >> +# returns 1 if target does selects a readonly section for const volatile variables. >> +proc check_effective_target_const_volatile_readonly_section { } { >> + >> + if { [istarget powerpc-*-*] >> + || [check-flags { "" { powerpc64-*-* } { -m32 } }] } { >> + return 0 >> + } >> + return 1 >> +} >> >> >> Jeff Law writes: >> >>> On 12/7/22 08:45, Cupertino Miranda wrote: >>>> >>>>> On 12/2/22 10:52, Cupertino Miranda via Gcc-patches wrote: >>>>>> This commit is a follow up of bugzilla #107181. >>>>>> The commit /a0aafbc/ changed the default implementation of the >>>>>> SELECT_SECTION hook in order to match clang/llvm behaviour w.r.t the >>>>>> placement of `const volatile' objects. >>>>>> However, the following targets use target-specific selection functions >>>>>> and they choke on the testcase pr25521.c: >>>>>> *rx - target sets its const variables as '.section C,"a",@progbits'. >>>>> That's presumably a constant section. We should instead twiddle the test to >>>>> recognize that section. >>>> Although @progbits is indeed a constant section, I believe it is >>>> more interesting to detect if the `rx' starts selecting more >>>> standard sections instead of the current @progbits. >>>> That was the reason why I opted to XFAIL instead of PASSing it. >>>> Can I keep it as such ? >>> I'm not aware of any ongoing development for that port, so I would not let >>> concerns about the rx port changing behavior dominate how we approach this >>> problem. >>> >>> The rx port is using a different name for the section. That's valid thing to >>> do and to the extent we can, we should support that in the test rather than >>> (incorrectly IMHO) xfailing the test just becuase the name isn't what we >>> expected. >>> >>> To avoid over-eagerly matching, I would probably search for "C," I wouldn't do >>> that for the const or rodata sections as they often have a suffix like 1, 2, 4, >>> 8 for different sized rodata sections. >>> >>> PPC32 is explicitly doing something different and placing those objects into an >>> RW section. So for PPC32 it makes more sense to skip the test rather than xfail >>> it. >>> >>> Jeff