From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id 1A0793858289 for ; Tue, 31 Jan 2023 13:16:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1A0793858289 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x32e.google.com with SMTP id bg26so4467875wmb.0 for ; Tue, 31 Jan 2023 05:16:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=lk3jJiQmSnVCgA6RNCT3DSQbmCU0nNpzY1yvC3tuUlw=; b=CPId3OTQmPhLHgwJIHZClLlDOdaEc9BHyTNWcg1W80u6GOa0gUuY9HT3OgnQ7MIjeF TTg+nVgsgFVKSZF93ckeRRz/RUJeEhEhwtVeFOUoX4cKW7GSacNs30lELaJqc7aAF8e3 TBSs/KR8UV430zVc+aKUkLDkmo+oAAIWLoHZiPtkfG7h/08Tfnd9682eSPHloZZD3i9q jgXn4Kpo7UPOFVCWj165C+U4HbbOaBrgprucWjMz2GLjtUPPYqt3qPOM8F9PynT8vUjC pqodBkpXdWtMDI2WZog5CfmMzOoplHX8V3gExzgfmOJ7/6fSY+kDxKJ2sF2RWIAUY3B5 oUMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lk3jJiQmSnVCgA6RNCT3DSQbmCU0nNpzY1yvC3tuUlw=; b=hS5Dar5dIWeYYnuqMiWylFvNnEzjTPZjXimixGC6vtdEOnKqtmLklvObzbKaFVggn+ 04yKtjjk8M1bTEN8G/w6i6XE39k/bg3l68Kf/PunAVMu9Ntl8QR8bPAL2tToKRAio32m rcD4NA4iLRsYsD7XxHzCwroSQOktiPmywlEfIogT05shJmJ+h6+gHb/NJf348SWL4ioT VoHeLyKzeqsCXwiGeLpvN8VJ/cAiTzec2Qhm5Vgpfy9FqTTJkmR7fTYL8D1DMMu4uapU fIx/lqt3t/TdhUlWv2L4OqXWMtU5VpWlPRDXiycfkyjtdl1ln72Sm5xJv58qF9yTta2H 6+0A== X-Gm-Message-State: AFqh2kqnII4uJ6Dw86wj4BhUdHQTAIws69QRysB7N9QnZJyzvhYn54Rd +N6d6VOcd9zkj/BXtvfeqAg= X-Google-Smtp-Source: AMrXdXtB+4zfhGeZqaEN6LNFAGxP+vAOOPV76jClolt35+GwZfnd0ysAa10sMciS43Qrp61XcftaGQ== X-Received: by 2002:a05:600c:5405:b0:3d3:5709:68e8 with SMTP id he5-20020a05600c540500b003d3570968e8mr52230662wmb.36.1675170975814; Tue, 31 Jan 2023 05:16:15 -0800 (PST) Received: from lancelot ([195.147.220.46]) by smtp.gmail.com with ESMTPSA id bh6-20020a05600c3d0600b003daffc2ecdesm19408697wmb.13.2023.01.31.05.16.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Jan 2023 05:16:15 -0800 (PST) Received: from gaius by lancelot with local (Exim 4.94.2) (envelope-from ) id 1pMqUU-00H5Kj-Ax; Tue, 31 Jan 2023 13:16:02 +0000 From: Gaius Mulley To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] modula2/108462 - duplicate install of static modula2 target libs References: Date: Tue, 31 Jan 2023 13:16:02 +0000 In-Reply-To: (Richard Biener's message of "Tue, 31 Jan 2023 10:46:58 +0000 (UTC)") Message-ID: <87wn52etf1.fsf@debian> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Richard Biener writes: > On Mon, 23 Jan 2023, Richard Biener wrote: > >> The following addresses the fact that libgm2 installs static libraries >> into two places, one performed by >> >> toolexeclib_LTLIBRARIES = libm2cor.la >> >> and one performed as part of the install-data-local rule to a >> m2/m2cor subdirectory alongside Modula-2 .def and .mod files. >> >> This patch opts to keep the copy installed by libtool and removes >> the extra installs in the install-data-local rules. >> >> I've built and installed both with and without >> --enable-version-specific-runtime-libs and compiled and linked >> a Modula-2 testcase with the installed compiler with the two >> multilibs and with and without static successfully. >> >> OK for trunk? > > Ping. yes sure, LGTM A heads up that I've just renamed the gcc/m2/gm2-libs-pim directory to gcc/m2/gm2-libs-log for consistency. I've just tried the patch (post rename changes) and the patch builds and installs fine (non bootstrap test build though), regards, Gaius