From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id DAC5F3854830 for ; Fri, 13 Jan 2023 15:06:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DAC5F3854830 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30DDV95n025771; Fri, 13 Jan 2023 15:06:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=references : from : to : cc : subject : in-reply-to : date : message-id : content-type : mime-version; s=corp-2022-7-12; bh=5Iqr71mgpP4KxQ0E9bF0Ie+Wm2r4dP4qG0xtGk9YFRw=; b=hOntF535Ranh8C03PnuFbbzhoSI53dnTCu+Yo02xRxWMKFL790kjlNHhvQUZMDhvHU88 EsxkpHxQq3SBtECazwOEiGShPLQbdZ90O06aUqEEgisWQgbHZX+wTBnt2zfLqXz6yVNg h7HBxy8WLFnFx8YrTpNOViwJa0Qlsr4FZRopwKbCx3OqhYwvbM0T/lwkA8PtaD10EK7G I+WWC6LrCAvLA+Ryll29423Z7S0ikPu3TsbSGsG55Fto17Burz/K5GOYaK43rfYoq8VQ 1ehshUrkC8HearLY7fKR5llZJpga+CYua7qtn21/vIA4+ePDFJOX2elW1MRgOYo63JpF ag== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3my0btvxam-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 13 Jan 2023 15:06:50 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 30DDb0rK008291; Fri, 13 Jan 2023 15:06:50 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2169.outbound.protection.outlook.com [104.47.58.169]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3n1k4s9m1m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 13 Jan 2023 15:06:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gpfUP/0aX9s15OYo3CYZ4kexneqi1rGdQP0Qgpyox+Y4EC8QVJ+F5hxS8tl2x1CqKgAduV0ZPp1WIk9E3xzl8ylK1pPJLmwhIJzSuqID9WD+ySeg7Han2BXauA27ZuTydsfni2PakG/wlQmwrr0UWi/GBkjQbgzlE2X2YuwBdSFoFnCtgZqJSHn6tEJG06J9EnZP7CzXYxUAJT09X0SJnIYJLK5GjegZk8e1NNdysGEvXt/SgVmX4XPiG7WrFUIzhrWsxiHDWOmRkRknYf+eq+cB6JkZe6RU6y0Wgl+w7j567TNefl5so12VAKGExl1ntUOUdI+t9iqxjE5MIl8bVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5Iqr71mgpP4KxQ0E9bF0Ie+Wm2r4dP4qG0xtGk9YFRw=; b=JSEFif6rJpYjsqy1ZmmrNesow09EqEXPAOzglyvyrPIvU/MLjL2lyXSy8icMl6eHHdV15qmaWNn+CYjDXnVgF/L+NgjUCHcrqe4+8NHfCVh3CgOg6ZG1o38I0yGAa8LbXygf+5DXSFilo3WlTC+xHvw50JSfjpodKo66flzBWO5w065R6fc1LATBAHvyg+AMZBQJbXkF2je8SEBpV37scIrm6XhTa+r9MCPWIoHtrO1CCSymARvDrmR29uxMLdm1d6np9fINqqvA75u3+3hN6TXZREvLXCzDrr3qcGC2e67XSKQZ401+I5gjZ5fIamhHfXPHw7y6dwXkiV93xE0MOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Iqr71mgpP4KxQ0E9bF0Ie+Wm2r4dP4qG0xtGk9YFRw=; b=Yt/bmhXQHsHlBuoaKzt1VO60kLMJVSA69qSv2R39dR0D1DEQAN+TvztIt8MT71GEZpb46H19USTsN9RRhIghhgRMIqpNVf3rVvP6LjX34vtN+Id+OZNg6MrGLYhDDe//2HOarBl+lrIQT4niPkELmPntB2NHtFXJqwCJGBiSlG0= Received: from BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) by PH8PR10MB6314.namprd10.prod.outlook.com (2603:10b6:510:1cd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.12; Fri, 13 Jan 2023 15:06:48 +0000 Received: from BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::2b7a:b98b:e12:b750]) by BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::2b7a:b98b:e12:b750%7]) with mapi id 15.20.6002.012; Fri, 13 Jan 2023 15:06:48 +0000 References: <20221202175225.2780-1-cupertino.miranda@oracle.com> <20221202175225.2780-2-cupertino.miranda@oracle.com> User-agent: mu4e 1.4.15; emacs 28.1 From: Cupertino Miranda To: Richard Biener Cc: Jeff Law , gcc-patches@gcc.gnu.org, jose.marchesi@oracle.com Subject: Re: [PATCH 1/2] select .rodata for const volatile variables. In-reply-to: Date: Fri, 13 Jan 2023 15:06:42 +0000 Message-ID: <87wn5qzd6l.fsf@oracle.com> Content-Type: text/plain X-ClientProxiedBy: AM3PR07CA0131.eurprd07.prod.outlook.com (2603:10a6:207:8::17) To BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR1001MB2340:EE_|PH8PR10MB6314:EE_ X-MS-Office365-Filtering-Correlation-Id: 23614951-04a9-4746-0fe2-08daf577ca8a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3oQldfPwHg4VCV+AxjvAxuNu2z2r5+Lm+ymMpw3owmmcaU6mzbUVm3LM0TI+FjsOI5fV0sNcJa+tsWxreL1mTV9vcAeMjSb5FWeOhHeZV0meUL6oqeDu2kL6ryh77jrXd0nWrq9IKKU79C9XPwTxB5L1fxHCw5tRPxwt/Ay8JSNd5/tcm3iZBVm5qbVbPK//UFPcTrWvFqRuq65/TiTNfl7x1rKq/iaKdvkSBHfvMZzJtJ1n7SJ1b0Ii5Q5pAytH5Ga2xg9heK9Ag10crrlzKom1ZMFCKkKys/89ymjQPkcSRBMoMHpuhNQnUFr5liW1nsc5dPOuDtP36OW9VkPkWrr4CBrCHGohIpUyzYS0shpPNdvt7CjneYxlS1/eDhiRiwUEwsfjrhTNc844nQfJb4kQLjcnXM5gxImmdxOgokKKKuI0HzL/FN4dyDtjqm3Ap/PHU/TGPxkOlLBv6sg/V6LaU4OIKEditt0Zb6CWF344iwarR7gTdUkR9ZyNNU7BYld0yNvSchRi4fjDcFIAAthpJODsKTrPZ2aPBfcIOBVXBVckwU7IWjjfsX/klR4ug5vXoewlDxO3AZfuFGbdeicXUFZd9P+dVgM7nisHh7Z9J0ZFg7h0VYtxlhMy+kWALsyhOz0pwIl7QtYvrGlhqR1y4fKtoWrdpMdCnifiSdTtsqBPto3Hp8LpvwfELvzm X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1001MB2340.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(136003)(39860400002)(366004)(396003)(376002)(451199015)(2906002)(5660300002)(6486002)(4326008)(36756003)(86362001)(8936002)(66946007)(8676002)(66476007)(66556008)(6916009)(38100700002)(316002)(41300700001)(53546011)(6506007)(44832011)(83380400001)(2616005)(6666004)(6512007)(107886003)(478600001)(186003)(142923001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FPagiW40UbhAeqh3xgT6i4BHjmqAloMZEHzfuxFHeInchaoeQaAAoZkP3nsT?= =?us-ascii?Q?3czdVXwjCoq/YEph62AJyWq1Qitrx6YD0HD0298inyGrNEcjJHEvEnVa6CHL?= =?us-ascii?Q?pMjWvE8XqMGpnqVfmQcgd2Jo7FPR9XtEM8e8pQNLmQFve0yvHT76TXKt0/iB?= =?us-ascii?Q?A0OOkMj92/pN1JqS6TWaLbgeTggngrwlVip9rftWJGGVdAbbcnIQ6HTL3Y3c?= =?us-ascii?Q?+UOQ6p0db64gBF2OLQYq/Ox/ZvZVpt2hASvnLtUy40imSocXG2Yt2NIM1Wh7?= =?us-ascii?Q?vRokUDWpVkVbTwOmYhNE4n7e9QKMyrSXtqlE34jeMjPJCabVtH24Y1qNz+J9?= =?us-ascii?Q?1dVrwo0KoRbfFLLb01oz1/bSgWnIF+bDGsI4fg8hVRKINvrT9PgWeOLhsKT8?= =?us-ascii?Q?De3dp2qPcRnMi5KnlluM1cP17cFUKOIBrhhcja7VV18PszOEnvRzLVU3+DRU?= =?us-ascii?Q?2yd1mTxWZDSLM/11IKxtWU3JW0TL2VLZ6gKuKuujHkrKxLKHvNEoICb2J5xU?= =?us-ascii?Q?cMcdUYHPGA9Y95R/J5AgJ6kKiec+AeTUK0XGi3UnpL9Md+4AVAPVIl3Zcal1?= =?us-ascii?Q?aWGI6ourwFjwmB8GnrWJOkAo/TC9Ic1t4i0/Ui57lFrPtZbdBSSUWITYyPOv?= =?us-ascii?Q?1CJ0lsmq8s+DOJDaLMvJnofhRujzimdpd0FukY6GVjsfwQkGaC1IGq1sCEVr?= =?us-ascii?Q?AwUBMEvxECpav4fk9OfC1SFXBq3WqWyoo/2sr3KlY33lvr7G966jHrezlVp8?= =?us-ascii?Q?y8Bk9uKD8ETImUCNnDVNla+hdhlXQZ+AkillQI803eR9TdGDX9qSUaA7BV2Z?= =?us-ascii?Q?tmUpMK9OICe1r6LxWEbC/Y+ifJsAp27dAHdQtp+fgCsOTLKk4qq5sxcqgzE7?= =?us-ascii?Q?jdECntKrrr+HRBSb8BCtWwh1FvdPXWMFQu96ynumMb9VcYrBd1vcrUlnRhsT?= =?us-ascii?Q?05Rt9wc/R3qw5GoZNmtQWPTd2vFB/X6zPryBPWC3BvLJGAehmyYIdCIHQl1P?= =?us-ascii?Q?OH9HQg1Xo/fV0f+H+dkwdMVhVB0ysgn/SCzfxZJGBC5Ojb4aShRkrgfRhE5A?= =?us-ascii?Q?KfPoYozb24lNaAQcxUnqCNZYK6AAiLtUcR/QE/OLGG7fER8odYD53kKZFGRh?= =?us-ascii?Q?ahP+F42esVIlSew4EwfF4nvnuBd+doMSOf7fHYirfGDxfKpEG/KXRRq+8f1h?= =?us-ascii?Q?sT+SBnu33xq304NXPdHMSDDigYc+fNUKsb8D7DmZMQkdB0t/v3uEmMZD7BWd?= =?us-ascii?Q?WKRTIoLW9ZddP5vXiaN1T8BCMAJaIf1V1HnNIC5GRcsBNb9GM5eouAxpyfDk?= =?us-ascii?Q?xNoh/EoME0tmMk7dSGuuQTMP1jZ9juHLKnHLq9lteDzpuzykIGZsB/jO1Aos?= =?us-ascii?Q?YNQQiagz4pccWBOVwGNpt1je8lAei9Pa07gcK7uZ+X4MfiOFwZSPSRge5Yb5?= =?us-ascii?Q?en1FxocG9ZoAtCUOKL4EytNTU6lNky+l4XWg28sqrC9vpAB8yMnCPMK7ovXL?= =?us-ascii?Q?mI3sNL1rupx2QHzOXxdSvJbrZsdcdEe2geIsLrbUEN+JmF9sXZUNBhtyvFAU?= =?us-ascii?Q?YJk+XJCA77ygAGJAfPcm8ihoSGLC8zX9vZt8tUG86IZIV8o7qw2eHypEm7RF?= =?us-ascii?Q?XUOo50eh7BAam66CYxEpuPs=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: SOUmizqjClEsWvcIVTmCi76odEiX4vPgTfDOTgLDvTbRyON2+x+jQ8h+R3u8Q04pNncjKrdpY3u1Gct1vUEWgNrec1HP1j7FB62oZ1rMV3GyatX1m/e4zXWsHfeRbUAwD6+183p5KOLz36dEG07rILg6/UBQmE4EDSUFnv8ewwIBHCbW2ooLRuRS2bGcKbZRByJntPDmOXd1li39+EMdM4S4rXHVl7laVniLJRukArWyBGLqIMKAyPmafqNM8M7A9bHj6ub4Wyg5bMx/QjkmXl/+erkmWmaTOSq6Pr1GB9aErOPLHQOGLPBzWfLE7h5O84W1i/RcmnMjtbJVXPEPTHbSenlocWDoSvQNg4N0CEAnm0nHEkdWdaILHfmE2EqbdZf13w5wuBVuzIcsAXjk0JRwoeA1bD6ocSSurCPMBcmr30IkkQiYYrcPAUUiGYCMCUr6ru0Ll/Z2Mr3m7M2ssHWmkjvsKYqWsoi1KiuXD2GfysJAGuTtR5pX95gMok4cZR1NAG/i0BVPA4fLH4RjzCI1sCvz1LzeQ2a++cDOha+K/aDWN+2jTcET5hYkBg+KbdhX/q0mVjnA4ZOqOHvaC0F+MZFLv7Q+sKk2zyKkQlE2Fr1nmlxO3ZE3vA8b0brL7asvmQW9rUJaYhwQy0wtNqvRDzbcVPbFyuDMjDcfTLjAoWxN25aCd2buGoAyA/RjtRJd+ZPNpCs88chMxjQOMLzHZWynAhVtz/gpMKjNmvuNZ1/gG/ix8QDKEIqdXtW0e6GaPubpnjIiZQS/b+PEPw== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23614951-04a9-4746-0fe2-08daf577ca8a X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2340.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 15:06:48.1961 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6klb36QwmFA5X/aT4lXSZQ9bGzNl08AukS6imQ1Yv4vTGPFmTSt/CD2syrnEqqs9757BH7B23m/nRbQf5UzGOe4zQ7SnyiMNGJhx7x68jyQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6314 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-13_07,2023-01-13_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 adultscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301130099 X-Proofpoint-GUID: ske-_CMUpF_pqHbTAtFulqgUKA-Bra7A X-Proofpoint-ORIG-GUID: ske-_CMUpF_pqHbTAtFulqgUKA-Bra7A X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Richard Biener writes: > On Mon, Dec 5, 2022 at 7:07 PM Jeff Law via Gcc-patches > wrote: >> >> >> >> On 12/2/22 10:52, Cupertino Miranda via Gcc-patches wrote: >> > Changed target code to select .rodata section for 'const volatile' >> > defined variables. >> > This change is in the context of the bugzilla #170181. >> > >> > gcc/ChangeLog: >> > >> > v850.c(v850_select_section): Changed function. >> I'm not sure this is safe/correct. ISTM that you need to look at the >> underlying TREE_TYPE to check for const-volatile rather than >> TREE_SIDE_EFFECTS. > > Just to quote tree.h: > > /* In any expression, decl, or constant, nonzero means it has side effects or > reevaluation of the whole expression could produce a different value. > This is set if any subexpression is a function call, a side effect or a > reference to a volatile variable. In a ..._DECL, this is set only if the > declaration said `volatile'. This will never be set for a constant. */ > #define TREE_SIDE_EFFECTS(NODE) \ > (NON_TYPE_CHECK (NODE)->base.side_effects_flag) > > so if exp is a decl then that's the volatile check. > Thank you Richard for the review. Jeff: Can you please let me know if Richard comments reply to your concerns? Cupertino >> Of secondary importance is the ChangeLog. Just saying "Changed >> function" provides no real information. Something like this would be >> better: >> >> * config/v850/v850.c (v850_select_section): Put const volatile >> objects into read-only sections. >> >> >> Jeff >> >> >> >> >> > --- >> > gcc/config/v850/v850.cc | 1 - >> > 1 file changed, 1 deletion(-) >> > >> > diff --git a/gcc/config/v850/v850.cc b/gcc/config/v850/v850.cc >> > index c7d432990ab..e66893fede4 100644 >> > --- a/gcc/config/v850/v850.cc >> > +++ b/gcc/config/v850/v850.cc >> > @@ -2865,7 +2865,6 @@ v850_select_section (tree exp, >> > { >> > int is_const; >> > if (!TREE_READONLY (exp) >> > - || TREE_SIDE_EFFECTS (exp) >> > || !DECL_INITIAL (exp) >> > || (DECL_INITIAL (exp) != error_mark_node >> > && !TREE_CONSTANT (DECL_INITIAL (exp))))