From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128825 invoked by alias); 11 Dec 2018 15:52:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 128811 invoked by uid 89); 11 Dec 2018 15:52:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=4.5 required=5.0 tests=BAYES_20,BODY_8BITS,GARBLED_BODY,KAM_NUMSUBJECT,SPF_PASS autolearn=no version=3.3.2 spammy=8:=d0=bf, D*eu, sandiford, UD:pr52813.c?= X-HELO: foss.arm.com Received: from usa-sjc-mx-foss1.foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Dec 2018 15:52:21 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B97431596; Tue, 11 Dec 2018 07:52:19 -0800 (PST) Received: from localhost (unknown [10.32.99.101]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1C2F13F575; Tue, 11 Dec 2018 07:52:18 -0800 (PST) From: Richard Sandiford To: Dimitar Dimitrov Mail-Followup-To: Dimitar Dimitrov ,gcc-patches@gcc.gnu.org, richard.sandiford@arm.com Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] [RFC] PR target/52813 and target/11807 References: <20181209100856.14051-1-dimitar@dinux.eu> <87woohsk32.fsf@arm.com> <2807771.CbC4dySGB1@tpdeb> Date: Tue, 11 Dec 2018 15:52:00 -0000 In-Reply-To: <2807771.CbC4dySGB1@tpdeb> (Dimitar Dimitrov's message of "Mon, 10 Dec 2018 21:36:50 +0200") Message-ID: <87woog9i32.fsf@arm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2018-12/txt/msg00712.txt.bz2 Dimitar Dimitrov writes: > On =D0=BF=D0=BE=D0=BD=D0=B5=D0=B4=D0=B5=D0=BB=D0=BD=D0=B8=D0=BA, 10 =D0= =B4=D0=B5=D0=BA=D0=B5=D0=BC=D0=B2=D1=80=D0=B8 2018 =D0=B3. 11:21:53 EET Ric= hard Sandiford wrote: >> Dimitar Dimitrov writes: >> > I have tested this fix on x86_64 host, and found no regression in the C >> > and C++ testsuites. I'm marking this patch as RFC simply because I do= n't >> > have experience with other architectures, and I don't have a setup to >> > test all architectures supported by GCC. >> >=20 >> > gcc/ChangeLog: >> >=20 >> > 2018-12-07 Dimitar Dimitrov >> >=20 >> > * cfgexpand.c (asm_clobber_reg_is_valid): Also produce >> > error when stack pointer is clobbered. >> > (expand_asm_stmt): Refactor clobber check in separate function. >> >=20 >> > gcc/testsuite/ChangeLog: >> >=20 >> > 2018-12-07 Dimitar Dimitrov >> >=20 >> > * gcc.target/i386/pr52813.c: New test. >> >=20 >> > Signed-off-by: Dimitar Dimitrov >>=20 >> LGTM. Do you have a copyright assignment on file? 'Fraid this is >> probably big enough to need one. > Yes, I have copyright assignment. OK, great. I went ahead and applied the patch. Thanks, Richard