From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58773 invoked by alias); 10 Dec 2018 11:21:59 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 58764 invoked by uid 89); 10 Dec 2018 11:21:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,KAM_NUMSUBJECT,SPF_PASS autolearn=no version=3.3.2 spammy=D*eu, HTo:D*eu X-HELO: foss.arm.com Received: from usa-sjc-mx-foss1.foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Dec 2018 11:21:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EF8481596; Mon, 10 Dec 2018 03:21:55 -0800 (PST) Received: from localhost (unknown [10.32.99.101]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 50E633F6A8; Mon, 10 Dec 2018 03:21:55 -0800 (PST) From: Richard Sandiford To: Dimitar Dimitrov Mail-Followup-To: Dimitar Dimitrov ,gcc-patches@gcc.gnu.org, richard.sandiford@arm.com Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] [RFC] PR target/52813 and target/11807 References: <20181209100856.14051-1-dimitar@dinux.eu> Date: Mon, 10 Dec 2018 11:21:00 -0000 In-Reply-To: <20181209100856.14051-1-dimitar@dinux.eu> (Dimitar Dimitrov's message of "Sun, 9 Dec 2018 12:08:56 +0200") Message-ID: <87woohsk32.fsf@arm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-12/txt/msg00564.txt.bz2 Dimitar Dimitrov writes: > I have tested this fix on x86_64 host, and found no regression in the C > and C++ testsuites. I'm marking this patch as RFC simply because I don't > have experience with other architectures, and I don't have a setup to > test all architectures supported by GCC. > > gcc/ChangeLog: > > 2018-12-07 Dimitar Dimitrov > > * cfgexpand.c (asm_clobber_reg_is_valid): Also produce > error when stack pointer is clobbered. > (expand_asm_stmt): Refactor clobber check in separate function. > > gcc/testsuite/ChangeLog: > > 2018-12-07 Dimitar Dimitrov > > * gcc.target/i386/pr52813.c: New test. > > Signed-off-by: Dimitar Dimitrov LGTM. Do you have a copyright assignment on file? 'Fraid this is probably big enough to need one. Thanks, Richard