From: Richard Sandiford <richard.sandiford@arm.com>
To: Martin Sebor <msebor@gmail.com>
Cc: "Gcc Patch List" <gcc-patches@gcc.gnu.org>,
"Martin Liška" <mliska@suse.cz>
Subject: Re: [PATCH/coding style] clarify pointers and operators
Date: Wed, 05 Dec 2018 10:05:00 -0000 [thread overview]
Message-ID: <87wooo5lx3.fsf@arm.com> (raw)
In-Reply-To: <6bce0b3a-0b0d-f03f-5f92-e00156e63629@gmail.com> (Martin Sebor's message of "Mon, 26 Nov 2018 10:59:47 -0700")
Thanks for doing this,
Martin Sebor <msebor@gmail.com> writes:
> Martin suggested we update the Coding Conventions to describe
> the expected style for function declarations with a pointer
> return types, and for overloaded operators. Below is the patch.
>
> As an aside, regarding the space convention in casts: a crude
> grep search yields about 10,000 instances of the "(type)x" kinds
> of casts in GCC sources and 40,000 of the preferred "(type) x"
> style with the space. That's a consistency of only 80%. Is
> it worth documenting a preference for a convention that's so
> inconsistently followed?
Just to be sure, does that grep include things like the go frontend
and its GCC interface, which deliberately don't follow GNU conventions?
A crude grep for me gives 92% consistency in gcc/* itself (excluding
subdirectories), although that's still disappointingly low...
Thanks,
Richard
next prev parent reply other threads:[~2018-12-05 10:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 17:59 Martin Sebor
2018-11-26 20:41 ` Jeff Law
2018-11-27 18:46 ` Segher Boessenkool
2018-11-27 22:44 ` Jeff Law
2018-11-27 12:50 ` Martin Liška
2018-11-27 12:58 ` Jakub Jelinek
2018-11-27 16:11 ` Martin Sebor
2018-11-28 5:20 ` Sandra Loosemore
2018-11-28 23:40 ` Martin Sebor
2018-12-05 10:05 ` Richard Sandiford [this message]
2018-12-05 17:37 ` Segher Boessenkool
2018-12-05 18:03 ` Segher Boessenkool
2018-12-05 18:04 ` Martin Sebor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wooo5lx3.fsf@arm.com \
--to=richard.sandiford@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
--cc=msebor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).