Re: [00/77] Add wrapper classes for machine_modes

[Richard Sandiford <richard.sandiford@linaro.org>]

Jakub Jelinek <jakub@redhat.com> writes:
> On Sun, Sep 03, 2017 at 09:18:33PM +0100, Richard Sandiford wrote:
>> Gerald Pfeifer <gerald@pfeifer.com> writes:
>> > Hi Richard,
>> >
>> > I'm afraid your patchset has broken bootstrap on i686-unknown-freebsd10.3,
>> > in fact, it appears on FreeBSD in general (amd64-unknown-freebsd11 as well):
>> 
>> This sounds like the same as PR82045.  Could you try the patch I posted
>> here: https://gcc.gnu.org/ml/gcc-patches/2017-09/msg00062.html ?
>
> Richard, could you please next time commit such a huge series of patches
> that has not been tested separately as one commit (or test the patches also
> individually)?  It is sometimes fine for patch review if the granularity is
> smaller, but e.g. for bisection having long ranges of commits that don't
> build/bootstrap at all is highly undesirable.  That seems to be at least on
> x86_64-linux the case of r251470 to r251503 inclusive.
>
> Thanks

Yeah, sorry about that.  I had tested the original series as separate
patches, but messed up when making a final tweak in the switch to using
"require ()".

I'd wanted to commit them separately precisely so that a bisect would
identify a particular patch (this did help for PR82045).  But obviously
the mistake in expmed.c meant that quite a few revisions are duds.

Thanks,
Richard