From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21329 invoked by alias); 5 Sep 2017 10:17:13 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 21320 invoked by uid 89); 5 Sep 2017 10:17:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,MISSING_HEADERS,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-wm0-f47.google.com Received: from mail-wm0-f47.google.com (HELO mail-wm0-f47.google.com) (74.125.82.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Sep 2017 10:17:07 +0000 Received: by mail-wm0-f47.google.com with SMTP id i145so17005140wmf.1 for ; Tue, 05 Sep 2017 03:17:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mail-followup-to:from:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=3WiWDmyPMWVMEz0hMndcMlKYeZd9t5T9R9p9386iGZM=; b=pxDmc9hfTJ1XQ0xnrcvgCLNomNerL+h0H44k9N4H6dS9nwLTMcg2QDIUDqsbA18WDT RFw0u8O0fDwpx+Z1BoBuqtRHv/++TgvKE411pALq4FKqTYD5yE2e2yKSvo1OIcYQs6Cv JBCZPvr+dG3LvKSwPWmYOj0/mQKxQH3pWWOaLsHWI4dXSkLs7R9JMEexn0507ibRAsE5 ek9Bb91/CHuTED1j4EYgLjSXsjjQ3GjQ4vQob9UYTLKCB0UUPP85BbUPoZVu0ZSBETLY eX6iTRZM6QonYaKv+LDjN7GLRdm6Dnw9TWK2rud3dE6AWRJaLzqgQBvj6R2YDFrY4Bqh 81ng== X-Gm-Message-State: AHPjjUhvJMLbk+9MPh00k92GQ1g2oss3zVCbF6yqm4mFkD/+3LTg5IJC gCx0J+gBf7kszH4wrSkVZQ== X-Google-Smtp-Source: ADKCNb5Gh9Rpf7IJI6/IOOs/SB1MmYhWMysiMb0/Lzc2Lyl/s3VjNU7g7O+Ww3kiMVk55xXdTmYz3A== X-Received: by 10.28.51.133 with SMTP id z127mr1942055wmz.110.1504606624506; Tue, 05 Sep 2017 03:17:04 -0700 (PDT) Received: from localhost ([95.145.139.63]) by smtp.gmail.com with ESMTPSA id g15sm181271wrb.83.2017.09.05.03.17.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Sep 2017 03:17:03 -0700 (PDT) Mail-Followup-To: ,Gerald Pfeifer , gcc-patches@gcc.gnu.org, richard.sandiford@linaro.org From: Richard Sandiford Cc: Gerald Pfeifer , gcc-patches@gcc.gnu.org Subject: Re: [00/77] Add wrapper classes for machine_modes References: <877exf8rja.fsf@linaro.org> <20170905095317.GD2323@tucnak> >To: Jakub Jelinek Date: Tue, 05 Sep 2017 10:17:00 -0000 In-Reply-To: <20170905095317.GD2323@tucnak> (Jakub Jelinek's message of "Tue, 5 Sep 2017 11:53:17 +0200") Message-ID: <87wp5dzbz9.fsf@linaro.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2017-09/txt/msg00236.txt.bz2 Jakub Jelinek writes: > On Sun, Sep 03, 2017 at 09:18:33PM +0100, Richard Sandiford wrote: >> Gerald Pfeifer writes: >> > Hi Richard, >> > >> > I'm afraid your patchset has broken bootstrap on i686-unknown-freebsd10.3, >> > in fact, it appears on FreeBSD in general (amd64-unknown-freebsd11 as well): >> >> This sounds like the same as PR82045. Could you try the patch I posted >> here: https://gcc.gnu.org/ml/gcc-patches/2017-09/msg00062.html ? > > Richard, could you please next time commit such a huge series of patches > that has not been tested separately as one commit (or test the patches also > individually)? It is sometimes fine for patch review if the granularity is > smaller, but e.g. for bisection having long ranges of commits that don't > build/bootstrap at all is highly undesirable. That seems to be at least on > x86_64-linux the case of r251470 to r251503 inclusive. > > Thanks Yeah, sorry about that. I had tested the original series as separate patches, but messed up when making a final tweak in the switch to using "require ()". I'd wanted to commit them separately precisely so that a bisect would identify a particular patch (this did help for PR82045). But obviously the mistake in expmed.c meant that quite a few revisions are duds. Thanks, Richard