public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Sandiford <richard.sandiford@arm.com>
To: Bernd Schmidt <bschmidt@redhat.com>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: [PR68432 04/22] Remove global which_alternative
Date: Wed, 25 Nov 2015 16:50:00 -0000	[thread overview]
Message-ID: <87wpt6do9j.fsf@e105548-lin.cambridge.arm.com> (raw)
In-Reply-To: <5655E1D9.9010709@redhat.com> (Bernd Schmidt's message of "Wed,	25 Nov 2015 17:29:13 +0100")

Bernd Schmidt <bschmidt@redhat.com> writes:
> On 11/25/2015 05:19 PM, Richard Sandiford wrote:
>> I guess not, but without it we have both local and global variables
>> called which_alternative.
>
> So call the local ones something else (alt_to_check, requested_alt or 
> attr_alt)?

Well, having two names for the same concept seems just as bad.
Especially since the traditional which_alternative will still
be defined and accessible.

We could have another #define hack to insert a _Pragma("GCC error ...")
if which_alternative is used in new-style attributes, but that's only
going to avoid some of the problems.

I don't think we should spend too much effort finding a reason not
to fix this...

Thanks,
Richard

  reply	other threads:[~2015-11-25 16:42 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25 12:22 [PR68432 00/26] Handle size/speed choices for internal functions Richard Sandiford
2015-11-25 12:23 ` [PR68432 01/22][ARM] Remove operand dependency from "type" attribute Richard Sandiford
2015-11-25 13:55   ` Bernd Schmidt
2015-11-25 14:11     ` Yvan Roux
2015-11-25 12:24 ` [PR68432 02/22][ARM] Remove operand dependency from use_literal_pool Richard Sandiford
2015-11-25 12:26 ` [PR68432 03/22][NDS32] Remove "length" dependency from "enabled" attribute Richard Sandiford
2015-11-25 12:28 ` [PR68432 04/22] Remove global which_alternative Richard Sandiford
2015-11-25 16:09   ` Bernd Schmidt
2015-11-25 16:21     ` Richard Sandiford
2015-11-25 16:42       ` Bernd Schmidt
2015-11-25 16:50         ` Richard Sandiford [this message]
2015-11-25 12:29 ` [PR68432 06/22] Use code,alternative attributes for aarch64 Richard Sandiford
2015-11-25 12:29 ` [PR68432 05/22] Add support attributes that operate on insn codes Richard Sandiford
2015-11-25 12:30 ` [PR68432 10/22] Use code,alternative attributes for avr Richard Sandiford
2015-11-25 12:30 ` [PR68432 07/22] Use code,alternative attributes for alpha Richard Sandiford
2015-11-25 12:31 ` [PR68432 08/22] Use code,alternative attributes for arc Richard Sandiford
2015-11-25 12:31 ` [PR68432 11/22] Use code,alternative attributes for c6x Richard Sandiford
2015-11-25 12:31 ` [PR68432 12/22] Use code,alternative attributes for i386 Richard Sandiford
2015-11-25 12:31 ` [PR68432 09/22] Use code,alternative attributes for arm Richard Sandiford
2015-11-25 12:32 ` [PR68432 15/22] Use code,alternative attributes for mn10300 Richard Sandiford
2015-11-25 12:32 ` [PR68432 13/22] Use code,alternative attributes for m68k Richard Sandiford
2015-11-25 12:32 ` [PR68432 14/22] Use code,alternative attributes for mips Richard Sandiford
2015-11-25 12:33 ` [PR68432 16/22] Use code,alternative attributes for nds32 Richard Sandiford
2015-11-25 12:33 ` [PR68432 17/22] Use code,alternative attributes for s390 Richard Sandiford
2015-11-25 12:34 ` [PR68432 18/22] Use code,alternative attributes for sparc Richard Sandiford
2015-11-25 12:35 ` [PR68432 19/22] Use code,alternative for bool_attrs Richard Sandiford
2015-11-25 12:36 ` [PR68432 20/22] Record attributes for define_expand Richard Sandiford
2015-11-25 15:55   ` Bernd Schmidt
2015-11-25 16:09     ` Richard Sandiford
2015-11-26 14:29       ` Bernd Schmidt
2015-11-25 12:37 ` [PR68432 21/22] Pass optimization type to direct_internal_fn_supported_p Richard Sandiford
2015-11-25 12:38 ` [PR68432 22/22] Use preferred_for_size in i386 internal fn optabs Richard Sandiford
2015-11-25 12:51 ` [PR68432 00/26] Handle size/speed choices for internal functions Richard Biener
2015-11-25 13:47   ` Richard Sandiford
2015-11-26 14:21 ` Bernd Schmidt
2015-11-26 15:43   ` Richard Sandiford
2015-11-26 16:10     ` Bernd Schmidt
2015-11-26 16:26       ` Richard Sandiford
2015-11-26 16:45         ` Bernd Schmidt
2015-11-26 17:10           ` Richard Sandiford
2015-12-01 11:54         ` Bernd Schmidt
2015-12-01 12:17           ` Richard Biener
2015-12-01 12:21             ` Bernd Schmidt
2015-12-01 13:43           ` Richard Sandiford
2015-12-01 13:59             ` Bernd Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpt6do9j.fsf@e105548-lin.cambridge.arm.com \
    --to=richard.sandiford@arm.com \
    --cc=bschmidt@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).