From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40165 invoked by alias); 25 Nov 2015 16:42:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 40155 invoked by uid 89); 25 Nov 2015 16:42:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Nov 2015 16:42:21 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-4-xwW_LJXcRb2nHQzb4yoYng-1; Wed, 25 Nov 2015 16:42:16 +0000 Received: from localhost ([10.1.2.79]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 25 Nov 2015 16:42:16 +0000 From: Richard Sandiford To: Bernd Schmidt Mail-Followup-To: Bernd Schmidt ,, richard.sandiford@arm.com Cc: Subject: Re: [PR68432 04/22] Remove global which_alternative References: <874mgajmo9.fsf@e105548-lin.cambridge.arm.com> <87k2p6i7tr.fsf@e105548-lin.cambridge.arm.com> <5655DC6E.2050700@redhat.com> <871tbef3vw.fsf@e105548-lin.cambridge.arm.com> <5655E1D9.9010709@redhat.com> Date: Wed, 25 Nov 2015 16:50:00 -0000 In-Reply-To: <5655E1D9.9010709@redhat.com> (Bernd Schmidt's message of "Wed, 25 Nov 2015 17:29:13 +0100") Message-ID: <87wpt6do9j.fsf@e105548-lin.cambridge.arm.com> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-MC-Unique: xwW_LJXcRb2nHQzb4yoYng-1 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2015-11/txt/msg03116.txt.bz2 Bernd Schmidt writes: > On 11/25/2015 05:19 PM, Richard Sandiford wrote: >> I guess not, but without it we have both local and global variables >> called which_alternative. > > So call the local ones something else (alt_to_check, requested_alt or=20 > attr_alt)? Well, having two names for the same concept seems just as bad. Especially since the traditional which_alternative will still be defined and accessible. We could have another #define hack to insert a _Pragma("GCC error ...") if which_alternative is used in new-style attributes, but that's only going to avoid some of the problems. I don't think we should spend too much effort finding a reason not to fix this... Thanks, Richard