From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31534 invoked by alias); 6 Mar 2013 16:12:37 -0000 Received: (qmail 31519 invoked by uid 22791); 6 Mar 2013 16:12:34 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Mar 2013 16:12:30 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r26GCTdW012800 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 6 Mar 2013 11:12:29 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r26GCSJC019656 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 6 Mar 2013 11:12:29 -0500 From: Tom Tromey To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix libcpp memory leak (PR middle-end/56461) References: <20130228201235.GY12913@tucnak.redhat.com> Date: Wed, 06 Mar 2013 16:12:00 -0000 In-Reply-To: <20130228201235.GY12913@tucnak.redhat.com> (Jakub Jelinek's message of "Thu, 28 Feb 2013 21:12:35 +0100") Message-ID: <87wqtko6c3.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-03/txt/msg00250.txt.bz2 >>>>> "Jakub" == Jakub Jelinek writes: Jakub> 2013-02-28 Jakub Jelinek Jakub> PR middle-end/56461 Jakub> * internal.h (struct cpp_buffer): Add to_free field. Jakub> (_cpp_pop_file_buffer): Add third argument. Jakub> * files.c (_cpp_stack_file): Set buffer->to_free. Jakub> (_cpp_pop_file_buffer): Add to_free argument. Free to_free Jakub> if non-NULL, and if equal to file->buffer_start, also clear Jakub> file-> buffer{,_start,_valid}. Jakub> * directives.c (_cpp_pop_buffer): Pass buffer->to_free Jakub> to _cpp_pop_file_buffer. This is ok. Thanks, Jakub. Tom