From: Richard Sandiford <richard@codesourcery.com>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Make more use of register insv and ext*v expanders
Date: Wed, 18 Jul 2007 23:29:00 -0000 [thread overview]
Message-ID: <87wswxxsz4.fsf@firetop.home> (raw)
In-Reply-To: <Pine.LNX.4.64.0707182223340.1820@scrub.home> (Roman Zippel's message of "Wed\, 18 Jul 2007 22\:41\:53 +0200 \(CEST\)")
Roman Zippel <zippel@linux-m68k.org> writes:
>> ...on targets that also have limited memory expanders.
>>
>> The insv, extv and extzv patterns can ask for the structure operand
>> to be a register, a memory, or either. If the predicate rejects a
>> memory operand, store_bit_field and extract_bit_field try using a
>> register operand instead.
>
> Hmm, I already wanted to get the patch reverted I mentioned here:
>
> http://gcc.gnu.org/ml/gcc-patches/2007-07/msg01169.html
>
> The problem is that this would conflict with your patch and since you
> already work in this area I hope you can give some help how to resolve
> this. :)
I think it's an orthogonal issue. Let's not try to solve everything
at once. ;) If we want to add that check back, we can easily add it
back to either the pre-patch or post-patch sources.
> Any idea how I can get gcc again to use and/or instructions for constant
> single-bit bitfields instead of bitfield instructions? Should I just
> reject this in the expander or is there something better?
This is related to the MIPS all-bits-set case I mentioned.
Perhaps the conceptually cleanest thing is to choose between
insv and store_fixed_bit_field based on rtx costs, but I haven't
really thought about it much.
Richard
next prev parent reply other threads:[~2007-07-18 22:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-18 13:10 Richard Sandiford
2007-07-18 18:48 ` Adam Nemet
2007-07-18 18:58 ` Richard Sandiford
2007-07-18 20:12 ` Adam Nemet
2007-07-18 21:05 ` Roman Zippel
2007-07-18 23:29 ` Richard Sandiford [this message]
2007-07-27 6:26 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wswxxsz4.fsf@firetop.home \
--to=richard@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).