From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29106 invoked by alias); 1 Dec 2003 21:30:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 29081 invoked from network); 1 Dec 2003 21:30:38 -0000 Received: from unknown (HELO mail.codesourcery.com) (65.73.237.138) by sources.redhat.com with SMTP; 1 Dec 2003 21:30:38 -0000 Received: (qmail 26899 invoked from network); 1 Dec 2003 21:25:32 -0000 Received: from taltos.codesourcery.com (zack@66.92.218.83) by mail.codesourcery.com with DES-CBC3-SHA encrypted SMTP; 1 Dec 2003 21:25:32 -0000 Received: by taltos.codesourcery.com (sSMTP sendmail emulation); Mon, 1 Dec 2003 13:30:34 -0800 From: "Zack Weinberg" To: Ulrich Weigand Cc: gcc-patches@gcc.gnu.org Subject: Re: Unreviewed patch References: <200312012027.VAA24818@faui1d.informatik.uni-erlangen.de> Date: Mon, 01 Dec 2003 21:30:00 -0000 In-Reply-To: <200312012027.VAA24818@faui1d.informatik.uni-erlangen.de> (Ulrich Weigand's message of "Mon, 1 Dec 2003 21:27:38 +0100 (CET)") Message-ID: <87wu9gp6o5.fsf@egil.codesourcery.com> User-Agent: Gnus/5.1002 (Gnus v5.10.2) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-12/txt/msg00113.txt.bz2 Ulrich Weigand writes: ... > As to why this is the right fix, if you look at all the other > places in unroll.c (or loop.c) where the BIV initial value > is used in some computation involving a GIV, it is *always* > passed through extend_value_for_giv. This was initially > introduced by rth's patch > http://gcc.gnu.org/ml/gcc-patches/2000-09/msg00257.html > > It looks like this was just forgotten at that one location, > and simply unnoticed until now because it's hard to trigger. Okay, in that case I approve the patch for mainline, and you should inquire of Gaby whether it's okay for 3.3 branch. zw