From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id F262E3858D20 for ; Sat, 30 Mar 2024 13:05:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F262E3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F262E3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711803908; cv=none; b=uiBWjLRNB1PlWGo7V98pMgal1eXfTlyR6yNeoyGyU54fg3XZNrr/I+mhcproeGwS4cpV4JZkkM1tP2gAi1EuluoacUasDDHkHzHe6s4l1EWySY2JEB3ui4ewC1/GfBcPANqYv/ovI1RRiOMYA9HYBGpnbOI3bS29zTjayVR4InM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711803908; c=relaxed/simple; bh=4yXV/FfIFTSfmoi1qC7auwtFx7MfI7o7kD+Y0/H5KsY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=l7lLxnpVyROZ4Cj66EzzXIGxwwWyFGu5cmHXBAqy3EUd3ObcVeeC1LvdNcbnO3V97SK9wdMU5ECqmc6CWsrWaUId+63m1cIlrqb9Qqyn8ZOIC5PBtgprn9VfkvoDgr6/YmeP5cxGQg7cF5pbfDyvp9tzb1RdzUArhZKvwVarMfo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4155a763f5dso1075235e9.1 for ; Sat, 30 Mar 2024 06:05:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711803905; x=1712408705; darn=gcc.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=+eZ4cZDsTus3tBtYv38CKqnGnEEFv/8ugw88N7khnHw=; b=JkXaZARnze4VVXy3fDoF5yalVoKd7bPAXV4pNYGIkq+iO58HlOOSXnPjJqsVblYy/y OuKNyulD7/j1FVzxjcHheMMmkN+GgsOf2l3Oz5TQEWveZig95iAtYxPozxYl7z5Zl+fE IPjnn0U8Y2qwy0/F96LixJj2RwhVqOM+H/21LPgARsVJSJm4KIz+DweQR/Yx3sYSCsSX kzdegaw9H4XXD+Sh7weT51LQIoHC20W2kFKMrZyRaJqRajmbsfpQcSJbqMhu8ajmtGTx 7RSnRHGSaURkyomI1NNuBCewm53YVL7eE/yMWSHpZ1yico4M0AfpZh10pPsABugItAAz 70hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711803905; x=1712408705; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+eZ4cZDsTus3tBtYv38CKqnGnEEFv/8ugw88N7khnHw=; b=V4fJPEgYdsglPkqyLwvueQpcpz0RBmgGDY4n5DDKRaGUh99PSrbiS1kTOZwXs2cvYS 6dMQ5T4jdOOWWoJ9TUbrx/fdtxpD39AaSMXQY6My5hiOX9ufcWoIUBq6QvlfMPvFZduA w+veDtUS7k/ZW6nTwxbaSaLYddhAI3W5xozfUSbj2CIk0F524u2dgKPlILpvgnVsanRK l4hmgduKkT9p3y8qGyvi5XmH4XzJA/ZMVOJkCARVPyZacwS7kixCAcUCeSuP02OVQhTt ilYALuOI25N1AyRk+109de046vTy2gpzZ/4HqCkxP/onVdtaSRticf7ahup/hnWZEfAU Skkw== X-Gm-Message-State: AOJu0Yx9qtD0tKE/xIX5xUvX1AK9uR1Io+yRmIo2eqzx35KXkpj/cfLG 6Cughx+UYdKKTmyG2ch/E+jEdpLLe128AECMFNO4MCihL9IyMtKY X-Google-Smtp-Source: AGHT+IFSpxYGoQymNYB0DEykWc1jqzYA4vkNPg0E/AkwKkpwU/BZEhmUMjjebSD1/Sm5MKm9pqsOJw== X-Received: by 2002:a05:600c:35d6:b0:415:46be:6239 with SMTP id r22-20020a05600c35d600b0041546be6239mr3184370wmq.36.1711803905469; Sat, 30 Mar 2024 06:05:05 -0700 (PDT) Received: from lancelot ([91.84.105.30]) by smtp.gmail.com with ESMTPSA id g16-20020a05600c311000b004148670f9ecsm8547032wmo.23.2024.03.30.06.05.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Mar 2024 06:05:05 -0700 (PDT) Received: from gaius by lancelot with local (Exim 4.96) (envelope-from ) id 1rqYOO-000GIG-0E; Sat, 30 Mar 2024 13:05:04 +0000 From: Gaius Mulley To: Christophe Lyon Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 2/2] modula2: Fix m2.install-info in gcc/m2/Make-lang.in References: <20240329180903.3325518-1-christophe.lyon@linaro.org> <20240329180903.3325518-2-christophe.lyon@linaro.org> Date: Sat, 30 Mar 2024 13:05:03 +0000 In-Reply-To: <20240329180903.3325518-2-christophe.lyon@linaro.org> (Christophe Lyon's message of "Fri, 29 Mar 2024 18:09:03 +0000") Message-ID: <87y19zooow.fsf@localhost> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Christophe Lyon writes: > Fix a few typos: the generated filename is m2.info (not gm2.info, and > gm2$(exeext) is a file not a directory (so test -d would always fail). > > 2024-03-29 Christophe Lyon > > gcc/m2/ > * Make-lang.in (m2.install-info): Fix rule. > --- > gcc/m2/Make-lang.in | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/gcc/m2/Make-lang.in b/gcc/m2/Make-lang.in > index 2d8a47a1b1f..e56240b4c44 100644 > --- a/gcc/m2/Make-lang.in > +++ b/gcc/m2/Make-lang.in > @@ -400,20 +400,20 @@ m2.install-common: installdirs > done > > m2.install-info: installdirs > - if [ -d gm2$(exeext) ] ; then \ > - if [ -f $(objdir)/doc/gm2.info ]; then \ > - rm -f $(DESTDIR)$(infodir)/gm2.info*; \ > - for f in $(objdir)/doc/gm2.info*; do \ > + if [ -f gm2$(exeext) ] ; then \ > + if [ -f $(objdir)/doc/m2.info ]; then \ > + rm -f $(DESTDIR)$(infodir)/m2.info*; \ > + for f in $(objdir)/doc/m2.info*; do \ > realfile=`echo $$f | sed -e 's|.*/\([^/]*\)$$|\1|'`; \ > rm -f $(DESTDIR)$(infodir)/`basename $$realfile`; \ > $(INSTALL_DATA) $$f $(DESTDIR)$(infodir)/`basename $$realfile`; \ > done; \ > - chmod a-x $(DESTDIR)$(infodir)/gm2.info*; \ > + chmod a-x $(DESTDIR)$(infodir)/m2.info*; \ > else true; fi; \ > else true; fi > - -if [ -f gm2$(exeext) ] && [ -f $(DESTDIR)$(infodir)/gm2.info ]; then \ > + -if [ -f gm2$(exeext) ] && [ -f $(DESTDIR)$(infodir)/m2.info ]; then \ > if $(SHELL) -c 'install-info --version' >/dev/null 2>&1; then \ > - install-info --dir-file=$(infodir)/dir $(DESTDIR)$(infodir)/gm2.info; \ > + install-info --dir-file=$(infodir)/dir $(DESTDIR)$(infodir)/m2.info; \ > else true; fi; \ > else true; fi lgtm, many thanks for spotting these bugs, regards, Gaius