From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id BA501384CB97 for ; Thu, 15 Feb 2024 16:49:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BA501384CB97 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BA501384CB97 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708015782; cv=none; b=jHwKLIIccrdrq+T3u1dfVQruEiSHIKKjmYz1KB68jcCxajLiJS5QlbJkKm67tjMpmZW+R2L2Qwm2Cc386l9J0ZaM3JLIEQtgm9YLIFHbkPURFikJWwHA7cdNeYHbO65Z2qXynuoeL7RcwlA/Y9ExrHzqMygfD1P+V3xwylAuTd0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708015782; c=relaxed/simple; bh=OOtRkJNoGF/pqQQ40HuXxydoRwgHgg6aVS73x8MlE2o=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=HheLqxyU43JD1Ykbui3pSUf5Bu9YtMqpSyIt3wDFNnfz3UU1Sackddy71w/Cfcgi35B24xdWfkO83S9mkAIfHHAXzCZ6E0XuF0HH0gvoM3ed3F6TW8OsafR4snoj+sPpXKlXVSXt/PcnuSBH/OGezCNysfS3vT+Uk7jymtcc4FI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708015780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N1Ej3wb/v6CEw0PvDVLxaAEaA/A3kgo3sRxnl8StR8A=; b=C+KlUan/lvGYAhI+T6iKa/v2HcdLagX9htifajY2F03kBNs6V2FTi91x4MQNXDSvoR1hx5 qQcw1PicYTcVdiAJkAa0z+KPbUyHJb6N8rugfRb/LXo+rFCNidwp6er6fs0/rncd5GPmBV M/Tq9tCLKwGoa+/LLVjsxQhF6WHJ2as= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-553-TXEjIu3bMiaGoA0Ag5mQlw-1; Thu, 15 Feb 2024 11:49:37 -0500 X-MC-Unique: TXEjIu3bMiaGoA0Ag5mQlw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BB8321C09832; Thu, 15 Feb 2024 16:49:36 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E7141492BE7; Thu, 15 Feb 2024 16:49:35 +0000 (UTC) From: Florian Weimer To: Gerald Pfeifer Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Notes on the warnings-as-errors change in GCC 14 References: <87v876ssxg.fsf@oldenburg.str.redhat.com> <9fce9298-1aec-27ce-591e-a1d415d34dba@pfeifer.com> Date: Thu, 15 Feb 2024 17:49:34 +0100 In-Reply-To: <9fce9298-1aec-27ce-591e-a1d415d34dba@pfeifer.com> (Gerald Pfeifer's message of "Sat, 10 Feb 2024 00:07:45 +0100 (CET)") Message-ID: <87y1bl8yg1.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Gerald Pfeifer: > On Fri, 2 Feb 2024, Florian Weimer wrote: >> +

Certain warnings are now errors

> > That's quite a nice description, thank you, Florian! > >> +The initial ISO C standard and its 1999 revision removed support for > > May I suggest to wrap paragraphs in

...

? Not strictly necessary an= y=20 > more, now that we switched to HTML 5, though more consistent and explicit= . I've tried this now, and adds extra whitespace in some cases, for example here: =E2=80=9C

In most cases, simply adding the missing int keyword addresses the error. For example, a flag variable like

  static initialized;

becomes:

  static int initialized;
=E2=80=9D I would have to nest the
 in the 

, which suggests a complexity that just isn't there. Thanks, Florian