From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=ry/l=GT=gentoo.org=sam@sourceware.org>
Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
	by sourceware.org (Postfix) with ESMTP id 729F63858C66;
	Mon,  6 Nov 2023 21:58:25 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 729F63858C66
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 729F63858C66
Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699307906; cv=none;
	b=Me//efffxIpOcmpN5eobdKANiYKiJ5FTm0GX2H3tZAHp97kHu9U0aNuSxArY4n9JlETQWRuWcLvUhYI21fgi0vCh/Me8z4ni79Eesu40SGfkCdLlzDpWYee/pU35wb7kUZNELu1hZqnUhBFpV5dYy/xciiy5PZWRPPhTiNCuWiI=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1699307906; c=relaxed/simple;
	bh=4u9k/0DtYOqTofPXFMJM/kqAQUK67fomEsnznEEGFjw=;
	h=From:To:Subject:Date:Message-ID:MIME-Version; b=KxHmWFb1DXTBpeoZCnVjwzYv+S5KzF8FI4oS0ct83M6yBcOjDtPU261Sz+t2QBNJ2IV/BQjfIw43HCFfN2YCFEhicZxqKPLlgoC1SNEp2oKHZzO9OueVFwF9xjFzS8Al6Kkj0v9kZKS+fdlkbQ23ZAF4ZMFTolowBStiee6b2HY=
ARC-Authentication-Results: i=1; server2.sourceware.org
References: <2f5f1761-0108-4900-9926-d49fa03b066c@gmail.com>
User-agent: mu4e 1.10.7; emacs 30.0.50
From: Sam James <sam@gentoo.org>
To: =?utf-8?Q?Fran=C3=A7ois?= Dumont <frs.dumont@gmail.com>
Cc: libstdc++ <libstdc++@gcc.gnu.org>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH][_Hashtable] Add missing destructor call
Date: Mon, 06 Nov 2023 21:58:05 +0000
Organization: Gentoo
In-reply-to: <2f5f1761-0108-4900-9926-d49fa03b066c@gmail.com>
Message-ID: <87y1famtmr.fsf@gentoo.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,BODY_8BITS,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>


Fran=C3=A7ois Dumont <frs.dumont@gmail.com> writes:

> Noticed looking for other occasion to replace __try/__catch with RAII
> helper.
>
> =C2=A0=C2=A0=C2=A0 libstdc++: [_Hashtable] Add missing node destructor ca=
ll
>
> =C2=A0=C2=A0=C2=A0 libstdc++-v3/ChangeLog:
>
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * incl=
ude/bits/hashtable_policy.h
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (_Hash=
table_alloc<>::_M_allocate_node): Add missing call
> to node destructor
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 on con=
struct exception.
>
> Tested under Linux x64, ok to commit ?
>
> I hope gmail appli will appreciate .diff instead of .patch. .txt are
> not in .gitignore so annoying to use for patches.

Are you using 'git send-email'? It should handle all of that for you.

>
> Fran=C3=A7ois
>
> [2. text/x-patch; hashtable_policy.h.diff]...