From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from postbox-1.southwales.ac.uk (postbox-1.southwales.ac.uk [194.82.57.76]) by sourceware.org (Postfix) with ESMTPS id 397FC383F40B for ; Fri, 18 Jun 2021 15:10:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 397FC383F40B Received: from j228-gm.comp.glam.ac.uk ([193.63.148.84]) by postbox-1.southwales.ac.uk with esmtp (Exim 4.94.2) (envelope-from ) id 1luG7k-000DpC-Ch; Fri, 18 Jun 2021 16:10:18 +0100 From: Gaius Mulley To: Richard Biener Cc: gcc-patches@gcc.gnu.org, dje.gcc@gmail.com, Matthias Klose Subject: Re: [PATCH] Modula-2 into the GCC tree on master References: <87eed0nn4u.fsf@j228-gm.comp.glam.ac.uk> Date: Fri, 18 Jun 2021 16:10:18 +0100 In-Reply-To: (Richard Biener's message of "Fri, 18 Jun 2021 12:52:41 +0200 (CEST)") Message-ID: <87y2b7fbtx.fsf@j228-gm.comp.glam.ac.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jun 2021 15:10:22 -0000 Richard Biener writes: >> > I would suggest to not rush this in now during stage4 but instead >> > take the opportunity of this "quiet" phase to prepare an integration >> > branch with all the issues above sorted out which we can merge at >> > the beginning of stage1 for GCC 12 (or later during stage4 if >> > everyone is happy and/or backport for GCC 11.2 when it landed in >> > trunk). > > So as suggested above please create a public branch off trunk where you > do the integration and keep it rebased on trunk regularly. It looks > like you do not have write access to the GCC repository, please > obtain that and make yourself familiar with the repository and > branch layout. ok thanks - will do. Incidentally there is a nightly rebase automatically performed on git clone http://floppsie.comp.glam.ac.uk/gm2 combined-repro-gcc with a number of branches. git checkout remotes/origin/gm2-master obtains gcc 12, it runs about 24 hours behind gcc and the gm2 repro. I'll create a public branch on gcc.gnu.org and keep it up to date. > I see there are copyright disclaimers and assignments to the FSF > for you though for GCC I see specific changes rather than > boiler-plate "past and future changes". Fortunately we now have > a DCO in place so I suggest to make sure to annotate commits > to areas you did not assign copyright with appropriate Signed-Off-By > lines - or maybe for simplicity apply that to all commits. good idea - as you say fortunate the DCO came along - impeccable timing :-). I will use a DCO on all commits to be safe, > The SC may also have comments here. > > Basically I'd like to see the merged state accessible on a branch. > > Thanks, > Richard. regards, Gaius