Re: [PATCH v2 2/N] Introduce dump_flags_t type and use it instead of int, type.

[Thomas Schwinge <thomas@codesourcery.com>]

Hi!

On Wed, 17 May 2017 11:02:09 +0200, Martin Liška <mliska@suse.cz> wrote:
> On 05/17/2017 09:44 AM, Richard Biener wrote:
> > On Tue, May 16, 2017 at 4:55 PM, Martin Liška <mliska@suse.cz> wrote:
> >> On 05/16/2017 03:48 PM, Richard Biener wrote:
> >>> On Fri, May 12, 2017 at 3:00 PM, Martin Liška <mliska@suse.cz> wrote:
> >>>> Second part changes 'int flags' to a new typedef.
> >>>> All corresponding interfaces have been changed.

The very most, but not not all.  ;-)

> installed as r248140.

    [...]/gcc/brig/brigfrontend/brig-to-generic.cc: In constructor 'brig_to_generic::brig_to_generic()':
    [...]/gcc/brig/brigfrontend/brig-to-generic.cc:89:56: error: cannot convert 'int*' to 'dump_flags_t* {aka long unsigned int*}' for argument '2' to 'FILE* dump_begin(int, dump_flags_t*)'
       m_dump_file = dump_begin (TDI_original, &m_dump_flags);
                                                            ^

As obvious, committed to trunk in r248200:

commit 6059695267f35a22932f75471ab78467eeddf5e8
Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Thu May 18 13:34:29 2017 +0000

    More dump_flags_t conversion
    
            gcc/brig/
            * brigfrontend/brig-to-generic.h (class brig_to_generic): Use
            "dump_flags_t" for "m_dump_flags" member.
    
    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@248200 138bc75d-0d04-0410-961f-82ee72b054a4
---
 gcc/brig/ChangeLog                      | 5 +++++
 gcc/brig/brigfrontend/brig-to-generic.h | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git gcc/brig/ChangeLog gcc/brig/ChangeLog
index 3c563b1..1b1a1eb 100644
--- gcc/brig/ChangeLog
+++ gcc/brig/ChangeLog
@@ -1,3 +1,8 @@
+2017-05-18  Thomas Schwinge  <thomas@codesourcery.com>
+
+	* brigfrontend/brig-to-generic.h (class brig_to_generic): Use
+	"dump_flags_t" for "m_dump_flags" member.
+
 2017-05-13  Pekka Jääskeläinen  <pekka.jaaskelainen@parmance.com>
 
 	* brigfrontend/brig-code-entry-handler.cc
diff --git gcc/brig/brigfrontend/brig-to-generic.h gcc/brig/brigfrontend/brig-to-generic.h
index 09d7c42..b94ff7c 100644
--- gcc/brig/brigfrontend/brig-to-generic.h
+++ gcc/brig/brigfrontend/brig-to-generic.h
@@ -169,7 +169,7 @@ private:
   FILE *m_dump_file;
 
   /* The original dump file flags.  */
-  int m_dump_flags;
+  dump_flags_t m_dump_flags;
 };
 
 /* Produce a "mangled name" for the given brig variable.  The mangling is used


Grüße
 Thomas