From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54956 invoked by alias); 20 Oct 2016 19:14:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 54946 invoked by uid 89); 20 Oct 2016 19:14:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=retains, sk:bschmid, U*bschmidt, bschmidt@redhat.com X-HELO: mail-qk0-f175.google.com Received: from mail-qk0-f175.google.com (HELO mail-qk0-f175.google.com) (209.85.220.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Oct 2016 19:13:56 +0000 Received: by mail-qk0-f175.google.com with SMTP id o68so113193322qkf.3 for ; Thu, 20 Oct 2016 12:13:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:mail-followup-to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version; bh=+ANUSVQX/AYvJTXqE5b8t0V7ec4IfUYcdCJ/HHEc3Kw=; b=QUu2rPgg3SLB+9DNKzlrbX3I8dPVBAPuMH9abT9hcdS3ZfkLZARFP8Kort1PwRTHv9 QFO08E3Wst+z8ei5V9UCNd1ahr9tpo/WFbB6ilcwaM59dbtd7CGdb/RU6U074PJPHIwQ Gb/eGPHM40hX96pBm83wfM5q2KFvNCZrSnAAynQUKE8Rg7n3ano0YUk/RPeaypgLZPxe M39yW/MkegfShnmE4mF+uWfjhBAPWtO4cyMY++2pqVzYCGI60D+kTPcZGzlqCTDwKFZ5 Z+6x0AiBxXd8njbXUH7hVp9OkgT+1XXLDjkn4iY9U5SRtZm2VNgam+M/rfIQ2GN/Ygy1 9yig== X-Gm-Message-State: AA6/9RmakKp4URjLeNljtYutDE5t3hvG2paDAf7ibpSdXNnHLeEf5DSJZhwmMVncdrlFfA== X-Received: by 10.194.192.105 with SMTP id hf9mr1260698wjc.41.1476990835109; Thu, 20 Oct 2016 12:13:55 -0700 (PDT) Received: from localhost ([95.144.14.157]) by smtp.googlemail.com with ESMTPSA id yo1sm81079424wjc.16.2016.10.20.12.13.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Oct 2016 12:13:54 -0700 (PDT) From: Richard Sandiford To: Bernd Schmidt Mail-Followup-To: Bernd Schmidt ,David Malcolm , gcc-patches@gcc.gnu.org, rdsandiford@googlemail.com Cc: David Malcolm , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 09/16] Split class rtx_reader into base_rtx_reader vs rtx_reader References: <1475684110-2521-1-git-send-email-dmalcolm@redhat.com> <1475684110-2521-10-git-send-email-dmalcolm@redhat.com> <2296dd4b-cf1e-8fca-2df3-092aad7dc575@redhat.com> <1476822633.10766.69.camel@redhat.com> Date: Thu, 20 Oct 2016 19:14:00 -0000 In-Reply-To: (Bernd Schmidt's message of "Wed, 19 Oct 2016 16:45:10 +0200") Message-ID: <87y41iltou.fsf@googlemail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2016-10/txt/msg01690.txt.bz2 Bernd Schmidt writes: > On 10/18/2016 10:30 PM, David Malcolm wrote: >> >> I'm not in love with the names I chose in this patch. It does seem odd >> having an "rtx_reader" class that can't actually read hierarchical rtx. >> >> How about "md_reader" as the base class (with responsibility for the >> things in read-md.o), and "rtx_reader" for the subclass (adding the >> things in read-rtl.o)? > > I think a lot of renaming was for a variable (base_rtx_reader_ptr), not > the class, wasn't it? I would very much like to avoid these, but I think > for the class names it should be ok to go with what you suggest. FWIW, using md_reader and rtx_reader sounds good to me too. These days .md files contain more than just rtl (although everything retains the same lispy syntax), so the names seem pretty natural. Thanks, Richard