From: Thomas Schwinge <thomas@codesourcery.com>
To: Cesar Philippidis <cesar@codesourcery.com>
Cc: Tom de Vries <Tom_deVries@mentor.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Nathan Sidwell <nathan_sidwell@mentor.com>
Subject: Re: [gomp4, wip] remove references to ganglocal shared memory inside gcc
Date: Fri, 18 Sep 2015 08:40:00 -0000 [thread overview]
Message-ID: <87y4g415qi.fsf@kepler.schwinge.homeip.net> (raw)
In-Reply-To: <55E5D283.8080105@mentor.com>
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
Hi!
On Tue, 1 Sep 2015 18:29:55 +0200, Tom de Vries <Tom_deVries@mentor.com> wrote:
> On 27/08/15 03:37, Cesar Philippidis wrote:
> > - ctx->ganglocal_size_host = align_and_expand (&gl_host, host_size, align);
>
> I suspect this caused a bootstrap failure (align_and_expand unused).
> Worked-around as attached.
> --- a/gcc/omp-low.c
> +++ b/gcc/omp-low.c
> @@ -1450,7 +1450,7 @@ omp_copy_decl (tree var, copy_body_data *cb)
>
> /* Modify the old size *POLDSZ to align it up to ALIGN, and then return
> a value with SIZE added to it. */
> -static tree
> +static tree ATTRIBUTE_UNUSED
> align_and_expand (tree *poldsz, tree size, unsigned int align)
> {
> tree oldsz = *poldsz;
If I remember correctly, this has only ever been used in the "ganglocal"
implementation -- which is now gone. So, should align_and_expand also be
elided (Cesar)?
Grüße,
Thomas
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]
next prev parent reply other threads:[~2015-09-18 8:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 1:47 Cesar Philippidis
2015-08-27 13:14 ` Nathan Sidwell
2015-08-27 17:55 ` Cesar Philippidis
2015-08-27 18:12 ` Nathan Sidwell
2015-09-01 16:30 ` Tom de Vries
2015-09-18 8:40 ` Thomas Schwinge [this message]
2015-09-18 13:52 ` Cesar Philippidis
2015-09-23 10:59 ` Thomas Schwinge
2015-09-01 16:31 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4g415qi.fsf@kepler.schwinge.homeip.net \
--to=thomas@codesourcery.com \
--cc=Tom_deVries@mentor.com \
--cc=cesar@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nathan_sidwell@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).