From: Thomas Schwinge <thomas@codesourcery.com>
To: Nathan Sidwell <nathan@codesourcery.com>,
Tom de Vries <tom@codesourcery.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [gomp4] remove kernel-specific launch
Date: Sun, 19 Jul 2015 21:05:00 -0000 [thread overview]
Message-ID: <87y4ibubyj.fsf@kepler.schwinge.homeip.net> (raw)
In-Reply-To: <55AB97C0.4080303@acm.org>
[-- Attachment #1: Type: text/plain, Size: 870 bytes --]
Hi!
On Sun, 19 Jul 2015 08:27:44 -0400, Nathan Sidwell <nathan@acm.org> wrote:
> Tom,
> as we discussed this patch removes the GOACC_kernels call, which forwards to
> GOACC_parallel. We simply call GOACC_parallel directly.
>
> ok for gomp4 branch?
> gcc/
> * omp-low.c (expand_omp_target): Convert to
> BUILT_IN_GOACC_PARALLEL. Remove BUILT_IN_GOACC_KERNELS cases.
> * omp-builtins.def (BUILT_IN_GOACC_KERNELS): Delete.
>
> libgomp/
> * oacc-parallel.c (GOACC_kernels): Delete.
Yes, thanks for the cleanup. Please also adjust/remove the following:
gcc/tree-parloops.c: /* Remove GOACC_kernels. */
libgomp/libgomp.map: GOACC_kernels;
libgomp/libgomp_g.h:extern void GOACC_kernels (int, void (*) (void *), size_t,
Does it make sense then to rename GOACC_kernels_internal to
GOACC_kernels?
Grüße,
Thomas
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]
next prev parent reply other threads:[~2015-07-19 20:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-19 16:14 Nathan Sidwell
2015-07-19 17:13 ` Tom de Vries
2015-07-19 21:05 ` Thomas Schwinge [this message]
2015-07-19 21:08 ` Tom de Vries
2015-07-19 21:10 ` Nathan Sidwell
2015-07-20 12:08 ` Tom de Vries
2015-07-20 12:45 ` Nathan Sidwell
2015-07-21 10:23 ` Thomas Schwinge
2015-07-21 12:07 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4ibubyj.fsf@kepler.schwinge.homeip.net \
--to=thomas@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nathan@codesourcery.com \
--cc=tom@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).