Re: [gomp4.1] Initial support for some OpenMP 4.1 construct parsing

[Thomas Schwinge <thomas@codesourcery.com>]

[-- Attachment #1: Type: text/plain, Size: 1776 bytes --]

Hi Jakub!

On Wed, 29 Apr 2015 14:06:44 +0200, Jakub Jelinek <jakub@redhat.com> wrote:
> On Wed, Apr 29, 2015 at 01:52:24PM +0200, Thomas Schwinge wrote:
> > > --- gcc/tree-pretty-print.c.jj	2015-04-29 10:58:01.663745452 +0200
> > > +++ gcc/tree-pretty-print.c	2015-04-29 11:03:04.648990986 +0200
> > > @@ -550,22 +560,22 @@ dump_omp_clause (pretty_printer *pp, tre
> > >  	  pp_string (pp, "tofrom");
> > >  	  break;
> > >  	case GOMP_MAP_FORCE_ALLOC:
> > > -	  pp_string (pp, "force_alloc");
> > > +	  pp_string (pp, "always,alloc");
> > >  	  break;
> > >  	case GOMP_MAP_FORCE_TO:
> > > -	  pp_string (pp, "force_to");
> > > +	  pp_string (pp, "always,to");
> > >  	  break;
> > >  	case GOMP_MAP_FORCE_FROM:
> > > -	  pp_string (pp, "force_from");
> > > +	  pp_string (pp, "always,from");
> > >  	  break;
> > >  	case GOMP_MAP_FORCE_TOFROM:
> > > -	  pp_string (pp, "force_tofrom");
> > > +	  pp_string (pp, "always,tofrom");
> > >  	  break;
> > >  	case GOMP_MAP_FORCE_PRESENT:
> > >  	  pp_string (pp, "force_present");
> > >  	  break;
> > >  	case GOMP_MAP_FORCE_DEALLOC:
> > > -	  pp_string (pp, "force_dealloc");
> > > +	  pp_string (pp, "always,delete");
> > >  	  break;
> > >  	case GOMP_MAP_FORCE_DEVICEPTR:
> > >  	  pp_string (pp, "force_deviceptr");
> > 
> > Makes some sense to me to use the same "always,*" syntax also for the
> > other "force_*" ones, given that these are artificial ("non-OpenACC")
> > descriptions anyway.
> 
> Ok.  Are the GOMP_MAP_FORCE_* artificial too?  If yes, I can change that
> to GOMP_MAP_ALWAYS_*.

Yes, fine with me.  (Though, what about that »names are sticky« thing,
<http://news.gmane.org/find-root.php?message_id=%3C523AC6FF.6030007%40acm.org%3E>?)


Grüße,
 Thomas

[-- Attachment #2: Type: application/pgp-signature, Size: 472 bytes --]