* [ARM, committed] Fix rtl checking failure in thumb2_reorg
@ 2015-02-03 14:20 Richard Sandiford
0 siblings, 0 replies; only message in thread
From: Richard Sandiford @ 2015-02-03 14:20 UTC (permalink / raw)
To: gcc-patches; +Cc: ramana.radhakrishnan
The thumb2_reorg code:
if (!OBJECT_P (src))
op0 = XEXP (src, 0);
causes an rtl checking failure if SRC is an UNSPEC. This doesn't matter
in practice without rtl checking since OP0 is only used if SRC is a unary
or binary operator. This patch tightens the condition to reflect that.
The code was added in the 4.7-4.8 timeframe, although I don't know whether
it had to handle UNSPECs at that stage. Either way, this is a regression
and so seems like stage 4 material.
Tested on arm-eabi, where it fixes many testsuite failures with checking
enabled. Approved by Ramana off-list and committed.
Thanks,
Richard
gcc/
* config/arm/arm.c (thumb2_reorg): Test UNARY_P and BINARY_P
instead of OBJECT_P.
Index: gcc/config/arm/arm.c
===================================================================
--- gcc/config/arm/arm.c 2015-02-02 17:08:56.007379607 +0000
+++ gcc/config/arm/arm.c 2015-02-03 14:05:28.000601072 +0000
@@ -17297,7 +17297,7 @@ thumb2_reorg (void)
rtx src = XEXP (pat, 1);
rtx op0 = NULL_RTX, op1 = NULL_RTX;
- if (!OBJECT_P (src))
+ if (UNARY_P (src) || BINARY_P (src))
op0 = XEXP (src, 0);
if (BINARY_P (src))
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-02-03 14:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-03 14:20 [ARM, committed] Fix rtl checking failure in thumb2_reorg Richard Sandiford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).