From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by sourceware.org (Postfix) with ESMTPS id 118A03858D20 for ; Fri, 20 Jan 2023 18:39:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 118A03858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x330.google.com with SMTP id e19-20020a05600c439300b003db1cac0c1fso4976175wmn.5 for ; Fri, 20 Jan 2023 10:39:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Slo7wJiGThgg/xS8B5VH/iPGk2X7wUbQNdkKi6uUjEU=; b=LfLjQKorg1LVp+Rw6TpD6nophanqi7MCnHYqV1WndlA+6O1cCg6ZJkin76XZaVIHaN 95tXjmv/7g56UCLTXbH2gLSts88hZCHoncxE4E2TlhiJwgwKcZWmgX12jtoj495mIGCY mU9caiKpgy+L2cYbf6sVHMkzwcfLVyTcFE6cVTzdn1/lBVPYoPf2yAnKANofmmmIP46p +Cs0DIE3IaEzU8fy9BJjXtnRsa8MoEtIFa9e9Nt8tY2GD2y3y4rOXsFgjD5LUKGnM+2l pev1ofPSg+8afA4UdnDmkHCIG2pfcawcwbOTNYRCeEdCntKtVRvKsuTbBfcPOnugjr0k vExw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Slo7wJiGThgg/xS8B5VH/iPGk2X7wUbQNdkKi6uUjEU=; b=Rtyr6xQAg4BSBEBf5BVTTECrXS5IP2+3vWnpWY4bSQ8IsG7KoskyEYRLQmympARobf cQV8nxT/7DQ5+HbU9NegjWT7poLa77w9E/ENJyvah4OnHv+N6oVfRCzMJemLxIE/qd5M dXAK8oAnBkFdXzL3b0PfpXnahtv5t8roHgwZEtcRTPf4NTHYODS8wx4pL1S7thMoI+LA aP3Dhkm7Q31tmelp091aJthI1oFJEbeYw49LhQTwgveLme/dte8tqsxWHehR2lMtZC/V m6e9veCtbi/7yUKwj/ZFLGCLFvzs9tPRxi670cqR35YIMGL50FwXZ4NYrV3urQi2lLnj 2chQ== X-Gm-Message-State: AFqh2krOGcbkeGR8KPuNAD3r/uCBK6PdaY7HQsYwJvq29xSKsxmp6+4a 1yZAeoKylBUNhlJzGPDpSX0= X-Google-Smtp-Source: AMrXdXtKmqZXLEaDQTrMrR7zQV0AS/nzevSlqJGseRjpphft7dYpXz7aTllG0mcknuI0KBiQQhMg/A== X-Received: by 2002:a05:600c:21c7:b0:3da:939:34e9 with SMTP id x7-20020a05600c21c700b003da093934e9mr14900416wmj.34.1674239966875; Fri, 20 Jan 2023 10:39:26 -0800 (PST) Received: from lancelot ([195.147.220.46]) by smtp.gmail.com with ESMTPSA id g10-20020a05600c310a00b003d99da8d30asm3356231wmo.46.2023.01.20.10.39.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Jan 2023 10:39:26 -0800 (PST) Received: from gaius by lancelot with local (Exim 4.94.2) (envelope-from ) id 1pIwIO-001uS2-Iw; Fri, 20 Jan 2023 18:39:24 +0000 From: Gaius Mulley To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] modula2/108144 - Fix multilib install of libgm2 References: <63ca8324.170a0220.3a893.0660SMTPIN_ADDED_MISSING@mx.google.com> Date: Fri, 20 Jan 2023 18:39:24 +0000 In-Reply-To: <63ca8324.170a0220.3a893.0660SMTPIN_ADDED_MISSING@mx.google.com> (Richard Biener's message of "Fri, 20 Jan 2023 13:03:47 +0100 (CET)") Message-ID: <87zgad82zn.fsf@debian> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Richard Biener writes: > The following adjusts libgm2 to properly use the multilib build > infrastructure, thereby fixing the install with > --enable-version-specific-runtime-libs > > In particular config-ml.pl needs to be applied to generated Makefiles > as documented in the manual and we have to avoid clobbering the > variables via make arguments. The explicit install rules used different > ways to construct the multilib dir which isn't necessary and breaks > when MUTLIDIR is now finally set correctly. Instead use > $(toolexeclibdir). > > This results in some dead variables in the Makefile.am (and there were > some before), I refrained from doing even more changes here. > > Verified with an install with and without --enable-version-specific-runtime-libs > and checking the result. > > OK? > > Thanks, > Richard. Many thanks for this fix - and the deep magic AC_FOREACH config-ml.in recursion rhunes. LGTM regards, Gaius