From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id AFD9D3858D37 for ; Fri, 13 Jan 2023 01:43:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AFD9D3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-x436.google.com with SMTP id v2so8754460wrw.10 for ; Thu, 12 Jan 2023 17:43:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=yNs3ZWVkTRds3OxvH0JCuYUD1IIKkWCB+JOqFzq6sNE=; b=jQROEEI/LXg3iSHcTmwRj6M25J7WRo6zXRqYPTvC1j0QTh/SquI/soXMPXVzR7WBHa 1SUvJ0Ewzl9EOAV6OjaMiRtWZgABLfcD4bwloAmN2qvVFmBsFJnNBwsAVe77udfKK2/5 pEUq6QOPU7goXm0kQe97x8LNQj5wmFbhvPd/VAQC96AeS4J2ZhTDq50Apus87Djd8FtF 4TSG+8jfWDxTxDMVNNHs6fcarE9ZaGS8gPMSTVnTLjn3kR1qxq6HLNrGEIPa5SDc8EHd N85vKXTayBPLaSA0CE2A6H4tASpSkxitjcKn4MWkz2tCqovsZDELlmStZJyjiicy66BP rkpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yNs3ZWVkTRds3OxvH0JCuYUD1IIKkWCB+JOqFzq6sNE=; b=MRtH4T9/EfAwGmi9XgFimjaCAu1SuKNnS3/mSLSkRKxbj0appvhfsOj8nkD9EO7FRG rbrtoYTMXK/tdmI0mXS4uLqcNRWJupumCLe9/Miz0+I/2L8rNg0MNUHQPXye+YokOmfD 90TGuEd03TyPU7q1s5RPU7gd4xk2Os/1NYAG5z7hpEhCpTG5T1uUlk2k6w+Umf2vO2do HifwGqyKYhE7avxBGP4aHgPL+Z4qedpKbLZGlV2OHvY20yyb0KhpWcez8pnQB2Bhd/XZ nYUWoQuswyfXo7YwNMu7PY6ehzYgmq2EK7n+h/WhCyzGJGrjJIhYkx1DSFnPDjfU+EN+ HWuQ== X-Gm-Message-State: AFqh2koo+UPDlOouplzpTtDPejEBugWGtvfIa3n7l3fnzFe/QauRwrJx 924t+Sv4gydPFysNDSjxS95ajoRyPHQ= X-Google-Smtp-Source: AMrXdXsUlwm1J8yQgvy8cFsRS2sKr3kSMYPg9jnJDE3XLIxx80lLNhhU0CgJKTWWIRA54TUaI8WohA== X-Received: by 2002:a5d:6f0e:0:b0:2ba:73e3:f4f2 with SMTP id ay14-20020a5d6f0e000000b002ba73e3f4f2mr19837264wrb.2.1673574208148; Thu, 12 Jan 2023 17:43:28 -0800 (PST) Received: from lancelot ([195.147.220.46]) by smtp.gmail.com with ESMTPSA id i2-20020adfdec2000000b002b9b9445149sm20906412wrn.54.2023.01.12.17.43.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jan 2023 17:43:27 -0800 (PST) Received: from gaius by lancelot with local (Exim 4.94.2) (envelope-from ) id 1pG96M-003x13-4g; Fri, 13 Jan 2023 01:43:26 +0000 From: Gaius Mulley To: Iain Sandoe Cc: gcc-patches@gcc.gnu.org, iain@sandoe.co.uk Subject: Re: [PATCH] modula-2: Handle pass '-v' option to the compiler. References: <20230113001919.87334-1-iain@sandoe.co.uk> Date: Fri, 13 Jan 2023 01:43:26 +0000 In-Reply-To: <20230113001919.87334-1-iain@sandoe.co.uk> (Iain Sandoe's message of "Fri, 13 Jan 2023 00:19:19 +0000") Message-ID: <87zgandxa9.fsf@debian> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Iain Sandoe writes: > Tested on x86-64-darwin21. > OK for trunk? > Iain yes LGTM, thanks, Gaius > --- 8< --- > > Somehow this setting had been missed, and we really need the verbose > flag to enable useful debug output. > > Signed-off-by: Iain Sandoe > > gcc/m2/ChangeLog: > > * gm2-gcc/m2options.h (M2Options_SetVerbose): Export the > function. > * gm2-lang.cc: Handle OPT_v, passing it to the compiler. > * lang-specs.h: Pass -v to cc1gm2. > --- > gcc/m2/gm2-gcc/m2options.h | 1 + > gcc/m2/gm2-lang.cc | 3 +++ > gcc/m2/lang-specs.h | 2 +- > 3 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/gcc/m2/gm2-gcc/m2options.h b/gcc/m2/gm2-gcc/m2options.h > index 4b32c911b09..beaa460ffa9 100644 > --- a/gcc/m2/gm2-gcc/m2options.h > +++ b/gcc/m2/gm2-gcc/m2options.h > @@ -106,6 +106,7 @@ EXTERN int M2Options_GetCpp (void); > EXTERN int M2Options_GetM2g (void); > EXTERN void M2Options_SetM2g (int value); > EXTERN void M2Options_SetLowerCaseKeywords (int value); > +EXTERN void M2Options_SetVerbose (int value); > EXTERN void M2Options_SetUnusedVariableChecking (int value); > EXTERN void M2Options_SetUnusedParameterChecking (int value); > EXTERN void M2Options_SetStrictTypeChecking (int value); > diff --git a/gcc/m2/gm2-lang.cc b/gcc/m2/gm2-lang.cc > index 49f93901d3c..073d1dd55db 100644 > --- a/gcc/m2/gm2-lang.cc > +++ b/gcc/m2/gm2-lang.cc > @@ -451,6 +451,9 @@ gm2_langhook_handle_option ( > case OPT_save_temps_: > M2Options_SetSaveTempsDir (arg); > return 1; > + case OPT_v: > + M2Options_SetVerbose (value); > + return 1; > default: > if (insideCppArgs) > { > diff --git a/gcc/m2/lang-specs.h b/gcc/m2/lang-specs.h > index 0a34b0bc6d7..bf882649b21 100644 > --- a/gcc/m2/lang-specs.h > +++ b/gcc/m2/lang-specs.h > @@ -34,6 +34,6 @@ along with GCC; see the file COPYING3. If not see > {"@modula-2", > "cc1gm2 " M2CPP > " %(cc1_options) %{B*} %{c*} %{+e*} %{I*} " > - " %{i*} %{save-temps*} " > + " %{i*} %{save-temps*} %{v} " > " %i %{!fsyntax-only:%(invoke_as)}", > 0, 0, 0},