From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 40FCC3858425 for ; Thu, 22 Dec 2022 17:21:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 40FCC3858425 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BMFfO9H005003; Thu, 22 Dec 2022 17:21:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=references : from : to : cc : subject : in-reply-to : date : message-id : content-type : mime-version; s=corp-2022-7-12; bh=Quhk5ZE9qi30X7ZDijPKPShmbknR0/H0KgQbsvFpKNw=; b=G+nl/5Dldjp6LG0SXuFZVoy+156Q0zviiyLjJOh5ONFan0MeC5X9+uqaUgjxSdSdTbyW xIbAH+FENg9j0zgD5l2i2i9rTxmbhnZvqPcz94eEyhcYEIeR9EhDP8gI71wvylp72tJm JzfPItQ9xq5G4ElXoXI4ZIIU/JzfFQh/YWIaOvP9oa5kKZRXAWF6Y/zf1KYP8SZV7Up1 W7c692JoA6rioOxAgY9o9Yr/BeyGlplFGDRxp+iMO/B7oiXxNSz5Nh4mRM4LsbH9qc2j Or204TJcViqd6JvzDm2FfxkN7ZjwYh3rdV7rDQJ0DAXlL8v3GMG5KSJ68Ih93nOfPsk5 9g== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3mh6tpv6wj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 22 Dec 2022 17:21:29 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2BMHGfci030361; Thu, 22 Dec 2022 17:21:28 GMT Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2045.outbound.protection.outlook.com [104.47.57.45]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3mh478f8uu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 22 Dec 2022 17:21:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RbCp6XjwLlJ9Z41gXd1GX3bWoGmrQys7k1eCL+EuncIitzFTD3RLqz43Se9PGiy5NuhTXJg11TExc9ZcNOajJOCn8pMYpKzeNPJgPmR/oUiBd2/0aAaXMs8tHE0svohK0btc0y+B9xLFy0K64rVBSOBeWasg6PFKgOWmdKa82j+Gp8K0unRsIF4WGYtkz8oGDTptWs0uFP2I2IiS/yULZs8k665hs4mVPtuwU31dBo64dgxY//IYg7I8tvEQX0LCUiaUDT1FWjF/tZ5jIwXrRiiLJIwUwq5BXWmVpAZv5d04JTXs+f/K4RONnc2WZdoGvcM3bRfFQBO5bgDEx6/r4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Quhk5ZE9qi30X7ZDijPKPShmbknR0/H0KgQbsvFpKNw=; b=KuWNAZMu8jgH3u2swf3ubCQmVVanQf6b7SLE/CJ2yBsK8xValXJvMuzKmK/61ozQiiF489/NlzZq1OD3pCKSfUBUJ1EWO93m6DOIXutFc7I8ybfo2Kwqf2AsGAYVg9UpNdDUmyZ9WBHjg6ogiobdqfA+kFPKBDwLHW8+TDa+qgj0HjgUIjxfwlmEV/S8xtIbyPk++/h+g4QVFr/lM5LAagC+2M4CucuUFDATfr/AdHKLGMyu8Y1z4UqHAzH1SU1qGflhVt5x9ECb4ioCl+ZegZoAWGAPauY8iIe1S7x2WK651+EwtGkRVGL9W6H4HBUxcUa2XKPvC4B6NsuxIut3Ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Quhk5ZE9qi30X7ZDijPKPShmbknR0/H0KgQbsvFpKNw=; b=B3+G0Xp1jqbhXxbwcy/sK7a85busb50tcDBOTgEKNMzexYoMeL0rscgHKBNgj2YEDtrNUIh9mDSTTmlBwZkG/MA9u+KOmm6/LPscv3N5m/cDZEnrdd2uuKfYC4q7HaKK1Q/h90gbKnvgAcnHOniVnT9QVAAhrqq0dxj96ZAOGDA= Received: from BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) by DS7PR10MB5040.namprd10.prod.outlook.com (2603:10b6:5:3b0::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.6; Thu, 22 Dec 2022 17:21:26 +0000 Received: from BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::8681:5931:e558:2638]) by BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::8681:5931:e558:2638%7]) with mapi id 15.20.5924.016; Thu, 22 Dec 2022 17:21:26 +0000 References: <20221202175225.2780-1-cupertino.miranda@oracle.com> <20221202175225.2780-2-cupertino.miranda@oracle.com> <878rjj5jug.fsf@oracle.com> <87o7s52cv0.fsf@oracle.com> User-agent: mu4e 1.4.15; emacs 28.1 From: Cupertino Miranda To: Cupertino Miranda Cc: Jeff Law , jose.marchesi@oracle.com, gcc-patches@gcc.gnu.org Subject: [PING] Re: [PATCH 1/2] select .rodata for const volatile variables. In-reply-to: <87o7s52cv0.fsf@oracle.com> Date: Thu, 22 Dec 2022 17:21:21 +0000 Message-ID: <87zgbfz75a.fsf@oracle.com> Content-Type: text/plain X-ClientProxiedBy: LO2P265CA0159.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::27) To BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR1001MB2340:EE_|DS7PR10MB5040:EE_ X-MS-Office365-Filtering-Correlation-Id: e2af160f-41cc-4feb-e749-08dae440f47a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4AK4NPh6yVTI3q+lwBXFKNXkpzhbOg3ypIXFJfzPDq06fGN85FmhUKGmwkxbMFiB7EXcSzF/QdAA8/rTe+98dDRJAaFGbG8bgG6s3w43F858zaUNz53X9+ly+pYSuRphWLNES/KzrvQZnSSGxbrXcCoGZE/5Fcl0UmXkXY08X1hjM2u0xNkv+eAPbZK9qUtknQTgcMf5+W4QGPp6pa1Zqu6FIb1ZUOBLuBVf76UB1cuYdgcxHntz4xnEHci5O2MzSGCAkV+s3JN+bBdPz/N4jSJcwB6rU6NeIH3dI6aPVOswqCp0ICnIO6ECTfqSrLXDLow7RODMFju6GiwsU9a5g5OYc8QkLhbuSKrR3lizHK5rDhBHpm8ek81Xh2Q7KIYzFueH7RXaGcjr84G3HKyBINYG3MElLJTboaB2GqKCePKZM057DpAxtXhTfJibUtblkq8vzJrcCD1LTTpQruArDjKY/FZIaLn4iXSnAI9QqGAIlmaVb2WsmGBUEu/O0uJ8YQqhhKW+p/7joj0y1Kshj1XDPgJwKh6dD/IRpAM/wLbgvH0JKw0ulv2axIXDDd8uuFAOv5QGSh7YuDhvuURHqJ9qh+WVuNZPEjDUrIWjuPn3jToyPi7jJMuQQE8F6EHyIa3HYx0gdlT2l/DaJYGfyjAiAofvlkrKi1MaeLsqPfxRGA/isHqseI8jT9zQaoitXxBqQvPHa8GwEbT0DNLTqZ1NQ4W66FOJB4UhCqpqE3m8nLxzUG54BzORjqUb1g9n X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1001MB2340.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(346002)(39860400002)(376002)(396003)(136003)(451199015)(2906002)(44832011)(5660300002)(6200100001)(36756003)(37006003)(316002)(8936002)(6862004)(8676002)(4326008)(41300700001)(66946007)(66556008)(66476007)(6506007)(478600001)(6486002)(966005)(86362001)(6512007)(53546011)(2616005)(186003)(83380400001)(38100700002)(6666004)(142923001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6dcEQGezYkULWeo8F4WjANVJ/STMFgcmw1omGc6z4sLWpO9GTUbs1kvsyeS/?= =?us-ascii?Q?eiA8XGkZqUpFtaFIeEf9tCRPDuqXYGvGHnLpzdY169Wg5igO+cR+cpQAwu3k?= =?us-ascii?Q?z2w3J6MCBGzueLotCaYo/h+5jJhJ6mrmdzno4OXk0OUC0tgIlvPoCzbew28A?= =?us-ascii?Q?ZeM8MJ8BVEZ6lNNZAUwy149Qr/qBdwB/pKVSxC7CXB+xjhLt24nEgdtrk2wx?= =?us-ascii?Q?zYTg0CHM7gNeJqReqIM/yrMQRt/J4ijevNf21YtfxZqef+2UhOuafAhiS8B0?= =?us-ascii?Q?FdFoLWgxIj4pmQEzhZvgkc+NbgnWBXuGc88KJP/k+ow9MW7tB/2mD82JZDc1?= =?us-ascii?Q?UYu4TnDCz3Le9RGkgGfEl1JBVDFav42Amj8DE/VZQzkY3Of7rhOhZSzs/Mns?= =?us-ascii?Q?au8FmrltED0J0pFGAge7ZaVt8eKFNOCxRkw9/lGipuWxWh1nfcW7DzBJdgO4?= =?us-ascii?Q?eLAqRpev0wl5zf+7UojBP0MbncU5zelEo6i8AfsdMuLtV/1z2jQKJK4wLcdG?= =?us-ascii?Q?B4Wz6tFDhslDl8C88p8FR7SaqOhtWf02lq/IFuzdP8p4W2FZLIXxc/vxmcHm?= =?us-ascii?Q?Tx70T/pr2ioddWYfBIxNBWDMc/J1D64BqedHzaAOkwFG4xIkJER7XqXgiMDE?= =?us-ascii?Q?JLgrMl15ocYkXcSW3dsTVaYHR6sDs3/+WVAGm/ExNHSc1tkVf/UOMLPyxjhl?= =?us-ascii?Q?TxyklAm36Mr4B7ixBf8SuqRzstRtu73Kf8vd34Boa6Z32AkxpBKGxCEa4NJG?= =?us-ascii?Q?V0P8xD6QbyDak25PGgk23krbBZB5ztk2ktHuST91za5oLdmVNbeONdEH7cWI?= =?us-ascii?Q?35xS2BtVndoGV0B8lQ1EZ+hRRAvGUP/T6rYOHj1rcsWDr1xPFGULFyK5J4gq?= =?us-ascii?Q?PxyMi5LQZaoDeZD09lvNDWSjKkn7Exg9Oi8XvCoa0u1yih6jC6ZIs46DkDSi?= =?us-ascii?Q?ZZQNMcBHm43/fQZbpPt3m+WLvZo+C2HkUmRa86bp2lbHuvtDFUm7h0uEhZ0a?= =?us-ascii?Q?IcGUgoplq+IgJxSMswHST2GhsJTiFc7RJUxtPvtvG+DfbXoyXREq5PBGPp+m?= =?us-ascii?Q?4ihmaVMCe+GR9gCkg9u79PvZr4jWHFhrJ0mzyzlW48FHr2Lz4TR8fS3At5VB?= =?us-ascii?Q?1Cs84xiO447GKgmA+xKWuLZ06yA+HEDmRpKlUtcFVJN0uSH9mx0/nXjSLEmQ?= =?us-ascii?Q?eMEfBi6jbk3iwVPUqjf7MYS56aEA87T2Od+XGCS7IJRp38dyggteF1A56M6a?= =?us-ascii?Q?PZIubs3/wPYxc9bnVVmhFIq/dpIjOW2bAI1hsVIkCxGNN77KHnrZX1x9X+HN?= =?us-ascii?Q?/ci0CTZFe6/0tDiDucCz9rt7SfQpNcVDaWpkhQhcIU2O4r06b/NXbcn78leC?= =?us-ascii?Q?c/SxltQd8S5lXRo7Ux/E2Cczn8akH9N39ZC3zWrFxohvD5fvWhgHifYs061M?= =?us-ascii?Q?tDoeFfZ5hDM3FwPv2wzQTePRBkVqj0K6D4CYGdN0GUiukFMHYvkVY25lLU8l?= =?us-ascii?Q?NzsAAdusPhjz3KWWRcfBg+QP+GFo4/E27mQcw10AQIqARkcEWMUrLe2OpkZ7?= =?us-ascii?Q?aB8PwYFeuuKR7jzCPEtW0uTU72dNO3kEfPF4WXN4OsfDZWiULNOVuFuppsOy?= =?us-ascii?Q?9zmUwAhdZlB6WRkGKu5HhQI=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2af160f-41cc-4feb-e749-08dae440f47a X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2340.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2022 17:21:25.9894 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i4RddpoLNadO2GCFF6jbpYHeStLg3kWvo2R+TifXncg36eleGwqQNNv8nRy7fV/Ma5m+iY6MUw/Aq/72/KHZG6Qoy6VSNiaglo7JxdfOd7Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5040 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-22_09,2022-12-22_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 mlxscore=0 adultscore=0 phishscore=0 suspectscore=0 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2212220147 X-Proofpoint-ORIG-GUID: ATAppUCU7JQqHeB2NgGsJDS7l-Uh2i3k X-Proofpoint-GUID: ATAppUCU7JQqHeB2NgGsJDS7l-Uh2i3k X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Cupertino Miranda via Gcc-patches writes: > gentle ping > > Cupertino Miranda writes: > >> Hi Jeff, >> >> First of all thanks for your quick review. >> Apologies for the delay replying, the message got lost in my inbox. >> >>> On 12/2/22 10:52, Cupertino Miranda via Gcc-patches wrote: >>>> Changed target code to select .rodata section for 'const volatile' >>>> defined variables. >>>> This change is in the context of the bugzilla #170181. >>>> gcc/ChangeLog: >>>> v850.c(v850_select_section): Changed function. >>> I'm not sure this is safe/correct. ISTM that you need to look at the underlying >>> TREE_TYPE to check for const-volatile rather than TREE_SIDE_EFFECTS. >> >> I believe this was asked by Jose when he first sent the generic patches. >> Please notice my change is influenced by his original patch that does >> the same and was approved. >> >> https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599348.html >> https://gcc.gnu.org/pipermail/gcc-patches/2022-September/602374.html >> >>> >>> Of secondary importance is the ChangeLog. Just saying "Changed function" >>> provides no real information. Something like this would be better: >>> >>> * config/v850/v850.c (v850_select_section): Put const volatile >>> objects into read-only sections. >>> >>> >>> Jeff >>> >>> >>> >>> >>>> --- >>>> gcc/config/v850/v850.cc | 1 - >>>> 1 file changed, 1 deletion(-) >>>> diff --git a/gcc/config/v850/v850.cc b/gcc/config/v850/v850.cc >>>> index c7d432990ab..e66893fede4 100644 >>>> --- a/gcc/config/v850/v850.cc >>>> +++ b/gcc/config/v850/v850.cc >>>> @@ -2865,7 +2865,6 @@ v850_select_section (tree exp, >>>> { >>>> int is_const; >>>> if (!TREE_READONLY (exp) >>>> - || TREE_SIDE_EFFECTS (exp) >>>> || !DECL_INITIAL (exp) >>>> || (DECL_INITIAL (exp) != error_mark_node >>>> && !TREE_CONSTANT (DECL_INITIAL (exp))))