From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 619F0386F435 for ; Tue, 24 Nov 2020 09:51:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 619F0386F435 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Thomas_Schwinge@mentor.com IronPort-SDR: XT/+RQkkYKkZE0M350mVqYGgGbrem3QQT9QotgV0m0M+jhQaBJfAzjx3ATja/mmn+cw6gf2QU3 Ke7b0kws5WcShz0QUfvYX02dkn813BamcNja4hZoIlc+hpxihexvu5gGexlYQgHfcd5sFGQH2o iUjAg86VP9hnoMfyvSLfsAanG7RzmWkEd1uRyqynTmgse/RK4rTcffDtiH8M0++u+fzSsrssXZ cGdGUT1IKP+IHOJNutP0dgRt+Yh5wGvsnXjDWnoZggL3ax5H7X3S7widQOiylJz3pC4dWmpGUJ 6ps= X-IronPort-AV: E=Sophos;i="5.78,365,1599552000"; d="scan'208,223";a="55408203" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 24 Nov 2020 01:51:23 -0800 IronPort-SDR: m96pdzUFkHtK+y+sANy7YQ0PESlK0bjXP5lFfNn82Z0W+bV7OujYinrGTKSb7gxKKibqlSy8Zu Z/E40fk6FpmStrrOqUehg9Y/DNp/kBChpX/Veial2ajipy+TMsWFGoPkqZnbO5TUfrfsHrxXBK eyMEuyyUu7rHIW3eM/WtVDrj12hqSSNmm4BsjvwSKuh4HQH4DPykqOO6QhAOnT6/apIAAJx8G7 dkfD5+g4DRdihj6l+lYg8XcL9WGNa09gxFGQFUJz/xaCCKIppj2lp3BT4xjG6A1ahlfJlr+fcO c50= From: Thomas Schwinge To: Jeff Law , David Malcolm , Subject: Re: [PATCH] dumpfile.c: use prefixes other that 'note: ' for MSG_{OPTIMIZED_LOCATIONS|MISSED_OPTIMIZATION} In-Reply-To: References: <1537905614-44303-1-git-send-email-dmalcolm@redhat.com> <87mtzueumz.fsf@euler.schwinge.homeip.net> User-Agent: Notmuch/0.29.1+93~g67ed7df (https://notmuchmail.org) Emacs/25.2.2 (x86_64-pc-linux-gnu) Date: Tue, 24 Nov 2020 10:51:16 +0100 Message-ID: <87zh3784mj.fsf@dem-tschwing-1.ger.mentorg.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-09.mgc.mentorg.com (139.181.222.9) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_LOTSOFHASH, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Nov 2020 09:51:26 -0000 --=-=-= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi! On 2020-11-13T15:06:45-0700, Jeff Law wrote: > On 11/6/20 1:50 AM, Thomas Schwinge wrote: >> On 2018-09-25T16:00:14-0400, David Malcolm wrote: >>> The patch adds "dg-optimized" and "dg-missed" directives >> These currently print "(test for *errors*, line [...])". However, these >> diagnostics are not actually error diagnostics (fatal, meaning: causes >> compilation to fail) but rather warning diagnostics (non-fatal, doesn't >> cause compilation to fail). Thus, same as 'dg-message', these should us= e >> 'saved-dg-warning' instead of 'saved-dg-error', which will print: "(test >> for *warnings*, line [...])". OK to change that after regression >> testing? > > Yes. Thanks, pushed "[testsuite] Emit 'warning' instead of 'error' diagnostics for 'dg-optimized', 'dg-missed'" to master branch in commit 54f72078fc05b865601645edafbc6b21701ea546, and backported to releases/gcc-10 branch in commit 51bec3f6aa1218aeaa8e5e8cdef28fe712ba2902, and releases/gcc-9 branch in commit b5eabef5daa1393763f2f6df6562d0c4c8ef63ab, see attached. (Functionality not present in releases/gcc-8 branch.) Gr=C3=BC=C3=9Fe Thomas ----------------- Mentor Graphics (Deutschland) GmbH, Arnulfstra=C3=9Fe 201, 80634 M=C3=BCnch= en / Germany Registergericht M=C3=BCnchen HRB 106955, Gesch=C3=A4ftsf=C3=BChrer: Thomas = Heurung, Alexander Walter --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename="0001-testsuite-Emit-warning-instead-of-error-diagnostics-.patch" >From 54f72078fc05b865601645edafbc6b21701ea546 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Fri, 6 Nov 2020 09:51:16 +0100 Subject: [PATCH] [testsuite] Emit 'warning' instead of 'error' diagnostics for 'dg-optimized', 'dg-missed' The diagnostics produced by 'dg-optimized', 'dg-missed' aren't error diagnostics (fatal, meaning: causes compilation to fail) but rather warning diagnostics (non-fatal, doesn't cause compilation to fail). Thus, same as 'dg-message', these should use 'saved-dg-warning' instead of 'saved-dg-error', which then prints: "(test for *warnings*, line [...]) instead of currently: "(test for *errors*, line [...])". This is a small bug-fix for commit ed2d9d3720adef3a260b8a55e17e744352a901fc "dumpfile.c: use prefixes other than 'note: ' for MSG_{OPTIMIZED_LOCATIONS|MISSED_OPTIMIZATION}", which added 'dg-optimized', 'dg-missed'. gcc/testsuite/ * lib/gcc-dg.exp (dg-optimized, dg-missed): Use 'saved-dg-warning' instead of 'saved-dg-error'. --- gcc/testsuite/lib/gcc-dg.exp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/lib/gcc-dg.exp b/gcc/testsuite/lib/gcc-dg.exp index 0e1aafec82f..700529afbe2 100644 --- a/gcc/testsuite/lib/gcc-dg.exp +++ b/gcc/testsuite/lib/gcc-dg.exp @@ -1232,7 +1232,7 @@ proc dg-optimized { args } { # Make this variable available here and to the saved proc. upvar dg-messages dg-messages - process-message saved-dg-error "optimized:" "$args" + process-message saved-dg-warning "optimized:" "$args" } # Handle output from -fopt-info for MSG_MISSED_OPTIMIZATION: @@ -1242,7 +1242,7 @@ proc dg-missed { args } { # Make this variable available here and to the saved proc. upvar dg-messages dg-messages - process-message saved-dg-error "missed:" "$args" + process-message saved-dg-warning "missed:" "$args" } # Check the existence of a gdb in the path, and return true if there -- 2.17.1 --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename="0001-testsuite-Emit-warning-instead-of-error-diagnost.g10.patch" >From 51bec3f6aa1218aeaa8e5e8cdef28fe712ba2902 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Fri, 6 Nov 2020 09:51:16 +0100 Subject: [PATCH] [testsuite] Emit 'warning' instead of 'error' diagnostics for 'dg-optimized', 'dg-missed' The diagnostics produced by 'dg-optimized', 'dg-missed' aren't error diagnostics (fatal, meaning: causes compilation to fail) but rather warning diagnostics (non-fatal, doesn't cause compilation to fail). Thus, same as 'dg-message', these should use 'saved-dg-warning' instead of 'saved-dg-error', which then prints: "(test for *warnings*, line [...]) instead of currently: "(test for *errors*, line [...])". This is a small bug-fix for commit ed2d9d3720adef3a260b8a55e17e744352a901fc "dumpfile.c: use prefixes other than 'note: ' for MSG_{OPTIMIZED_LOCATIONS|MISSED_OPTIMIZATION}", which added 'dg-optimized', 'dg-missed'. gcc/testsuite/ * lib/gcc-dg.exp (dg-optimized, dg-missed): Use 'saved-dg-warning' instead of 'saved-dg-error'. (cherry picked from commit 54f72078fc05b865601645edafbc6b21701ea546) --- gcc/testsuite/lib/gcc-dg.exp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/lib/gcc-dg.exp b/gcc/testsuite/lib/gcc-dg.exp index cc331214a1f..58519b0421b 100644 --- a/gcc/testsuite/lib/gcc-dg.exp +++ b/gcc/testsuite/lib/gcc-dg.exp @@ -1216,7 +1216,7 @@ proc dg-optimized { args } { # Make this variable available here and to the saved proc. upvar dg-messages dg-messages - process-message saved-dg-error "optimized:" "$args" + process-message saved-dg-warning "optimized:" "$args" } # Handle output from -fopt-info for MSG_MISSED_OPTIMIZATION: @@ -1226,7 +1226,7 @@ proc dg-missed { args } { # Make this variable available here and to the saved proc. upvar dg-messages dg-messages - process-message saved-dg-error "missed:" "$args" + process-message saved-dg-warning "missed:" "$args" } # Check the existence of a gdb in the path, and return true if there -- 2.17.1 --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename="0001-testsuite-Emit-warning-instead-of-error-diagnosti.g9.patch" >From b5eabef5daa1393763f2f6df6562d0c4c8ef63ab Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Fri, 6 Nov 2020 09:51:16 +0100 Subject: [PATCH] [testsuite] Emit 'warning' instead of 'error' diagnostics for 'dg-optimized', 'dg-missed' The diagnostics produced by 'dg-optimized', 'dg-missed' aren't error diagnostics (fatal, meaning: causes compilation to fail) but rather warning diagnostics (non-fatal, doesn't cause compilation to fail). Thus, same as 'dg-message', these should use 'saved-dg-warning' instead of 'saved-dg-error', which then prints: "(test for *warnings*, line [...]) instead of currently: "(test for *errors*, line [...])". This is a small bug-fix for commit ed2d9d3720adef3a260b8a55e17e744352a901fc "dumpfile.c: use prefixes other than 'note: ' for MSG_{OPTIMIZED_LOCATIONS|MISSED_OPTIMIZATION}", which added 'dg-optimized', 'dg-missed'. gcc/testsuite/ * lib/gcc-dg.exp (dg-optimized, dg-missed): Use 'saved-dg-warning' instead of 'saved-dg-error'. (cherry picked from commit 54f72078fc05b865601645edafbc6b21701ea546) --- gcc/testsuite/lib/gcc-dg.exp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/lib/gcc-dg.exp b/gcc/testsuite/lib/gcc-dg.exp index c2600f2b746..b756f7c80f9 100644 --- a/gcc/testsuite/lib/gcc-dg.exp +++ b/gcc/testsuite/lib/gcc-dg.exp @@ -1225,7 +1225,7 @@ proc dg-optimized { args } { # Make this variable available here and to the saved proc. upvar dg-messages dg-messages - process-message saved-dg-error "optimized:" "$args" + process-message saved-dg-warning "optimized:" "$args" } # Handle output from -fopt-info for MSG_MISSED_OPTIMIZATION: @@ -1235,7 +1235,7 @@ proc dg-missed { args } { # Make this variable available here and to the saved proc. upvar dg-messages dg-messages - process-message saved-dg-error "missed:" "$args" + process-message saved-dg-warning "missed:" "$args" } # Check the existence of a gdb in the path, and return true if there -- 2.17.1 --=-=-=--