From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59299 invoked by alias); 23 Aug 2017 18:28:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 59086 invoked by uid 89); 23 Aug 2017 18:28:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=unavailable version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Aug 2017 18:28:45 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DC9D84ACCB; Wed, 23 Aug 2017 18:28:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DC9D84ACCB Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj@redhat.com Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6A2B060F9C; Wed, 23 Aug 2017 18:28:34 +0000 (UTC) From: Sergio Durigan Junior To: Pedro Alves Cc: GDB Patches , GCC Patches , Tom Tromey , Keith Seitz , Phil Muldoon , Alexandre Oliva Subject: Re: [libcc1] Improve detection of triplet on compiler names References: <87mv6qhq9u.fsf@redhat.com> Date: Wed, 23 Aug 2017 19:42:00 -0000 In-Reply-To: (Pedro Alves's message of "Wed, 23 Aug 2017 19:18:29 +0100") Message-ID: <87ziaqw33i.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg01394.txt.bz2 On Wednesday, August 23 2017, Pedro Alves wrote: > On 08/23/2017 05:17 AM, Sergio Durigan Junior wrote: >> Hi there, >> >> This is a series of two patches, one for GDB and one for GCC, which aims >> to improve the detection and handling of triplets present on compiler >> names. The motivation for this series was mostly the fact that GDB's >> "compile" command is broken on Debian unstable, as can be seen here: >> >> >> >> The reason for the failure is the fact that Debian compiles GCC using >> the --program-{prefix,suffix} options from configure in order to name >> the compiler using the full triplet (i.e., Debian's GCC is not merely >> named "gcc", but e.g. "x86_64-linux-gnu-gcc-7"), which end up naming the >> C_COMPILER_NAME and CP_COMPILER_NAME defines with the specified prefix >> and suffix. Therefore, the regexp being used to match the compiler name >> is wrong because it doesn't take into account the fact that the defines >> may already contain the triplets. > > As discussed on IRC, I think the problem is that C_COMPILER_NAME > in libcc1 includes the full triplet in the first place. I think > that it shouldn't. I think that C_COMPILER_NAME should always > be "gcc". Thanks for summarizing the discussion. I tend to agree with the rationale, and having C_COMPILER_NAME as "gcc" is also a valid fix for the original problem. As I said, I'd also like to hear others' opinions about the issue. I can then submit a proper patch. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/